[PAID] Render Error in android emulator

[mountiny]

Problem

Coming from here

One way to get this warning is - in the development emulator:
Not a steps that a regular user could follow:

1. Open App
2. Go to the settings page
3. Overwrite the hasCompletedGuidedSetupFlowSelector(onboarding function to return false
   

this is mainly developer experience improvement as it is misleading and slowing down the developers if they run into issues like this

Solution

Make sure we cannot run into this warning

Issue Owner

Current Issue Owner: @strepanier03

[mountiny]

SWM will work on this

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[adamgrzybowski]

Hi, I will take care of that 👋

[mountiny]

thanks!

[s77rt]

Checking this again, I'm not exactly sure how I reproduced the bug but either way making the function platform specific should do

[mountiny]

$125 to @s77rt as it was just an emulator DX improvement

[strepanier03]

Looks like the PR went to staging so once it's on prod I'll set a start timer on the payment hold.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Create platform specific syncBrowserHistory function #50719

If no regressions arise, payment will be issued on 2024-10-24. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @adamgrzybowski does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Dismissing onboarding fix  #45327
• The offending PR has been commented on: Dismissing onboarding fix  #45327 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @s77rt owed $125 via NewDot
• Contributor: @adamgrzybowski is from an agency-contributor and not due payment

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[s77rt]

It's $125 ^

[strepanier03]

@s77rt - Okay, I've updated the price in the payment summary above and I see your checklist responses. Feel free to request in New Expensify.

[JmillsExpensify]

$125 approved for @s77rt

[strepanier03]

This is all paid, closing now.