[HOLD for payment 2024-10-24] [HOLD for payment 2024-10-22] iOS - IOU - Page flickers when selecting different payment option on IOU preview

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.48.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5077885
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Open the Hybrid app/NewDot app and log in as user A
2. On a secondary device as user B send an IOU to user A
3. On main device as user A open the chat with user B
4. Select a different payment option on the IOU preview

Expected Result:

The page does not flicker when changing a payment option

Actual Result:

The page flickers when changing a payment option. It also occurs on the transaction details.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6633027_1728764651785.IMG_0436.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @VictoriaExpensify

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

Production

RPReplay_Final1728909064.MP4

[izarutskaya]

I'm not sure what Deploy.. labels is needed since there is no option Use Staging Served in the Hybrid App

[dangrous]

@izarutskaya does this also happen on the App itself? or only in Hybrid App? Thanks!

[izarutskaya]

Hi @dangrous This issue happens on NewDot app too, not only Hybrid App

[dangrous]

thats helpful thank you! working on reproducing, will investigate

[dangrous]

hrm i'm not able to reproduce on a simulator. I also don't see an obvious PR. Will keep looking.

[dangrous]

oh okay figured out what it is related to - it's something about the software keyboard. I'm now able to reproduce locally so should be able to get this figured out soon.

[dangrous]

Removing backend blocker, seems to happen equivalently on prod

[dangrous]

it's due to #50279, figuring out why

[dangrous]

I think we might want to revert, it looks like #50279 also would reopen #50636 so that would be two bugs.... I also haven't figured out the specific cause yet, though I'm guessing it's the withOnyx / useOnyx because that seems to keep causing weird bugs

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[kavimuru]

Bug is fixed

RPReplay_Final1728947749.MP4

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.48-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert #52079 #50746

If no regressions arise, payment will be issued on 2024-10-22. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dangrous] The PR that introduced the bug has been identified. Link to the PR:
• [@dangrous] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dangrous] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dangrous] Determine if we should create a regression test for this bug.
• [@dangrous] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dangrous]

Closing this, it was a revert (and internal) so no regression period needed.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Revert #52079 #50746

If no regressions arise, payment will be issued on 2024-10-24. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dangrous] The PR that introduced the bug has been identified. Link to the PR:
• [@dangrous] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@dangrous] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@dangrous] Determine if we should create a regression test for this bug.
• [@dangrous] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: