fix: 10731 #50279

christianwen · 2024-10-05T03:56:45Z

Details

Fixed Issues

$ #10731
PROPOSAL: #10731 (comment)

Tests

Go to any chats
Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown
Sent any message
Open edit mode
Verify that the keyboard is shown
Tap on the composer to bring up context menu.
Verify the context menu is shown

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go to any chats
Verify that the composer is focused and the virtual keyboard is not shown. After touching on the composer, the keyboard is shown
Sent any message
Open edit mode
Verify that the keyboard is shown
Tap on the composer to bring up context menu.
Verify the context menu is shown

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-05.at.11.39.47.mov

Android: mWeb Chrome

Screen.Recording.2024-10-05.at.11.35.48.mov

iOS: Native

Screen.Recording.2024-10-05.at.11.36.57.mov

iOS: mWeb Safari

Screen.Recording.2024-10-05.at.11.29.00.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-05.at.11.00.27.mov

MacOS: Desktop

Screen.Recording.2024-10-05.at.11.42.27.mov

melvin-bot · 2024-10-05T04:43:20Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-10-07T09:18:44Z

src/components/Composer/index.tsx

@@ -73,6 +73,7 @@ function Composer(
        isComposerFullSize = false,
        shouldContainScroll = true,
        isGroupPolicyReport = false,
+        showSoftInputOnFocus = true,


This is the change compared to the previous PR. In this PR, we add the default value is true for showSoftInputOnFocus

DylanDylann · 2024-10-07T11:01:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-07.at.18.01.47.mov

Android: mWeb Chrome

Screen.Recording.2024-10-07.at.18.02.20.mov

iOS: Native

Screen.Recording.2024-10-07.at.18.02.59.mov

iOS: mWeb Safari

Screen.Recording.2024-10-07.at.18.04.14.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-07.at.18.03.48.mov

MacOS: Desktop

Screen.Recording.2024-10-07.at.18.06.12.mov

DylanDylann · 2024-10-07T11:11:18Z

Same here: #32711 (comment)

Just a note:

Changed files ESLint check
This action failed because of https://expensify.slack.com/archives/C01GTK53T8Q/p1726169039084589. This PR is complicated, so I think we should migrate withOnyx to useOnyx in another PR

Reassure Performance Tests
As mentioned above

Updated! For the perf issue, we shouldn't mind about it since this test is to compare the number of re-render when users interact with input in baseline (from main) with the current behavior (this PR). In this PR we try to open the keyboard when they focus on the composer -> it takes 2 times to re-render

This PR will change the current behavior on purpose

iwiznia · 2024-10-07T18:54:07Z

src/components/Composer/index.tsx

@@ -388,6 +389,7 @@ function Composer(
                value={value}
                defaultValue={defaultValue}
                autoFocus={autoFocus}
+                inputMode={!showSoftInputOnFocus ? 'none' : 'text'}


NAB, I think removing the negation makes it clearer:

Suggested change

inputMode={!showSoftInputOnFocus ? 'none' : 'text'}

inputMode={showSoftInputOnFocus ? 'text' : 'none'}

iwiznia · 2024-10-07T19:09:28Z

src/components/Composer/types.ts

+
+    showSoftInputOnFocus?: boolean;


Doesn't this need a description?

iwiznia · 2024-10-07T19:10:25Z

ESLint check failed

DylanDylann · 2024-10-08T08:13:24Z

ESLint check failed

@iwiznia I explained about it above. Do you agree with that?

christianwen · 2024-10-09T04:36:15Z

@DylanDylann @iwiznia I updated the PR

iwiznia · 2024-10-09T12:58:18Z

I explained about it #50279 (comment). Do you agree with that?

Maybe I could, but in the previous PR we also said this:

so I think we should migrate withOnyx to useOnyx in another PR

And I don't see we did it, since it is appearing here again in the same file.

iwiznia · 2024-10-09T12:59:27Z

So, I think we can either:

Send a PR to fix the withOnyx use and merge it, then merge main into this branch and merge it
Fix the withOnyx use in this PR

I am fine with either, but I don't think I want to keep kicking the can on fixing this usage of withOnyx

christianwen · 2024-10-10T08:00:31Z

@DylanDylann It's ready for review

DylanDylann

LGTM

DylanDylann · 2024-10-10T11:45:49Z

@iwiznia All yours

OSBotify · 2024-10-10T14:43:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-10T23:11:17Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.0.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

m-natarajan · 2024-10-11T18:49:41Z

Failing with #10731 in mWeb.
https://platform.applause.com/services/links/v1/external/d9133d22241138133a4af512a53010b533470a534eff2bb3d3a3cbeea6c7f561

dangrous · 2024-10-14T17:23:55Z

hi friends, looks like this caused #50722 - can you take a look? (I bisected). I think the keyboard is popping up and immediately hiding when you change the pay method. I'll look too but wanted to call out

marcochavezf · 2024-10-14T21:18:06Z

Also caused this one #50683

DylanDylann · 2024-10-15T02:59:31Z

@christianwen Please help to check these problems

github-actions · 2024-10-15T03:16:58Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.48-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

christianwen added 2 commits October 5, 2024 10:52

fix: 10731

8595df0

fix context menu

2cd4727

christianwen marked this pull request as ready for review October 5, 2024 04:43

christianwen requested a review from a team as a code owner October 5, 2024 04:43

melvin-bot bot requested review from DylanDylann and removed request for a team October 5, 2024 04:43

DylanDylann reviewed Oct 7, 2024

View reviewed changes

DylanDylann approved these changes Oct 7, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia October 7, 2024 11:16

iwiznia reviewed Oct 7, 2024

View reviewed changes

add comment

a31b2fe

christianwen added 2 commits October 10, 2024 14:35

remove withOnyx

2f17492

lint fix

9abb04f

DylanDylann approved these changes Oct 10, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia October 10, 2024 11:45

iwiznia approved these changes Oct 10, 2024

View reviewed changes

iwiznia merged commit da700c5 into Expensify:main Oct 10, 2024
16 of 17 checks passed

nkdengineer mentioned this pull request Oct 10, 2024

[HOLD for payment 2024-11-07] [$250] Task description is covered by the keyboard pop up #50346

Closed

6 tasks

github-actions bot mentioned this pull request Oct 10, 2024

Deploy Checklist: New Expensify 2024-10-10 #50603

Closed

38 tasks

bondydaa mentioned this pull request Oct 11, 2024

[$250] Hybrid app - Chat - App crashes when receiving a Split request #50670

Closed

8 tasks

This was referenced Oct 14, 2024

[HOLD for payment 2024-10-24] [HOLD for payment 2024-10-22] iOS - IOU - Page flickers when selecting different payment option on IOU preview #50722

Closed

Revert #52079 #50746

Merged

melvin-bot bot mentioned this pull request Oct 15, 2024

[HOLD for payment 2024-10-22] [$2000] Android/IOS - Split/request money - Chat composer is focused after IOU request from green plus button #10731

Open

QichenZhu mentioned this pull request Oct 15, 2024

[$250] keyboard hides unexpectedly when adding a new task on the report screen #50442

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 10731 #50279

fix: 10731 #50279

christianwen commented Oct 5, 2024 •

edited

Loading

melvin-bot bot commented Oct 5, 2024

DylanDylann Oct 7, 2024

DylanDylann commented Oct 7, 2024 •

edited

Loading

DylanDylann commented Oct 7, 2024 •

edited

Loading

iwiznia Oct 7, 2024

iwiznia Oct 7, 2024

iwiznia commented Oct 7, 2024

DylanDylann commented Oct 8, 2024

christianwen commented Oct 9, 2024

iwiznia commented Oct 9, 2024

iwiznia commented Oct 9, 2024

christianwen commented Oct 10, 2024

DylanDylann left a comment

DylanDylann commented Oct 10, 2024

OSBotify commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

m-natarajan commented Oct 11, 2024 •

edited

Loading

dangrous commented Oct 14, 2024

marcochavezf commented Oct 14, 2024

DylanDylann commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

	inputMode={!showSoftInputOnFocus ? 'none' : 'text'}
	inputMode={showSoftInputOnFocus ? 'text' : 'none'}

fix: 10731 #50279

fix: 10731 #50279

Conversation

christianwen commented Oct 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 5, 2024

DylanDylann Oct 7, 2024

Choose a reason for hiding this comment

DylanDylann commented Oct 7, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Oct 7, 2024 • edited Loading

iwiznia Oct 7, 2024

Choose a reason for hiding this comment

iwiznia Oct 7, 2024

Choose a reason for hiding this comment

iwiznia commented Oct 7, 2024

DylanDylann commented Oct 8, 2024

christianwen commented Oct 9, 2024

iwiznia commented Oct 9, 2024

iwiznia commented Oct 9, 2024

christianwen commented Oct 10, 2024

DylanDylann left a comment

Choose a reason for hiding this comment

DylanDylann commented Oct 10, 2024

OSBotify commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

m-natarajan commented Oct 11, 2024 • edited Loading

dangrous commented Oct 14, 2024

marcochavezf commented Oct 14, 2024

DylanDylann commented Oct 15, 2024

github-actions bot commented Oct 15, 2024

christianwen commented Oct 5, 2024 •

edited

Loading

DylanDylann commented Oct 7, 2024 •

edited

Loading

DylanDylann commented Oct 7, 2024 •

edited

Loading

m-natarajan commented Oct 11, 2024 •

edited

Loading