Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2021-09-03 #5086

Closed
14 tasks done
OSBotify opened this issue Sep 3, 2021 · 8 comments
Closed
14 tasks done

Deploy Checklist: New Expensify 2021-09-03 #5086

OSBotify opened this issue Sep 3, 2021 · 8 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2021 •
edited by ctkochan22
Loading

Release Version: 1.0.94-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads
@isagoico
Copy link

isagoico commented Sep 6, 2021

Starting QA!

@isagoico isagoico added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Sep 6, 2021
@isagoico
Copy link

isagoico commented Sep 6, 2021 •
edited
Loading

Regression is finished, issues found:

  1. Settings - Bank Name is not saved when adding bank account #5104
  2. Workspace - Clicking Manage cards takes user to 404 page #5105
  3. Profile - Corresponding pronoun in Spanish is not displayed when switching language #5113
  4. Chat- Incorrect unread messages shown in green badge after "marked as unread" for any message #5106
  5. [HOLD for payment 2021-11-04] Request / Split money - Cursor autofocus not regained after changing the currency #5102
  6. [HOLD for payment 2021-09-22] iOS - Chat- Menu options after selecting add attachment is not translated to Spanish #5103

PR #4653 is failing because of #5104

Thanks!

CC @Expensify/mobile-deployers

@MelvinBot MelvinBot added the Monthly KSv2 label Sep 7, 2021
@roryabraham
Copy link
Contributor

Confirmed that #5126 is fixed on staging, checking it off on the checklist.

@roryabraham
Copy link
Contributor

Neither #4653 nor #5104 passed QA, but they will not be treated as deploy-blockers at this time. So I'm checking them off.

@ctkochan22
Copy link
Contributor

Pushed a CP, we should be good.

@OSBotify
Copy link
Contributor Author

OSBotify commented Sep 8, 2021

Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!

@OSBotify OSBotify reopened this Sep 8, 2021
@ctkochan22
Copy link
Contributor

Oops sorry.

@yuwenmemon
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@yuwenmemon @MelvinBot @ctkochan22 @applausebot @isagoico @roryabraham @OSBotify