Fix exitTo link by adding missing ? #5135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Trying to figure out QA steps |
roryabraham
approved these changes
Sep 8, 2021
|
|
github-actions bot
pushed a commit
that referenced
this pull request
Sep 8, 2021
Fix exitTo link by adding missing ? (cherry picked from commit 81ff8d4)
This was referenced Sep 8, 2021
|
🚀 Cherry-picked to staging by @ctkochan22 in version: 1.0.94-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
18 tasks
|
🚀 Deployed to production by @yuwenmemon in version: 1.0.94-1 🚀
|
|
🚀 Deployed to staging by @ctkochan22 in version: 1.0.94-2 🚀
|
|
@ctkochan22 @roryabraham Can you help us and provide QA steps (if any) for this PR |
|
Its a bit tricky. I tested it on staging already though |
|
@mvtglobally you can check off! |
|
🚀 Deployed to production by @yuwenmemon in version: 1.0.95-1 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@roryabraham or @tgolen
Fix link by adding missing
?Details
Fixed Issues
$ #5105
Original PR: https://github.com/Expensify/App/pull/4789/files#diff-fed84caebc7e71b17fe9ac17cd04c5ec5aa8ce8a9f2ddc2ad33eb77253560a2eL91
Tests
Strangely annoying. Need to setup a workspace where you have the cards enabled so that you can click "manage cards"
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android