[HOLD for payment 2024-11-05] [$250] Some table rows have > right caret

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.50-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729177128009089

Action Performed:

1. Open the workspace members page, Expenses page
2. Open categories and tags pages

Expected Result:

Should not have > at the right

Actual Result:

Right now some table rows use a right caret (>) at the end of the row, whereas others don't.
It's pretty obvious that we can tap any table row, so all of the carets from any table rows should be removed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

  

Recording.668.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021847349478186381538
• Upwork Job ID: 1847349478186381538
• Last Price Increase: 2024-10-18
• Automatic offers:
• ChavdaSachin | Contributor | 104524082

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Some table rows have >

What is the root cause of that problem?

In some tables we set right element is ListItemRightCaretWithLabel with props shouldShowCaret=true like Distance Rates page here...

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Line 123 in 8dc863f

rightElement: <ListItemRightCaretWithLabel labelText={value.enabled ? translate('workspace.common.enabled') : translate('workspace.common.disabled')} />,

What changes do you think we should make in order to solve the problem?

1. We should add props shouldShowCaret={false} to component ListItemRightCaretWithLabel

rightElement: <ListItemRightCaretWithLabel shouldShowCaret={false} labelText={value.enabled ? translate('workspace.common.enabled') : translate('workspace.common.disabled')} />,

2. We should delete the right padding because it is redundant. Remove styles.pr8 here

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Line 197 in 8dc863f

<View style={[styles.flex1, styles.flexRow, styles.justifyContentBetween, styles.pl3, styles.pr8, !canSelectMultiple && styles.m5]}>

Do the same way with categories page, tags page, tax page,...

What alternative solutions did you explore? (Optional)

NA

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-10-17 19:30:06 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Some table rows have > right caret

What is the root cause of that problem?

Feature request

What changes do you think we should make in order to solve the problem?

We can remove this caret from here. If we want to remove caret from all pages

App/src/components/SelectionList/ListItemRightCaretWithLabel.tsx

Lines 21 to 28 in f95b99b

	{shouldShowCaret && (
	<View style={[styles.pl2]}>
	<Icon
	src={Expensicons.ArrowRight}
	fill={theme.icon}
	/>
	</View>
	)}

We also don't need this style={styles.flexRow}

App/src/components/SelectionList/ListItemRightCaretWithLabel.tsx

Line 19 in f95b99b

<View style={styles.flexRow}>

Other minor styling can be adjusted in the pR

What alternative solutions did you explore? (Optional)

Instead of using component ListItemRightCaretWithLabel we can only use this in all the places

App/src/components/SelectionList/ListItemRightCaretWithLabel.tsx

Line 20 in f95b99b

{!!labelText && <Text style={[styles.alignSelfCenter, styles.textSupporting, styles.pl2, styles.label]}>{labelText}</Text>}

[Nodebrute]

Proposal Updated

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Some table rows have > right caret

What is the root cause of that problem?

Default value for shouldShowCaret is true here.

App/src/components/SelectionList/ListItemRightCaretWithLabel.tsx

Line 14 in f8c7d43

function ListItemRightCaretWithLabel({labelText, shouldShowCaret = true}: ListItemRightCaretWithLabelProps) {

And we pass shouldShowCaret={false} on some pages while don't pass prop on few other pages.

What changes do you think we should make in order to solve the problem?

Option 1: If we want to keep this component for future use.
Let's change default value to false here and remove shouldShowCaret prop from following pages.

App/src/pages/workspace/reportFields/ReportFieldsListValuesPage.tsx

Line 102 in 2c00cc5

shouldShowCaret={false}

App/src/pages/workspace/reportFields/WorkspaceReportFieldsPage.tsx

Line 121 in 2c00cc5

shouldShowCaret={false}

Option 2: If we don't want to keep this component for future use then rename and redesign it.

function ListItemWithLabel({labelText}) {
    const styles = useThemeStyles();
    const theme = useTheme();

    return (
        <View style={styles.flexRow}>
            {!!labelText && <Text style={[styles.alignSelfCenter, styles.textSupporting, styles.pl2, styles.label]}>{labelText}</Text>}        
         </View>
    );
}

and replace ListItemRightCaretWithLabel with new ListItemWithLabel component throughout.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021847349478186381538

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[fedirjh]

Thank you, everyone, for your proposals. After reviewing all the options, I think we should proceed with @ChavdaSachin proposal option 1; It’s an efficient solution that reduces the number of changed files while maintaining the flexibility to show the caret in the future if needed.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @dangrous, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[dangrous]

sounds good to me! Let's keep the flexibility for the future.

[melvin-bot]

📣 @ChavdaSachin 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ChavdaSachin]

PR is ready for review.
cc. @fedirjh

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Changed default visibility for caret - ListItemRightCaretWithLabel #51225

If no regressions arise, payment will be issued on 2024-11-05. 🎊

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment through NewDot Manual Requests
• @ChavdaSachin requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[slafortune]

@fedirjh can you please complete the checklist?

[fedirjh]

BugZero Checklist:

• Link to the PR: N/A This is a feature request.
• Link to comment: N/A
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes

Regression Test Proposal

Prerequisite : A workspace with Distance Rates, Categories, Tags, Taxes, Report Fields.

1. Navigate to Settings -> workspaces -> workspace
2. Open Distance Rates
3. Verify that '>' is not visible for list items
4. Repeat step 2-3 for Categories, Tags, Taxes, Report Fields

• Do we agree 👍 or 👎

[slafortune]

@fedirjh role C+ requires payment through NewDot Manual Requests - Due $250
@ChavdaSachin role Contributor requires payment via Upworks - Paid $250

[garrettmknight]

$250 approved for @fedirjh