[HOLD for payment 2021-09-27] IOU - Modal is shifted to the left when entering a long amount number #5115

isagoico · 2021-09-07T00:15:51Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Navigate to NewDot
Click on request money
Enter an amount of over 15 numbers

Expected Result:

Modal should stay on the visible area of the screen

Actual Result:

Modal is shifted to the left and button is not completely visible.

Workaround:

N/A

Platform:

Where is this issue confirmed?

Web

Version Number: 1.0.94-0

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

View all open jobs on GitHub

From @akshayasalvi https://expensify.slack.com/archives/C01GTK53T8Q/p1630779418448200

When I enter the 15 to 20 digits long amount in Request Money it goes out of the screen (amount is cut). Also, the button aligned is misplaced. Screenshot attached in the thread.

MelvinBot · 2021-09-07T00:15:54Z

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

akshayasalvi · 2021-09-07T04:09:54Z

Proposed Solution

If we know that we're going to have a max value for the amount then we should add a maxLength property to the amount field. I added 14 and it worked fine. Then basically it didn't messed up the alignment of the the button as well.

<TextInputAutoWidth
   inputStyle={styles.iouAmountTextInput}
   ...
   ...
   ...
   value={this.state.amount}
   maxLength={14}
/>

bondydaa · 2021-09-07T17:30:55Z

15 digits would be 900 billion max, currently the richest person in the world is Jeff Bezos with an estimated 177 billion and while I do hope we eventually have Mr Bezos using expensify to settle up his IOUs I don't think 15-20 digit numbers are going to be super common use case here so I think I agree we should just add a maxLength attribute here and be done with it.

MelvinBot · 2021-09-07T17:31:51Z

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

bondydaa · 2021-09-07T17:32:19Z

i don't think this needs to be a daily so once the job is created we could move this to weekly or monthly.

isagoico · 2021-09-07T17:39:39Z

Maybe countries with high inflations might be affected by this, e.g Venezuela, currently 1$ is equal to 4.200.000 Bs. So having an IOU of 1000$ would be 4.200.000.000 Bs. It still doesn't reach the 14 digit mark so I agree with Bondy that this will not be a common issue.

bondydaa · 2021-09-07T17:43:04Z

Yeah that crossed my mind too but for the time being I believe IOUs can only be in USD. Though something might have changed there that I might have missed so if we think it might be more common then maybe style changes are needed.

…

On Tue, Sep 7, 2021 at 11:39 AM Isabella Goicoechea < ***@***.***> wrote: Maybe countries with high inflations might be affected by this, e.g Venezuela, currently 1$ is equal to 4.200.000 Bs. So having an IOU of 1000$ would be 4.200.000.000 Bs. It still doesn't reach the 14 digit mark so I agree with Bondy that this will not be a common issue. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5115 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA7CPCWA6WY7EUESXSY37JTUAZE6NANCNFSM5DRH7AJQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

isagoico · 2021-09-07T18:00:32Z

Yeah that crossed my mind too but for the time being I believe IOUs can only be in USD

That's not correct. At the moment IOUs can be in any currency available in the currency list.

akshayasalvi · 2021-09-07T20:54:47Z

Considering that the issue is uncommon, I suggested the maxLength fix rather than the style change in the IOUModal and related child components.

MelvinBot · 2021-09-09T17:09:09Z

Triggered auto assignment to @deetergp (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

stephanieelliott · 2021-09-09T17:09:46Z

Posted to Upwork here: https://www.upwork.com/jobs/~013d0ec60b16212278

@deetergp looks like we have a proposal in this comment.

deetergp · 2021-09-09T18:10:48Z

I agree that we can kick the can down the street on 15+ digit numbers for the time being. Let's go with @akshayasalvi proposal of just adding a max length of 14 digits.

botify · 2021-09-13T17:01:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

stephanieelliott · 2021-09-13T17:38:16Z

Hey @akshayasalvi can you please propose to the job post in Upwork so I can hire and pay you for this: https://www.upwork.com/jobs/~013d0ec60b16212278

akshayasalvi · 2021-09-13T17:50:52Z

@stephanieelliott Done. Thanks for the help.

botify · 2021-09-13T19:26:21Z

🚀 Deployed to staging by @marcaaron in version: 1.0.97-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-15T20:25:12Z

🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-15T20:25:32Z

🚀 Deployed to production by @francoisl in version: 1.0.98-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-15T21:15:46Z

🚀 Deployed to staging by @francoisl in version: 1.0.98-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

botify · 2021-09-20T20:42:05Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.0.98-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

https://github.com/Expensify/App/pulls/5192\n- https://github.com/Expensify/App/pulls/5243\n

If no regressions arise, payment will be issued on 2021-09-27. 🎊

mountiny · 2021-09-20T22:35:21Z

This message is a bug, caused by today's deploy and some weird GH API behaviour. Updated the title back to what it was 🙇

akshayasalvi · 2021-09-29T18:32:27Z

@stephanieelliott Is this payment on hold?

mountiny · 2021-09-30T09:52:50Z

Was there a regression from this PR? If not, it should have been paid on 22nd September. Sorry for confusion because of the bot message 😬 @stephanieelliott

akshayasalvi · 2021-10-04T14:09:55Z

~~@stephanieelliott @mountiny Still waiting for this one to get paid out.~~

@stephanieelliott @deetergp Still waiting for this one to get paid out.

@mountiny Sorry for tagging you. I thought you were the CME.

mountiny · 2021-10-04T14:11:51Z

Yikes, apologies @akshayasalvi, we are having a bit busy times so some tasks simply slip from our radar. I will ping someone!

akshayasalvi · 2021-10-04T14:12:52Z

Thanks for the quick response @mountiny. Any expected date, so that I don't have to ping you :P

mountiny · 2021-10-04T14:14:14Z

@akshayasalvi I think someone will do it today for sure, I have pinged our team and there will be at least one one person with time to handle this. Sorry for the delay and we appreciate you patience 🙇

dylanexpensify · 2021-10-04T14:18:02Z

Scheduling payment now - sorry for the delay @akshayasalvi !

dylanexpensify · 2021-10-04T14:21:19Z

Payment sent, job posting closed!

akshayasalvi · 2021-10-04T14:23:42Z

@dylanexpensify I received half the payment I guess. I reported + resolved the issue.

dylanexpensify · 2021-10-04T14:29:01Z

Ahh my apologies @akshayasalvi! One second

akshayasalvi · 2021-10-04T14:29:22Z

@akshayasalvi I think someone will do it today for sure, I have pinged our team and there will be at least one one person with time to handle this. Sorry for the delay and we appreciate you patience 🙇

Thanks @mountiny. Received help on this. :)

akshayasalvi · 2021-10-04T14:30:04Z

Ahh my apologies @akshayasalvi! One second

No problem @dylanexpensify. Sorry if my follow up got you rushing into this

dylanexpensify · 2021-10-04T14:31:38Z

@akshayasalvi no no, you're all good!! I just sent over the bonus 😄

akshayasalvi · 2021-10-04T14:32:16Z

@akshayasalvi no no, you're all good!! I just sent over the bonus 😄

Thank you @dylanexpensify and @mountiny 😄

isagoico added Engineering Daily KSv2 labels Sep 7, 2021

MelvinBot assigned bondydaa Sep 7, 2021

bondydaa removed their assignment Sep 7, 2021

bondydaa added the External Added to denote the issue can be worked on by a contributor label Sep 7, 2021

MelvinBot assigned stephanieelliott Sep 7, 2021

stephanieelliott added the Exported label Sep 9, 2021

MelvinBot added Weekly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors and removed Daily KSv2 labels Sep 9, 2021

MelvinBot assigned deetergp Sep 9, 2021

akshayasalvi mentioned this issue Sep 10, 2021

Added maxLength to IOU Amount field #5192

Merged

5 tasks

stephanieelliott assigned akshayasalvi Sep 13, 2021

MelvinBot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 13, 2021

botify added Weekly KSv2 and removed Weekly KSv2 labels Sep 15, 2021

botify changed the title ~~[HOLD for payment 2021-09-22] IOU - Modal is shifted to the left when entering a long amount number~~ [HOLD for payment 2021-09-22] [HOLD for payment 2021-09-22] IOU - Modal is shifted to the left when entering a long amount number Sep 15, 2021

botify added Weekly KSv2 and removed Weekly KSv2 labels Sep 20, 2021

stephanieelliott changed the title ~~[HOLD for payment 2021-09-22] IOU - Modal is shifted to the left when entering a long amount number~~ [HOLD for payment 2021-09-27] IOU - Modal is shifted to the left when entering a long amount number Sep 24, 2021

dylanexpensify closed this as completed Oct 4, 2021

dylanexpensify reopened this Oct 4, 2021

dylanexpensify closed this as completed Oct 4, 2021

[HOLD for payment 2021-09-27] IOU - Modal is shifted to the left when entering a long amount number #5115

[HOLD for payment 2021-09-27] IOU - Modal is shifted to the left when entering a long amount number #5115

Comments

isagoico commented Sep 7, 2021

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platform:

MelvinBot commented Sep 7, 2021

akshayasalvi commented Sep 7, 2021

bondydaa commented Sep 7, 2021

MelvinBot commented Sep 7, 2021

bondydaa commented Sep 7, 2021

isagoico commented Sep 7, 2021

bondydaa commented Sep 7, 2021 via email

isagoico commented Sep 7, 2021

akshayasalvi commented Sep 7, 2021

MelvinBot commented Sep 9, 2021

stephanieelliott commented Sep 9, 2021

deetergp commented Sep 9, 2021

botify commented Sep 13, 2021

stephanieelliott commented Sep 13, 2021 • edited Loading

akshayasalvi commented Sep 13, 2021

botify commented Sep 13, 2021

botify commented Sep 15, 2021

botify commented Sep 15, 2021

botify commented Sep 15, 2021

botify commented Sep 20, 2021

mountiny commented Sep 20, 2021

akshayasalvi commented Sep 29, 2021

mountiny commented Sep 30, 2021

akshayasalvi commented Oct 4, 2021 • edited Loading

mountiny commented Oct 4, 2021

akshayasalvi commented Oct 4, 2021

mountiny commented Oct 4, 2021

dylanexpensify commented Oct 4, 2021

dylanexpensify commented Oct 4, 2021

akshayasalvi commented Oct 4, 2021

dylanexpensify commented Oct 4, 2021

akshayasalvi commented Oct 4, 2021

akshayasalvi commented Oct 4, 2021

dylanexpensify commented Oct 4, 2021

akshayasalvi commented Oct 4, 2021

stephanieelliott commented Sep 13, 2021 •

edited

Loading

akshayasalvi commented Oct 4, 2021 •

edited

Loading