[$250] Chat - Invalid welcome text when opening a conversation with a new user

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.52-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #49592
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with a Gmail account
3. Navigate to FAB - Start chat
4. Input and enter 1:1 DM with a Gmail account that you never had contact with

Expected Result:

Welcome should be "Say hello! This is the beginning of your chat with username. You can also use the + button to slip an expense, submin an expense, pay expenses, or assign a task!"

Actual Result:

Welcome text is "Say hello! This chat is with username. Use the + button to split, submit, or pay an expense."

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6641983_1729597990838.bandicam_2024-10-22_13-47-38-490.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021849547431797589961
• Upwork Job ID: 1849547431797589961
• Last Price Increase: 2024-11-07

Issue Owner

Current Issue Owner: @ZhenjaHorbach

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[nyomanjyotisa]

Edited by proposal-police: This proposal was edited at 2024-10-25 00:25:20 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Invalid welcome text when opening a conversation with a new user

What is the root cause of that problem?

Changes Request

What changes do you think we should make in order to solve the problem?

We need to update the reportActionsView on here and here

    reportActionsView: {
        ....
        beginningOfChatHistory: 'This is the beginning of your chat with ',
        ...
        usePlusButton: ({additionalText}: UsePlusButtonParams) => `\nYou can also use the + button to ${additionalText}!`,
        askConcierge: '\nAsk questions and get 24/7 realtime support.',
        iouTypes: {
            pay: 'pay',
            split: 'split',
            submit: 'submit',
            track: 'track',
            invoice: 'invoice',
        },
        anExpense: 'an expense',
        assignTask: 'assign a task',
    },

and update the additionalText on here

    const additionalText = `${filteredOptions.map((item) => `${translate(`reportActionsView.iouTypes.${item}`)} ${translate('reportActionsView.anExpense')}`).join(', ')} ${translate(
        'common.or',
    )} ${translate('reportActionsView.assignTask')}`;
    },

RESULT

What alternative solutions did you explore? (Optional)

Or just update the reportActionsView to

    reportActionsView: {
        ...
        beginningOfChatHistory: 'This is the beginning of your chat with ',
        ...
        usePlusButton: ({additionalText}: UsePlusButtonParams) => `\nYou can also use the + button to ${additionalText}, or assign a task!`,        
        askConcierge: '\nAsk questions and get 24/7 realtime support.',
        iouTypes: {
            pay: 'pay expenses',
            split: 'split an expense',
            submit: 'submit an expense',
            track: 'track an expense',
            invoice: 'invoice an expense',
        },
    },

and update the additionalText

const additionalText = filteredOptions.map((item) => translate(`reportActionsView.iouTypes.${item}`)).join(', ');

[nkdengineer]

The welcome text is expected here

[zanyrenney]

Well done for forgetting the expected welcome text.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021849547431797589961

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ZhenjaHorbach (External)

[ZhenjaHorbach]

#49592

Hmmm
Yes
Looks like this text is expected

@zanyrenney
Could you please check this issue ?

And we can close this issue or update the text otherwise

[melvin-bot]

@zanyrenney, @ZhenjaHorbach Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[ZhenjaHorbach]

Not overdue

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ZhenjaHorbach]

#49592

Hmmm Yes Looks like this text is expected

@zanyrenney Could you please check this issue ?

And we can close this issue or update the text otherwise

@zanyrenney
Friendly bump !

[melvin-bot]

@zanyrenney @ZhenjaHorbach this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@zanyrenney, @ZhenjaHorbach Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@zanyrenney, @ZhenjaHorbach 10 days overdue. I'm getting more depressed than Marvin.

[zanyrenney]

Ooh sorry @ZhenjaHorbach

[zanyrenney]

Checked in on the issue here I agree this looks like it is expected behaviour as per James' table of copy updates, I agree we can close this out.

[ZhenjaHorbach]

Ooh sorry @ZhenjaHorbach

No problem 😅
And thanks for checking !