[HOLD for payment 2024-10-16] [$250] Update beginningOfChatHistory for certain cases with fresh copy

[jamesdeanexpensify]

Problem

New users often write in confused about how to use New Expensify. Key points of confusion still seem to be “How do I submit expenses?” or “How do I use this?” or are just unclear why they are looking at a chat platform. They then become frustrated or just leave us all together.

Solution

Update the beginningOfChatHistory copy in all rooms to be clearer and more concise, as well as remove any noise around features that don’t lead to conversion.

P/S is also here in Slack.

Copy updates

Type	Current example	Proposed copy
Concierge	This is the beginning of your chat with Concierge.	This chat is with Concierge. Ask questions and get 24/7 realtime support.
DM (aka beginningOfChatHistory)	This is the beginning of your chat with Daniel Vidal. You can also use the + button to split an expense, submit an expense, pay expenses, or assign a task!	This chat is with [recipient]. Use the + button to split, submit, or pay an expense.
Group chat (can’t find this in the code)	This is the beginning of your chat with Anu, Daniel and James.	This chat is with [recipients that don't include you]. Use the + button to split an expense.
Workspace chat (aka beginningOfChatHistoryPolicyExpenseChat)	Collaboration between James Dean (Marketing/PR) and NewDot Test - Expensify US starts here! 🎉 This is the place to chat, submit expenses and settle up. You can also use the + button to split an expense, submit an expense, track an expense, or assign a task!	This is where [submitter] will submit expenses to [workspaceName]. Just use the + button.
#announce room (aka beginningOfChatHistoryAnnounceRoom)	Collaboration between all Expensify's Workspace 6 members starts here! 🎉 Use #announce to chat about anything Expensify's Workspace 6 related.	This chat is with everyone in [workspaceName]. Use it for the most important announcements.
#admins room (aka beginningOfChatHistoryAdminRoom)	Collaboration among james@expensify.com Small Business Expo admins starts here! 🎉 Use #admins to chat about topics such as workspace configurations and more.	This chat is with [workspaceName] admins. Use it to chat about workspace setup and more.
Domain room (aka beginningOfChatHistoryDomainRoom)	Collaboration with everyone at #expensify.com starts here! 🎉 Use #expensify.com to chat with colleagues, share tips, and ask questions.	This chat is with all Expensify members on the [domain] domain. Use it to chat with colleagues, share tips, and ask questions.
User-created room (aka beginningOfChatHistoryUserRoom)	Collaboration starts here! 🎉 Use this space to chat about anything #bravo-clubhouse related.	This chat room is for anything #[roomName] related. It was created by [displayName].
Invoice room (aka beginningOfChatHistoryInvoiceRoom)	Collaboration starts here! 🎉 Use this room to view, discuss, and pay invoices.	This chat is for invoices between [invoice sender/bill payer workspaceName] and [invoice/paid bill receiver workspaceName OR displayName]. Use the + button to send an invoice.

Important

We need to make sure that the beginningOfChatHistory never gets replaced by a custom roomDescription if someone sets one. The roomDescription will instead be included/updated elsewhere (in the subheader).

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831355584440701165
• Upwork Job ID: 1831355584440701165
• Last Price Increase: 2024-09-04
• Automatic offers:
• ikevin127 | Reviewer | 103838820
• nkdengineer | Contributor | 104176525

Issue Owner

Current Issue Owner: @VictoriaExpensify

[danielrvidal]

@jamesdeanexpensify, what do you think is still needed for this? Just to get an engineer to pick it up or do we need to keep fleshing out the proposal?

[jamesdeanexpensify]

Just left you a comment in the doc, and then it would be great to get an engineer to pick it up and ask any remaining questions. I just thought you wanted to wait to house it under the F1 deadline.

[jamesdeanexpensify]

@danielrvidal I think this is ready for an engineer whenever!

[danielrvidal]

@jamesdeanexpensify now that this is in a whatsnext room/project, I imagine you should be able to recruit an engineer. I'm going to drop an update in the room but I think you should be good to go.

[jamesdeanexpensify]

Posted here as a next step!

[jamesdeanexpensify]

Renewed the convo here.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831355584440701165

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[mariapeever]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update beginningOfChatHistory for certain cases with fresh copy #47427

What is the root cause of that problem?

Current copy is not clear enough for new Expensify users.

What changes do you think we should make in order to solve the problem?

Update the current copy to match the proposed copy.
Updates to the language file (en.ts):

• Concierge - add a beginningOfChatHistoryConcierge property specific for Concierge just before beginningOfChatHistory.

• DM (aka beginningOfChatHistory) - update the beginningOfChatHistory property and add a participantNames param.

• Group chat - Count the participants' names for a group chat and re-use the beginningOfChatHistory property
  

  App/src/languages/en.ts

  Line 603 in c885f96

  beginningOfChatHistory: 'This is the beginning of your chat with ',

  
  

  App/src/libs/SidebarUtils.ts

  Lines 530 to 555 in dc1407a

  	welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistory');
  	const participantAccountIDs = ReportUtils.getParticipantsAccountIDsForDisplay(report);
  	const isMultipleParticipant = participantAccountIDs.length > 1;
  	const displayNamesWithTooltips = ReportUtils.getDisplayNamesWithTooltips(
  	OptionsListUtils.getPersonalDetailsForAccountIDs(participantAccountIDs, allPersonalDetails),
  	isMultipleParticipant,
  	);
  	const displayNamesWithTooltipsText = displayNamesWithTooltips
  	.map(({displayName, pronouns}, index) => {
  	const formattedText = !pronouns ? displayName : `${displayName} (${pronouns})`;
  	if (index === displayNamesWithTooltips.length - 1) {
  	return `${formattedText}.`;
  	}
  	if (index === displayNamesWithTooltips.length - 2) {
  	return `${formattedText} ${Localize.translateLocal('common.and')}`;
  	}
  	if (index < displayNamesWithTooltips.length - 2) {
  	return `${formattedText},`;
  	}
  	return '';
  	})
  	.join(' ');
  	welcomeMessage.messageText = `${welcomeMessage.phrase1} ${displayNamesWithTooltipsText}`;

• Workspace chat (aka beginningOfChatHistoryPolicyExpenseChat) - Combine the beginningOfChatHistoryPolicyExpenseChat parts 1-3 into 1 and add parameters for participantName and policyName.
  - beginningOfChatHistoryPolicyExpenseChatPartOne
  - beginningOfChatHistoryPolicyExpenseChatPartTwo
  - beginningOfChatHistoryPolicyExpenseChatPartThree
  

  App/src/languages/en.ts

  Lines 604 to 606 in c885f96

  	beginningOfChatHistoryPolicyExpenseChatPartOne: 'Collaboration between ',
  	beginningOfChatHistoryPolicyExpenseChatPartTwo: ' and ',
  	beginningOfChatHistoryPolicyExpenseChatPartThree: ' starts here! 🎉 This is the place to chat, submit expenses and settle up.',

  
  

  App/src/libs/SidebarUtils.ts

  Lines 508 to 513 in dc1407a

  	welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartOne');
  	welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartTwo');
  	welcomeMessage.phrase3 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryPolicyExpenseChatPartThree');
  	welcomeMessage.messageText = `${welcomeMessage.phrase1} ${ReportUtils.getDisplayNameForParticipant(report?.ownerAccountID)} ${welcomeMessage.phrase2} ${ReportUtils.getPolicyName(
  	report,
  	)} ${welcomeMessage.phrase3}`;

• #announce room (aka beginningOfChatHistoryAnnounceRoom) - Combine the beginningOfChatHistoryAnnounceRoom parts 1-2 into 1 with a parameters for workspaceName and reportName.
  - beginningOfChatHistoryAnnounceRoomPartOne
  - beginningOfChatHistoryAnnounceRoomPartTwo
  

  App/src/languages/en.ts

  Lines 597 to 599 in c885f96

  	beginningOfChatHistoryAnnounceRoomPartOne: ({workspaceName}: BeginningOfChatHistoryAnnounceRoomPartOneParams) =>
  	`Collaboration between all ${workspaceName} members starts here! 🎉\nUse `,
  	beginningOfChatHistoryAnnounceRoomPartTwo: ({workspaceName}: BeginningOfChatHistoryAnnounceRoomPartTwo) => ` to chat about anything ${workspaceName} related.`,

  
  

  App/src/libs/SidebarUtils.ts

  Lines 582 to 584 in dc1407a

  	} else if (ReportUtils.isAnnounceRoom(report)) {
  	welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartOne', {workspaceName});
  	welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAnnounceRoomPartTwo', {workspaceName});

• #admins room (aka beginningOfChatHistoryAdminRoom) - Combine the beginningOfChatHistoryAdminRoom parts 1-2 into 1 with a parameters for workspaceName and reportName.
  - beginningOfChatHistoryAdminRoomPartOne
  - beginningOfChatHistoryAdminRoomPartTwo
  

  App/src/languages/en.ts

  Lines 595 to 596 in c885f96

  	beginningOfChatHistoryAdminRoomPartOne: ({workspaceName}: BeginningOfChatHistoryAdminRoomPartOneParams) => `Collaboration among ${workspaceName} admins starts here! 🎉\nUse `,
  	beginningOfChatHistoryAdminRoomPartTwo: ' to chat about topics such as workspace configurations and more.',

  
  

  App/src/libs/SidebarUtils.ts

  Lines 580 to 581 in dc1407a

  	welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAdminRoomPartOne', {workspaceName});
  	welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryAdminRoomPartTwo');

• Domain room (aka beginningOfChatHistoryDomainRoom) - Combine the beginningOfChatHistoryDomainRoom parts 1-2 into 1 with a parameter for domainRoom.
  - beginningOfChatHistoryDomainRoomPartOne
  - beginningOfChatHistoryDomainRoomPartTwo
  

  App/src/languages/en.ts

  Lines 593 to 594 in c885f96

  	beginningOfChatHistoryDomainRoomPartOne: ({domainRoom}: BeginningOfChatHistoryDomainRoomPartOneParams) => `Collaboration with everyone at ${domainRoom} starts here! 🎉\nUse `,
  	beginningOfChatHistoryDomainRoomPartTwo: ' to chat with colleagues, share tips, and ask questions.',

  
  

  App/src/libs/SidebarUtils.ts

  Lines 576 to 578 in dc1407a

  	} else if (ReportUtils.isDomainRoom(report)) {
  	welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryDomainRoomPartOne', {domainRoom: report?.reportName ?? ''});
  	welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryDomainRoomPartTwo');

• User-created room (aka beginningOfChatHistoryUserRoom) - Combine the beginningOfChatHistoryUserRoom parts 1-2 into 1 with a parameter for reportName.
  - beginningOfChatHistoryDomainRoomPartOne
  - beginningOfChatHistoryDomainRoomPartTwo
  

  App/src/languages/en.ts

  Lines 593 to 594 in c885f96

  	beginningOfChatHistoryDomainRoomPartOne: ({domainRoom}: BeginningOfChatHistoryDomainRoomPartOneParams) => `Collaboration with everyone at ${domainRoom} starts here! 🎉\nUse `,
  	beginningOfChatHistoryDomainRoomPartTwo: ' to chat with colleagues, share tips, and ask questions.',

  
  

  App/src/libs/SidebarUtils.ts

  Lines 588 to 591 in dc1407a

  	} else {
  	// Message for user created rooms or other room types.
  	welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryUserRoomPartOne');
  	welcomeMessage.phrase2 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryUserRoomPartTwo');

• Invoice room (aka beginningOfChatHistoryInvoiceRoom) - Edit the beginningOfChatHistoryInvoiceRoom property and add params for invoice sender/bill payer workspaceName and invoice/paid bill receiver workspaceName OR displayName
  - beginningOfChatHistoryInvoiceRoom
  

  App/src/languages/en.ts

  Line 602 in c885f96

  beginningOfChatHistoryInvoiceRoom: 'Collaboration starts here! 🎉 Use this room to view, discuss, and pay invoices.',

  
  

  App/src/libs/SidebarUtils.ts

  Lines 585 to 587 in dc1407a

  	} else if (ReportUtils.isInvoiceRoom(report)) {
  	welcomeMessage.showReportName = false;
  	welcomeMessage.phrase1 = Localize.translateLocal('reportActionsView.beginningOfChatHistoryInvoiceRoom');

App/src/libs/SidebarUtils.ts

Line 593 in dc1407a

welcomeMessage.messageText = `${welcomeMessage.phrase1} ${welcomeMessage.showReportName ? ReportUtils.getReportName(report) : ''} ${welcomeMessage.phrase2 ?? ''}`;

What alternative solutions did you explore? (Optional)

N/A

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update beginningOfChatHistory for certain cases with fresh copy

What is the root cause of that problem?

This is a new feature

What changes do you think we should make in order to solve the problem?

• concierge chat, we can create a new translation for this one as per the description above or we can still use beginningOfChatHistory and create a new translation text for the additional text Ask questions and get 24/7 realtime support. and add it here if the report is concierge.

App/src/components/ReportWelcomeText.tsx

Line 178 in cb2bdf2

{(moneyRequestOptions.includes(CONST.IOU.TYPE.PAY) || moneyRequestOptions.includes(CONST.IOU.TYPE.SUBMIT) || moneyRequestOptions.includes(CONST.IOU.TYPE.TRACK)) && (

• DM chat and group chat, we can update beginningOfChatHistory translation as the description to This chat is with and then update usePlusButton to \nUse the + button to ${additionalText}, or assign a task!

App/src/languages/en.ts

Line 603 in cb2bdf2

beginningOfChatHistory: 'This is the beginning of your chat with ',

App/src/languages/en.ts

Line 613 in cb2bdf2

usePlusButton: ({additionalText}: UsePlusButtonParams) => `\nYou can also use the + button to ${additionalText}, or assign a task!`,

OPTIONAL: We can remove or assign a task text.

• Policy expense chat: update three phrase beginningOfChatHistoryPolicyExpenseChat translations as the description

beginningOfChatHistoryPolicyExpenseChatPartOne: 'This is where ',
beginningOfChatHistoryPolicyExpenseChatPartTwo: ' will submit expenses to the ',
beginningOfChatHistoryPolicyExpenseChatPartThree: ' workspace. Just use the + button.',

App/src/languages/en.ts

Lines 604 to 607 in cb2bdf2

	beginningOfChatHistoryPolicyExpenseChatPartOne: 'Collaboration between ',
	beginningOfChatHistoryPolicyExpenseChatPartTwo: ' and ',
	beginningOfChatHistoryPolicyExpenseChatPartThree: ' starts here! 🎉 This is the place to chat, submit expenses and settle up.',
	beginningOfChatHistorySelfDM: 'This is your personal space. Use it for notes, tasks, drafts, and reminders.',

• Admin room and announce room: Update two phrase of the beginningOfChatHistoryAnnounceRoom translation and beginningOfChatHistoryAdminRoom as the description

App/src/languages/en.ts

Lines 595 to 599 in cb2bdf2

	beginningOfChatHistoryAdminRoomPartOne: ({workspaceName}: BeginningOfChatHistoryAdminRoomPartOneParams) => `Collaboration among ${workspaceName} admins starts here! 🎉\nUse `,
	beginningOfChatHistoryAdminRoomPartTwo: ' to chat about topics such as workspace configurations and more.',
	beginningOfChatHistoryAnnounceRoomPartOne: ({workspaceName}: BeginningOfChatHistoryAnnounceRoomPartOneParams) =>
	`Collaboration between all ${workspaceName} members starts here! 🎉\nUse `,
	beginningOfChatHistoryAnnounceRoomPartTwo: ({workspaceName}: BeginningOfChatHistoryAnnounceRoomPartTwo) => ` to chat about anything ${workspaceName} related.`,

• Domain room: Update the beginningOfChatHistoryDomainRoom translation as the description with domain param is the report.reportName

App/src/languages/en.ts

Lines 593 to 594 in cb2bdf2

	beginningOfChatHistoryDomainRoomPartOne: ({domainRoom}: BeginningOfChatHistoryDomainRoomPartOneParams) => `Collaboration with everyone at ${domainRoom} starts here! 🎉\nUse `,
	beginningOfChatHistoryDomainRoomPartTwo: ' to chat with colleagues, share tips, and ask questions.',

• User-created room: Update two phrases the beginningOfChatHistoryUserRoom translation as the description

App/src/languages/en.ts

Lines 600 to 601 in cb2bdf2

	beginningOfChatHistoryUserRoomPartOne: 'Collaboration starts here! 🎉\nUse this space to chat about anything ',
	beginningOfChatHistoryUserRoomPartTwo: ' related.',

• Invoice room: Update the beginningOfChatHistoryInvoiceRoom translation as the description with two extra params invoice sender/bill payer workspaceName is the display name of the user that is invited to the invoice room and invoice/paid bill receiver workspaceName OR displayName is the display name user that creates the send invoice or the workspace name of the workspace that we create the send invoice.

For all translations, we should update the all places that we use this translation if the param is changed.

We need to make sure that the beginningOfChatHistory never gets replaced by a custom roomDescription if someone sets one. The roomDescription will instead be included/updated elsewhere (in the subheader).

We already have handled this in getRoomWelcomeMessage function

What alternative solutions did you explore? (Optional)

[AsfandSoomro]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update beginningOfChatHistory for certain cases with fresh copy

What is the root cause of that problem?

Chat header message is not clear to new users

What changes do you think we should make in order to solve the problem?

First of all we need to re-code all beginningOfChatHistory(all) data in reportActionsView object in a clear and consistent way. They all need to accept arguments if they need dynamic message so we can pass (e.g workspace name, recipient name, or multiple recipients names etc) rather than the current PartOne PartTwo PartThree different keys. This will be more flexible and easier to change the message in future.
Something like this: welcomeToRoom: ({roomName}: WelcomeToRoomParams) => `Welcome to ${roomName}!`,

Files that will be affected

• src/languages/en.ts
• src/languages/es.ts
• src/libs/SidebarUtils.ts

My approach to solve the problem

• For Concierge create new key beginningOfChatHistoryConcierge in reportActionsView it won't accept any parameters, just static message. And in getWelcomeMessage() function figure out if the recipient name is Concierge since we don't have a Report util function like this ReportUtils.isSelfDM(report) to check if user is in chatroom with Concierge.
• For DM same key remains, just dynamic.
• For Group Chat new dynamic key beginningOfChatHistoryGroupChat. And in getWelcomeMessage() figure out the way to remove the name of the client user before the recipients names message constructor loop.

Similar approach in all others. This way I think messages will be more flexible and easy to change in future as well.

P.S I have only explored Expensify code now and have not contributed to Open Source before. Still reading the contribution.md file

What alternative solutions did you explore? (Optional)

[ikevin127]

• [@ikevin127] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

I don't think we need regression test here since this was copy update, if I'm wrong please let me know.

@jamesdeanexpensify Not sure who's the BZ here for payment but we had 1 regression which was handled in a follow-up PR (#50384), therefore the payment should have a -50% penalty here.

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @VictoriaExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[ikevin127]

cc @VictoriaExpensify Payment details in #47427 (comment).

[ikevin127]

Bumped on Slack thread for payment as well, here's a short summary:

Summary

• me (reviewer) and merged PR author should get $125 (-50% penalty for 1 regression, see above)
• I vote for 25% for Maria Peever, meaning $62.5 for their work on the first PR which we did not merge (hopefully still around to get paid)

[VictoriaExpensify]

As discussed in Slack, this is how the payment breakdown will work out:

• @ikevin127 and @nkdengineer will get $125 (-50% penalty for 1 regression, see issue)
• @mariapeever will get $62.5 for their work on the first PR which we did not merge

Everyone is paid via Upwork, fixing this up now

[VictoriaExpensify]

Payment summary:
Contributor: @nkdengineer paid $125 via Upwork
Contributor+: @ikevin127 paid $125 via Upwork

@mariapeever I have sent you an offer for the work you did on the initial PR. Once accepted I will approve the payment

Thanks all for getting this fixed up

[ikevin127]

Not overdue, most of the payments were completed - awaiting completion of last payment to contributor once they accept the offer.

[melvin-bot]

@jamesdeanexpensify, @stitesExpensify, @roryabraham, @VictoriaExpensify, @ikevin127, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...

[ikevin127]

Not overdue, most of the payments were completed - awaiting completion of last payment to contributor once they accept the offer.

[melvin-bot]

@jamesdeanexpensify, @stitesExpensify, @roryabraham, @VictoriaExpensify, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!

[jamesdeanexpensify]

What's next here? Thanks!

[melvin-bot]

@jamesdeanexpensify, @stitesExpensify, @roryabraham, @VictoriaExpensify, @nkdengineer 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[VictoriaExpensify]

Hmm still waiting for @mariapeever to accept my offer. I've bumped her in the Open Source channel and sent her a message in upwork. We'll give her a few more days before we close this out I guess.

[VictoriaExpensify]

Still nothing from Maria. I'll close this out tomorrow if I haven't heard anything

[VictoriaExpensify]

Maria still hasn't accepted the offer. Not much more we can do here so I'm closing this out.