[HOLD for payment 2024-11-14] [$250] Update all enable/disable workspace editor menu items to use more appropriate icons.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.52-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dannymcclain
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729696426720769

Action Performed:

1. Go to staging.new.expensify.com
2. Settings > Workspace
3. Enable and disable distance rates, categories, tags, taxes, etc in the workspace editor

Expected Result:

Update all of these options to use our checkmark icon for enabling and our close icon for disabling

Actual Result:

For enabling and disabling distance rates, categories, tags, taxes, etc in the workspace editor, we use the document slash and document icons

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021850952147214906851
• Upwork Job ID: 1850952147214906851
• Last Price Increase: 2024-10-28
• Automatic offers:
• klajdipaja | Contributor | 104664755

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[zanyrenney]

Nice, good thinking here!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021850952147214906851

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[klajdipaja]

I am confused as @jayeshmangwani is assigned as c+ but his proposal is correct. Is this up for grabs still? I could work as the contributor here.

[jayeshmangwani]

Hey @klajdipaja ! I submitted a proposal before being assigned here as C+. Issue is still open for proposals, so feel free to add one if you have any ideas. I'll Hide my comment

[klajdipaja]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We need to update all enabled/disabled workspace editor menu items to use more appropriate icons.

What is the root cause of that problem?

It's just a UI Enhancement

What changes do you think we should make in order to solve the problem?

This is a straightforward change, and if we decide to address it externally, here’s my proposal:

On the pages listed below, we're currently using Expensicons.Document and Expensicons.DocumentSlash. These should be replaced with Expensicons.Checkmark and Expensicons.Close respectively.

WorkspaceCategoriesPage
PolicyDistanceRatesPage
ReportFieldsListValuesPage
WorkspaceTagsPage
WorkspaceViewTagsPage
WorkspaceTaxesPage

What alternative solutions did you explore? (Optional)

[jayeshmangwani]

It's a straightforward icons update. We can assign this issue to @klajdipaja with the selected proposal #51361 (comment).

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[zanyrenney]

Assigning @klajdipaja

[melvin-bot]

📣 @klajdipaja 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Replace checkmark icon for enabling and close icon for disabling #51779

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

• @klajdipaja requires payment automatic offer (Contributor)
• @jayeshmangwani requires payment through NewDot Manual Requests

[melvin-bot]

@jayeshmangwani @zanyrenney The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[jayeshmangwani]

@zanyrenney, this issue is an improvement, so IMO the checklist isn't needed. We've just updated the icons here.

[zanyrenney]

the checklist is needed always for hygiene @jayeshmangwani please complete it and then let me know so I can issue payment! Thank you!

[jayeshmangwani]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: Initially, the icons were different, but we later decided to use new icons and replace the old ones.

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: There's no offending PR here—the old icons were added intentionally, and we've now decided to update them.

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

This is a one-time icon change, so I don’t think it requires a dedicated regression test, as the UI doesn’t change frequently. However, if we do want one, here’s what I propose:

Regression Test Proposal

1. Open the app and navigate to Settings -> Workspace.
2. In the workspace editor, enable and disable options such as Distance Rates, Categories, Tags, Taxes, etc.
3. Go to each page for Distance Rates, Categories, Tags, and Taxes within the workspace editor.
4. Select one or more items in each category.
5. Verify that:

• A checkmark icon is displayed for enabling items.
• A close icon is displayed for disabling items.

Do we agree 👍 or 👎

[jayeshmangwani]

@zanyrenney , I’ve completed the checklist. Thanks!

[zanyrenney]

Thanks @jayeshmangwani

[zanyrenney]

Payment summary

@klajdipaja requires payment automatic offer (Contributor) - paid $250 via Upwork
@jayeshmangwani requires payment through NewDot Manual Requests -due $250 via ND requests

[garrettmknight]

$250 approved for @jayeshmangwani