[PAID] [$100] Expensify Card - "issued" starts with a lowercase i on shipping address message

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
Found when validation PR #50660
Email or phone of affected tester (no customers): nathanmulugetatesting+1941@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-conditions: Bank account is connected and Expensify card is enabled on a collect workspace, a member is added.

1. Issue a physical card to a member
2. Sign in with the member's account
3. Go to the workspace chat

Expected Result:

The shipping address message starts the word "issued" with an uppercase "I"

Actual Result:

The shipping address message starts the word issued with a lowercase "i"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021851735794863120022
• Upwork Job ID: 1851735794863120022
• Last Price Increase: 2024-10-30
• Automatic offers:
• rojiphil | Reviewer | 104720935
• nyomanjyotisa | Contributor | 104720937

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card - "issued" starts with a lowercase i on shipping address message

What is the root cause of that problem?

The copy on the translation file is start with lowercase

App/src/languages/en.ts

Lines 3201 to 3203 in 45cabbf

	issuedCard: ({assignee}: AssigneeParams) => `issued ${assignee} an Expensify Card! The card will arrive in 2-3 business days.`,
	issuedCardNoShippingDetails: ({assignee}: AssigneeParams) => `issued ${assignee} an Expensify Card! The card will be shipped once shipping details are added.`,
	issuedCardVirtual: ({assignee, link}: IssueVirtualCardParams) => `issued ${assignee} a virtual ${link}! The card can be used right away.`,

What changes do you think we should make in order to solve the problem?

Change it to start with uppercase Issued ...

Change both on en and es translation file

What alternative solutions did you explore? (Optional)

[strepanier03]

I think this might be more suited for #quality, trying to figure out a way to test this now.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021851735794863120022

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[melvin-bot]

Upwork job price has been updated to $100

[D-01576]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card - "issued" starts with a lowercase i on shipping address message

What is the root cause of that problem?

The lowercase "issued" originates from the translation file's text, which was mistakenly set with a lowercase letter at the start.

Relevant File and Lines

The translation entries are in App/src/languages/en.ts

issuedCard: ({assignee}: AssigneeParams) => `issued ${assignee} an Expensify Card! The card will arrive in 2-3 business days.`,
issuedCardNoShippingDetails: ({assignee}: AssigneeParams) => `issued ${assignee} an Expensify Card! The card will be shipped once shipping details are added.`,
issuedCardVirtual: ({assignee, link}: IssueVirtualCardParams) => `issued ${assignee} a virtual ${link}! The card can be used right away.

What changes do you think we should make in order to solve the problem?

To correct this, change "issued" to "Issued" in each of the relevant entries. This update should be made in both the English (en.ts) and TypeScript (ts) translation files.

What alternative solutions did you explore? (Optional)

Alternatively, we could apply the existing startCase function to capitalize the first letter automatically. This could be done by using ${startCase("issued")} or applying startCase directly to the field where input is generated. This approach would allow for consistent capitalization without requiring manual adjustments for each translation entry.

issuedCard: ({assignee}: AssigneeParams) => `${startCase("issued")} ${assignee} an Expensify Card! The card will arrive in 2-3 business days.`,
issuedCardNoShippingDetails: ({assignee}: AssigneeParams) => `${startCase("issued")} ${assignee} an Expensify Card! The card will be shipped once shipping details are added.`,
issuedCardVirtual: ({assignee, link}: IssueVirtualCardParams) => `${startCase("issued")} ${assignee} a virtual ${link}! The card can be used right away.

[rojiphil]

@nyomanjyotisa proposal LGTM as that was the first one to identify the root cause and the texts in translation file that needs to be fixed. Initially, the proposal did miss mentioning the change in es translation file but that could have been easily found out during PR.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[robertjchen]

👍 to @nyomanjyotisa 's solution.

startCase is definitely cool, but somewhat overkill for this situation 😅

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nyomanjyotisa 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[D-01576]

startCase is definitely cool, but somewhat overkill for this situation 😅

@robertjchen, Thanks for reviewing my proposal; I will definitely try to be part of the Expensify as a contributor.

[rojiphil]

Coming from here

Sorry, even if it doesn't match the English version exactly, for the Spanish copy I would remove ¡ and !.

But just to be sure, can you confirm how all the copies (English/Spanish) would look and I can do one final review? Thanks!

@jamesdeanexpensify Here are the screenshots based on the latest main. What do you think?

[jamesdeanexpensify]

For the Spanish copy, I would remove the exclamation marks and just end that first sentence with a period instead.

[rojiphil]

For the Spanish copy, I would remove the exclamation marks and just end that first sentence with a period instead.

Sure then. Let’s do this here cc @nyomanjyotisa @robertjchen

[nyomanjyotisa]

PR is ready

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Expensify Card - Remove the exclamation marks on Spanish translation #52085

If no regressions arise, payment will be issued on 2024-11-18. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment automatic offer (Reviewer)
• @nyomanjyotisa PAID automatic offer (Contributor)

[melvin-bot]

@rojiphil @strepanier03 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[strepanier03]

@rojiphil - I will check back later today for the checklist and pay out the contract once I have that and the reg test (if needed) submitted.

@nyomanjyotisa - I've paid and closed your contract in Upwork, thanks!

[rojiphil]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required. The existing checklist is good enough to capture such issues.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

Set the language to Spanish

Steps:

1. Issue a physical card to a member
2. Sign in with the member's account
3. Go to the workspace chat
4. Verify that the exclamation marks in the first sentence have been replaced with a period

Do we agree 👍 or 👎

[rojiphil]

I will check back later today for the checklist and pay out the contract once I have that and the reg test (if needed) submitted.

@strepanier03 BZ checklist is completed. Also, I have accepted the offer. Thanks.

[strepanier03]

Great, thanks @rojiphil - finishing up now.

[strepanier03]

Okay, made the reg test, paid the contract and closed it. Closing this out. Thanks all!