Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-07] [$250] [Search v2.5] Add unit tests for the autocomplete parser #51428

Closed
luacmartins opened this issue Oct 24, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Oct 24, 2024

Implement automated tests for the search autocomplete parser, as described in this section of the doc

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021849532291733100709
  • Upwork Job ID: 1849532291733100709
  • Last Price Increase: 2024-10-24
Issue OwnerCurrent Issue Owner: @VictoriaExpensify
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Oct 24, 2024
@luacmartins luacmartins self-assigned this Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Triggered auto assignment to @VictoriaExpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 24, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Oct 24, 2024
@289Adam289
Copy link
Contributor

Hi! I'm Adam from SWM and I'd like to work on this issue.

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Oct 24, 2024
@melvin-bot melvin-bot bot changed the title [Search v2.5] Add unit tests for the autocomplete parser [$250] [Search v2.5] Add unit tests for the autocomplete parser Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021849532291733100709

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 24, 2024
Copy link

melvin-bot bot commented Oct 24, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 24, 2024
@nucty
Copy link

nucty commented Oct 24, 2024

Hello, I’m submitting this proposal from Upwork to assist with adding unit tests for the autocomplete parser, as described in the linked section of the Google Doc. After reviewing the current implementation and documentation, I will create comprehensive unit tests to validate the autocomplete parser's functionality. This will include testing edge cases, ensuring correct parsing logic, and verifying performance across platforms. I will use existing testing frameworks within the Expensify repository to ensure seamless integration and maintainability of the new tests. I can finish today.

Copy link

melvin-bot bot commented Oct 24, 2024

📣 @nucty! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@nucty
Copy link

nucty commented Oct 24, 2024

Contributor details
Your Expensify account email: giancarloona1@gmail.com
Upwork Profile Link: <Contributor details>

Copy link

melvin-bot bot commented Oct 24, 2024

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@nucty
Copy link

nucty commented Oct 24, 2024

Contributor details
Your Expensify account email: giancarloona1@gmail.com
Upwork Profile Link: <(https://www.upwork.com/freelancers/~01b95e8c9ed644a972?mp_source=share)>

Copy link

melvin-bot bot commented Oct 24, 2024

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@nucty
Copy link

nucty commented Oct 24, 2024

Contributor details
Your Expensify account email: giancarloona1@gmail.com
Upwork Profile Link: (https://www.upwork.com/freelancers/~01b95e8c9ed644a972?mp_source=share)

Copy link

melvin-bot bot commented Oct 24, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels Oct 28, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 28, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@luacmartins luacmartins moved this from Release 3: Fall 2024 (Nov) to Done in [#whatsnext] #expense Oct 29, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 31, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Search v2.5] Add unit tests for the autocomplete parser [HOLD for payment 2024-11-07] [$250] [Search v2.5] Add unit tests for the autocomplete parser Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 31, 2024
Copy link

melvin-bot bot commented Oct 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 31, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@289Adam289] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@luacmartins
Copy link
Contributor Author

No payment is required here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Weekly KSv2
Projects
Archived in project
Development

No branches or pull requests

5 participants