-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-11-11] Web - Search - Console error shows up when entering comma in the search router #51661
Comments
Triggered auto assignment to @dangrous ( |
💬 A slack conversation has been started in #expensify-open-source |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Production: bandicam.2024-10-29.15-33-47-678.mp4 |
We think that this bug might be related to #wave-control |
@dangrous @lanitochka17 I can verify that this bug is not a thing on newest main, specifically after this PR: #51555 which is merged. It also introduces unit tests, so as part of this issue we can add a test case with just the I can confirm that this error appears right now both in staging and in prod, but on newest |
my local devScreen.Recording.2024-10-29.at.15.23.53.mov |
hmm @Kicu I still see the error on And it's definitely from #50883 (d3f99c1) The error is:
|
I also see it on main and agree it comes from #50883. That being said, I don't think this is a blocker since it only breaks the syntax in a few edge cases |
yeah i think that's fine - I'll switch to daily. Do you want to take over? I can also continue to shepherd, whichever you prefer. |
I can take over |
I think I was imprecise in my previous message 😅 What I believe is not a bug right now is just typing the However I can see that the error @dangrous described here: #51661 (comment) is after typing tl;dr: @289Adam289 if you find some time you can take a look, perhaps we should allow a single comma in the main parser as well 🤔 |
Sure we can allow commas in the main parser. I will work on that. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-11. 🎊 For reference, here are some details about the assignees on this issue:
|
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
This is done and no payment is needed here. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.55-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
No console error when entering comma in the search router
Actual Result:
Console error shows up when entering comma in the search router
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6649388_1730208661473.20241029_212727.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: