Latest android release builds are instantly crashing due to JS errors

[hannojg]

Slack thread: https://margelo.slack.com/archives/C05LX9D6E07/p1729847485394869

After releasing 9.0.54-0 we are experiencing constant crashes of the android app when build in release mode:

E  FATAL EXCEPTION: mqt_native_modules (Ask Gemini)
                                                                                                    Process: com.expensify.chat.e2edelta, PID: 27253
                                                                                                    com.facebook.react.common.JavascriptException: Error: Exception in HostFunction: Could not enqueue microtask because they are disabled in this runtime, js engine: hermes, stack:
                                                                                                    setImmediate@1:527723
                                                                                                    setDriver@1:1660584
                                                                                                    LocalForage@1:1659118

Steps to reproduce:

• Build the app for android in release mode and run
• Try to run the latest staging app from google play

[hannojg]

@kirillzyusko can you comment here, so you can be assigned for this?

[kirillzyusko]

Yes, sure
Commenting to be assigned to this task 👀

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @MonilBhavsar is eligible for the Engineering assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

Sorry for the pings, i can handle it with @kirillzyusko

[kirillzyusko]

Me and @WoLewicki figured out that this crash is caused by #48160

At this point of time I don't think I can help here a lot so it's better to assign this issue to @WoLewicki

@WoLewicki told me, that he will try to figure out, what exactly triggers a crash - if he'll be able to fix it he'll prepare a PR. If it takes a lot of time then he will simply disable bridgeless mode temporarily.

[hannojg]

Did you figure what the root cause is, like why did turning it on caused this crash? Or is that something you're still working on understanding @WoLewicki ? (just very curious about this super weird bug)

[WoLewicki]

Yeah, for now we managed to get to a point that:

• In bridgeless mode, setImmediate uses queueMicrotask under the hood: https://github.com/facebook/react-native/blob/143b9d172ca755e2457e8dfc6009eeef2475a4a1/packages/react-native/Libraries/Core/Timers/immediateShim.js#L44
• It triggers the exception here: https://github.com/facebook/hermes/blob/d964f6b125426f919ad30fb09ff09b9d5f041743/API/hermes/hermes.cpp#L1546 since it is not enabled in hermes.

It also happens on debug, but does not crash the app, that's why we didn't spot it since it's just a native crash. Now we are trying to understand why the flag for queueMicrotask is not enabled and if it should be at all.

[Beamanator]

Requesting CP to get this fixed up, since the revert PRs have been merged:

• [CP Staging] fix: revert bridgeless on Android #51489
• https://github.com/Expensify/Mobile-Expensify/pull/13253

[Beamanator]

CP completed - @hannojg are you online to give it a test?

[hannojg]

@kirillzyusko can you test please

[Beamanator]

@kirillzyusko confirmed here that the crash is not happening anymore!

[mountiny]

Resolved

[mountiny]

To close the loop, we are going to look into re-enabling the bridgeless mode on android in the original issue #48163

And also discussing here

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.