Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-05] [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" #51891

Closed
1 of 8 tasks
m-natarajan opened this issue Nov 1, 2024 · 24 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review

Comments

@m-natarajan
Copy link

m-natarajan commented Nov 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #quality

Action Performed:

Prerequisite:
Members and company cards added in workspace

  1. Go to staging.new.expensify.com
  2. Choose the workspace from settings
  3. Click company cards >Card Details

Expected Result:

When accounting integration is connected, there's default card in the card export row.

Actual Result:

When accounting integration is connected, there's no default card in the card export row.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image - 2024-10-31T153332 628
image - 2024-10-31T153331 634
image - 2024-10-31T153318 519

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @twisterdotcom
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@m-natarajan m-natarajan added Weekly KSv2 and removed Daily KSv2 labels Nov 1, 2024
@m-natarajan
Copy link
Author

BZ team member, Callstack will work on this issue, please wait for them to comment before moving the issue forward.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@m-natarajan m-natarajan added the AutoAssignerNewDotQuality Used to assign quality issues to engineers label Nov 1, 2024
Copy link

melvin-bot bot commented Nov 1, 2024

Current assignee @mountiny is eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

@mountiny mountiny changed the title When accounting integration is connected, there's no default in the card export row. It should be "Default card" [Workspace feed] When accounting integration is connected, there's no default in the card export row. It should be "Default card" Nov 1, 2024
@mountiny mountiny changed the title [Workspace feed] When accounting integration is connected, there's no default in the card export row. It should be "Default card" [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" Nov 4, 2024
@mountiny
Copy link
Contributor

mountiny commented Nov 4, 2024

added to the project

@narefyev91
Copy link
Contributor

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 7, 2024
@melvin-bot melvin-bot bot changed the title [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" [HOLD for payment 2024-11-21] [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" Nov 14, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 14, 2024
Copy link

melvin-bot bot commented Nov 14, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

This comment was marked as outdated.

@DylanDylann
Copy link
Contributor

The PR still be reviewing

@twisterdotcom twisterdotcom removed the Awaiting Payment Auto-added when associated PR is deployed to production label Nov 21, 2024
@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-11-21] [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" Nov 21, 2024
@twisterdotcom twisterdotcom removed the Needs Reproduction Reproducible steps needed label Nov 21, 2024
@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Nov 25, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

@twisterdotcom, @narefyev91, @mountiny, @DylanDylann Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Nov 28, 2024
@melvin-bot melvin-bot bot changed the title [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" [HOLD for payment 2024-12-05] [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" Nov 28, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 28, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 28, 2024

@DylanDylann @twisterdotcom @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

@DylanDylann can you please add a checklist?

@DylanDylann
Copy link
Contributor

DylanDylann commented Dec 1, 2024

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production
  • 2b. Reported on staging (deploy blocker)
  • 2c. Reported on both staging and production
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: No because this seems like a case wasn't considered in document

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion:

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

    Link to issue:

Regression Test Proposal

Test:

  1. Choose the workspace from settings
  2. Click company cards >Card Details
  3. Verify that default export account is presented in Export row - with name "Default card"
  4. Click on menu item - Verify that "Default card" is pre-selected -> choose other export account
  5. Verify that selected export account presented in menu item row

Do we agree 👍 or 👎

Copy link

melvin-bot bot commented Dec 5, 2024

Payment Summary

Upwork Job

BugZero Checklist (@twisterdotcom)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@twisterdotcom
Copy link
Contributor

twisterdotcom commented Dec 6, 2024

Payment Summary:

@DylanDylann
Copy link
Contributor

No need payment here, we will handle payment later

@twisterdotcom
Copy link
Contributor

Cool, withdrew the one sent above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review
Development

No branches or pull requests

7 participants