Workspace Feed - Fix export item issues #52180

narefyev91 · 2024-11-07T13:07:39Z

Explanation of Change

Fixing some issues related to Export account in Company Card:

User was not able to select any export account
Default account was not automatically applied to Menu Item
When Vendor Bill is selected - export row should not be shown at all.

For mocking qbo connection can be used:

useEffect(() => {

    Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${policyID}`, {
        connections: {
            quickbooksOnline: {
                config: {
                    companyName: 'test',
                    credentials: {
                        access_token:
                            '2LHOKnH9waofJaMRyrVBUP+4qJsh4u+6E3Ffu73YJFJ6FnzAfsydZVkVFwjQmyxknEXCOYNeqoRljafcUk2sgzeq6002fXY55AEKF36UjaQQskfo4wR192K0v/68BUEzCpghfahoRmupoNq0u1JM8h/NDNIcLEi9ZDBno+7a22wi2jshJtcGL/wGBMUalWFupOmkiJbLPFen+mHFqLI8kF4TydI2a7SC4M4BAkZ2N7cFvp9LC39cLvrL7pZ/0wdIe8d4AMrKdR8M8V+KD8r2X4zXoQhKxSPA+2wRFiXIwOKB2iZqgI19dQHD0QqwbW6a512nOb7Q1Y0/SrF6NtVAaBXwhF2o3VULwFH3cy4QTYxB25wXCU76bhYsvUaQ/xWUVjY2TEi3GXkdTrNN8Ys8MXH3A9kVX7I32whBMfygcjYLtxc4/aVr8gYg8w5XPRRJ5Q/OGy68mX1JlCyWi+1NNAUJVkeRXuOsnivYvvaRisCJ4bng4ZiK9hnSWJ6qyKMWnb/nPpjZfZe25nbXfEG/e3CgwJ3KU4RlWZM+ECSWGcM/KyAGfErbcDBXXQk/6BnMjTqQkP5HotH8BHsUzYsw8D1A8i3gpgU/CStK8b+2PFcoqgTxWmsPgL7O32AFNR6z1yd1Zsrk5cDVHDlTddw1ePxrvfJRuT7gNKlut9oIAjgyR5iagxk/By2AGp0o2S53becAoPRGtuYYxk5WmpfB2q0N0QHI9VtRDJ5p1wn4KPO4twnnkU5YyD/u2UuBCWw9UB1rDWZVpGRUilyF2/0vy7PJHoUCXodz0DIulT+cDSHqf9hmc1pm7LI3Qt17X4uO1YCIQA7qQk1G5aY32HwNVq2VnyZJT64nEJ3JMydI4k74jrGy9Zp+52lAF39AenCaNjbVJg5svd0KEeOdwqr1j9SNkrHZkMmhuAUSI/WfyAhrtmjmRVGBTJ6b9l8fjdzwLwubXdFInG8M7h8Pc0Db7VTvd8Qv8MFRjhomzHbTkVMApKr1EH9WGzf932FlDse9HwKC4c6mA2Uj0BCaxsbnKnqd/I6Ug==;vJoXwrJgPzNOdv28yQHtPA==;eKPhE8t3aDV62W1np/MZoKIYA1bRawdFuttb5yxT44HQWjYgEc5x/Glx+Ye6YZP06Aj3N0A7eMw6rj98Kjpaow==',
                        companyID: '934145206296',
                        companyName: 'test',
                        expires: 1730725016,
                        realmId: '934145340296',
                        refresh_token:
                            'KwizVqdImwI5kHeImQ2NrXO7rteCSzvtQakR3uhp7Y04X06z3F4Hvt42jw==;fK/XjysVFPC4lYgRXbzi/RpxI1z3aWWpaLSAnT5v1kRtg4ilXX9fjQvA6Wc3LhKqZXnADugm2DbveEmZWAItlg==',
                        scope: 'Accounting',
                        token_type: 'bearer',
                    },
                    realmId: '9341453405206',
                    autoSync: {
                        enabled: true,
                        jobID: '4604867689969023701',
                    },
                    syncClasses: 'REPORT_FIELD',
                    pendingFields: {},
                    errorFields: {},
                    syncLocations: 'NONE',
                    autoCreateVendor: false,
                    collectionAccountID: '29',
                    enableNewCategories: true,
                    export: {
                        exporter: 'zhenja3033@gmail.com',
                    },
                    exportDate: 'REPORT_EXPORTED',
                    hasChosenAutoSyncOption: true,
                    lastConfigurationTime: 1730721696740,
                    markChecksToBePrinted: false,
                    nonReimbursableBillDefaultVendor: 'NONE',
                    nonReimbursableExpensesAccount: {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents',
                    },
                    nonReimbursableExpensesExportDestination: 'debit_card',
                    reimbursableExpensesAccount: {
                        currency: 'PLN',
                        glCode: '',
                        id: '29',
                        name: 'Cash and cash equivalents',
                    },
                    reimbursableExpensesExportDestination: 'bill',
                    reimbursementAccountID: '29',
                    syncCustomers: 'TAG',
                    syncItems: false,
                    syncPeople: false,
                    syncTax: false,
                },
                data: {
                    accountPayable: [],
                    accountsReceivable: [],
                    bankAccounts: [
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '29',
                            name: 'Cash and cash equivalents',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '30',
                            name: 'Test 1234',
                        },
                    ],
                    country: 'PL',
                    creditCards: [],
                    edition: 'QuickBooks Online Simple Start',
                    employees: [],
                    homeCurrency: 'PLN',
                    isMultiCurrencyEnabled: false,
                    journalEntryAccounts: [
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '32',
                            name: 'Accrued liabilities',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '70',
                            name: 'Allowance for bad debt',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '13',
                            name: 'Available for sale assets (short-term)',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '38',
                            name: 'Dividends payable',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '26',
                            name: 'Income tax payable',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '65',
                            name: 'Inventory',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '74',
                            name: 'Payroll Clearing',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '73',
                            name: 'Payroll liabilities',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '47',
                            name: 'Prepaid expenses',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '71',
                            name: 'Short-term debit',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '1',
                            name: 'Uncategorised Asset',
                        },
                    ],
                    otherCurrentAssetAccounts: [
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '70',
                            name: 'Allowance for bad debt',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '13',
                            name: 'Available for sale assets (short-term)',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '65',
                            name: 'Inventory',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '47',
                            name: 'Prepaid expenses',
                        },
                        {
                            currency: 'PLN',
                            glCode: '',
                            id: '1',
                            name: 'Uncategorised Asset',
                        },
                    ],
                    vendors: [],
                },
                lastSync: {
                    errorDate: '',
                    errorMessage: '',
                    isAuthenticationError: false,
                    isConnected: true,
                    isSuccessful: true,
                    source: 'NEWEXPENSIFY',
                    successfulDate: '2024-11-04T12:01:36+0000',
                },
            },
        },
    });
}, [policyID]);

Fixed Issues

$ #51891, #51880, #51887
PROPOSAL:

Tests

Go to staging.new.expensify.com
Choose the workspace from settings
Click company cards >Card Details
Verify that default export account is presented in Export row
Click on menu item -> choose other export account
Verify that selected export account presented in menu item row
Go to Accounting > Export > Export company card expenses as > Export as. And update to Vendor Bill
Verify that export menu item row is not presented

Tax picker QA test:
Pre-condition:
Tax is enabled.
Distance rates are enabled.
Track tax in DIstance rates is enabled.

Go to staging.new.expensify.com
Go to workspace settings.
Go to Distance rates.
Tap on any rate.
Edit "Tax rate"
Verify that Tax rates are shown
Choose any of them
Verify that option is selected

Verify that no errors appear in the JS console

Offline tests

No changes

QA Steps

Go to staging.new.expensify.com
Choose the workspace from settings
Click company cards >Card Details
Verify that default export account is presented in Export row
Click on menu item -> choose other export account
Verify that selected export account presented in menu item row
Go to Accounting > Export > Export company card expenses as > Export as. And update to Vendor Bill
Verify that export menu item row is not presented

Tax picker QA test:
Pre-condition:
Tax is enabled.
Distance rates are enabled.
Track tax in DIstance rates is enabled.

Go to staging.new.expensify.com
Go to workspace settings.
Go to Distance rates.
Tap on any rate.
Edit "Tax rate"
Verify that Tax rates are shown
Choose any of them
Verify that option is selected

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

Vendor Bill:

MacOS: Desktop

desktop.mov

melvin-bot · 2024-11-07T13:07:44Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-11-07T17:59:11Z

@narefyev91

error 'withOnyx' is deprecated. Use useOnyx instead of withOnyx whenever possible.

It isn't related to our PR but it is minor. Could you please fix it on this PR?

DylanDylann · 2024-11-07T18:20:49Z

src/pages/workspace/companyCards/WorkspaceCompanyCardAccountSelectCardPage.tsx

@@ -33,7 +33,7 @@ function WorkspaceCompanyCardAccountSelectCardPage({route}: WorkspaceCompanyCard
    const workspaceAccountID = PolicyUtils.getWorkspaceAccountID(policyID);
    const [searchText, setSearchText] = useState('');

-    const [allBankCards] = useOnyx(`${ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST}${workspaceAccountID}_${bank}`);
+    const [allBankCards] = useOnyx(`${ONYXKEYS.CARD_LIST}`);


@narefyev91 Could you explain this change? I think using ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST is correct on this page. please correct me If I am wrong

@DylanDylann on src/pages/workspace/companyCards/WorkspaceCompanyCardDetailsPage.tsx - we show information which is coming from here:

That's why any changes using ONYXKEYS.COLLECTION.WORKSPACE_CARDS_LIST was not shown on WorkspaceCompanyCardDetailsPage - because we are not using that key for showing card details

@narefyev91 Could you please merge main and check again? It has been updated recently

DylanDylann · 2024-11-07T18:22:14Z

When calling SetCardExportAccount, this is the response from BE and it seems the optimistic data doesn't match to it

DylanDylann · 2024-11-11T04:42:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

DylanDylann · 2024-11-11T04:46:09Z

@narefyev91 For QA tests, please update step 7:

Go to Accounting > Export > Export company card expenses as > Export as. And update to Vendor Bill

Screen.Recording.2024-11-11.at.11.43.05.mov

DylanDylann · 2024-11-11T04:46:33Z

@narefyev91 One minor comment, the rest looks fine

narefyev91 · 2024-11-12T08:28:49Z

@DylanDylann updated PR.

DylanDylann · 2024-11-12T11:03:07Z

@narefyev91 Please complete the checklist

mountiny

Thanks! Lets now starting thinking how to for each pr add unit tests to catch this regression/ or gatekeep new feature behaviour

mountiny · 2024-11-12T11:11:34Z

@narefyev91 also you have migrated the taxPicker to useOnyx, can you add a test that will cover that component?

DylanDylann · 2024-11-12T11:12:23Z

Thanks! Lets now starting thinking how to for each pr add unit tests to catch this regression/ or gatekeep new feature behaviour

@mountiny I will complete the checklist in the linked issues

OSBotify · 2024-11-12T11:21:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

narefyev91 · 2024-11-12T12:57:38Z

Tax rate component test (based on useOnyx hook):

Screen.Recording.2024-11-12.at.14.56.01.mov

mountiny · 2024-11-12T17:43:19Z

@narefyev91 can you please add the steps to the QA/ test so QA can run through it?

github-actions · 2024-11-13T01:09:07Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

joekaufmanexpensify · 2024-11-13T15:09:45Z

Confirmed updating a selection is working now!

joekaufmanexpensify · 2024-11-13T15:11:33Z

Confirmed we also remove export row when set to vendor bill!

joekaufmanexpensify · 2024-11-13T15:15:59Z

For this one , we are now showing a default selection in the row, but it is not Default card, it's just whatever the export setting is set to. Example below. We want this to be set to Default card by default, so if the default changes in the integration level export settings, the card level exports will continue to just use whatever's set as the integration level default. Does that make sense @narefyev91 ?

narefyev91 · 2024-11-13T15:20:53Z

For this one , we are now showing a default selection in the row, but it is not Default card, it's just whatever the export setting is set to. Example below. We want this to be set to Default card by default, so if the default changes in the integration level export settings, the card level exports will continue to just use whatever's set as the integration level default. Does that make sense @narefyev91 ?

@joekaufmanexpensify Not sure if i get to be honest.
In your example - we should not show Bill.com Money In Clearing - and show "Default card"?

github-actions · 2024-11-14T00:40:25Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.0.61-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

hungvu193 · 2025-02-25T08:02:23Z

src/pages/workspace/companyCards/utils.tsx

                    data = getNetSuitePayableAccountOptions(policy ?? undefined, config?.payableAcct);
+                    title = companyCard?.nameValuePairs?.netsuite_export_payable_account ?? data.find((exportPayable) => exportPayable.isSelected)?.text;


This line introduces: #55753

More details: #55753 (comment)

narefyev91 added 2 commits November 7, 2024 14:56

Workspace Feed - Fix export item issues

ab496ec

remove mock data

461fddb

narefyev91 requested a review from a team as a code owner November 7, 2024 13:07

melvin-bot bot requested review from DylanDylann and removed request for a team November 7, 2024 13:07

DylanDylann reviewed Nov 7, 2024

View reviewed changes

fixes after review

fabbbd3

narefyev91 requested a review from DylanDylann November 8, 2024 14:43

mountiny assigned narefyev91 Nov 11, 2024

mountiny self-requested a review November 11, 2024 22:28

narefyev91 added 2 commits November 12, 2024 10:12

Merge branch 'refs/heads/main' into workspace-feed-fix-export-item

d737d7b

use correct onyx key to get data from

6e115b2

DylanDylann approved these changes Nov 12, 2024

View reviewed changes

mountiny approved these changes Nov 12, 2024

View reviewed changes

mountiny added the InternalQA This pull request required internal QA label Nov 12, 2024

mountiny changed the title ~~[NO QA]: Workspace Feed - Fix export item issues~~ Workspace Feed - Fix export item issues Nov 12, 2024

mountiny merged commit f906450 into Expensify:main Nov 12, 2024
18 of 19 checks passed

github-actions bot mentioned this pull request Nov 13, 2024

Deploy Checklist: New Expensify 2024-11-13 #52440

Closed

41 tasks

melvin-bot bot mentioned this pull request Nov 14, 2024

[HOLD for payment 2024-12-05] [Workspace feeds] When accounting integration is connected, there's no default in the card export row. It should be "Default card" #51891

Closed

8 tasks

DylanDylann mentioned this pull request Nov 21, 2024

[Internal QA]: Fix default card with export type #52575

Merged

49 tasks

hungvu193 reviewed Feb 25, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Workspace Feed - Fix export item issues #52180

Workspace Feed - Fix export item issues #52180

narefyev91 commented Nov 7, 2024 •

edited

Loading

melvin-bot bot commented Nov 7, 2024

DylanDylann commented Nov 7, 2024 •

edited

Loading

DylanDylann Nov 7, 2024

narefyev91 Nov 8, 2024

DylanDylann Nov 11, 2024

DylanDylann commented Nov 7, 2024

DylanDylann commented Nov 11, 2024 •

edited

Loading

DylanDylann commented Nov 11, 2024

DylanDylann commented Nov 11, 2024 •

edited

Loading

narefyev91 commented Nov 12, 2024

DylanDylann commented Nov 12, 2024

mountiny left a comment

mountiny commented Nov 12, 2024

DylanDylann commented Nov 12, 2024 •

edited

Loading

OSBotify commented Nov 12, 2024

narefyev91 commented Nov 12, 2024

mountiny commented Nov 12, 2024

github-actions bot commented Nov 13, 2024

joekaufmanexpensify commented Nov 13, 2024

joekaufmanexpensify commented Nov 13, 2024

joekaufmanexpensify commented Nov 13, 2024

narefyev91 commented Nov 13, 2024 •

edited

Loading

github-actions bot commented Nov 14, 2024

hungvu193 Feb 25, 2025

		data = getNetSuitePayableAccountOptions(policy ?? undefined, config?.payableAcct);
		title = companyCard?.nameValuePairs?.netsuite_export_payable_account ?? data.find((exportPayable) => exportPayable.isSelected)?.text;

Workspace Feed - Fix export item issues #52180

Workspace Feed - Fix export item issues #52180

Conversation

narefyev91 commented Nov 7, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 7, 2024

DylanDylann commented Nov 7, 2024 • edited Loading

DylanDylann Nov 7, 2024

Choose a reason for hiding this comment

narefyev91 Nov 8, 2024

Choose a reason for hiding this comment

DylanDylann Nov 11, 2024

Choose a reason for hiding this comment

DylanDylann commented Nov 7, 2024

DylanDylann commented Nov 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Nov 11, 2024

DylanDylann commented Nov 11, 2024 • edited Loading

narefyev91 commented Nov 12, 2024

DylanDylann commented Nov 12, 2024

mountiny left a comment

Choose a reason for hiding this comment

mountiny commented Nov 12, 2024

DylanDylann commented Nov 12, 2024 • edited Loading

OSBotify commented Nov 12, 2024

narefyev91 commented Nov 12, 2024

mountiny commented Nov 12, 2024

github-actions bot commented Nov 13, 2024

joekaufmanexpensify commented Nov 13, 2024

joekaufmanexpensify commented Nov 13, 2024

joekaufmanexpensify commented Nov 13, 2024

narefyev91 commented Nov 13, 2024 • edited Loading

github-actions bot commented Nov 14, 2024

hungvu193 Feb 25, 2025

Choose a reason for hiding this comment

narefyev91 commented Nov 7, 2024 •

edited

Loading

DylanDylann commented Nov 7, 2024 •

edited

Loading

DylanDylann commented Nov 11, 2024 •

edited

Loading

DylanDylann commented Nov 11, 2024 •

edited

Loading

DylanDylann commented Nov 12, 2024 •

edited

Loading

narefyev91 commented Nov 13, 2024 •

edited

Loading