[$250] [HOLD for payment 2024-11-22] [Search v2.5] If Search in suggests a workspace chat, we should add the reportID filter instead of in. Same goes for invoice and trip rooms

[luacmartins]

Coming from this thread, we should make expenses the default type when suggesting contextual report searches if the report is a workspace chat or invoice room

1. Head to the workspace chat
2. Click the router, opt for Search in
3. Add the merchant/description from a historical expense

Expected result
Standard search for a workspace chat would be the expense type

Actual result
I land on the Search results page with type:chats selected

cc @SzymczakJ

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857432600242148425
• Upwork Job ID: 1857432600242148425
• Last Price Increase: 2024-11-15

[melvin-bot]

Triggered auto assignment to @johncschuster (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[289Adam289]

Hi I am Adam from SWM and I'd like to work on this issue

[289Adam289]

From my understanding, using: type:expense reportID:<workspace chat> and type:invoice reportID:<invoice room> should get all expenses/invoices from a specific room, but I'm not receiving any results. Is this supported on the backend, or should a different query be created?

[luacmartins]

I think the reason you don't see any results is because those reportIDs belong to a chat report and the expenses are actually reported on expense or invoice type reports, which is a child of the chat report. So I think a more accurate filter would be type:expense policyID:<workspaceID> from:<workspace chat participant email> since that'd filter all expenses sent by a user to the workspace, which should live in the workspace chat. Similarly, for invoice type:invoice policyID:<invoice room policyID> from:<invoice room participant email>.

cc @JmillsExpensify to confirm since you suggested this change

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.62-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Improve Search in suggestion in Search Router #52100

If no regressions arise, payment will be issued on 2024-11-22. 🎊

For reference, here are some details about the assignees on this issue:

• @rayane-djouah requires payment (Needs manual offer from BZ)
• @289Adam289 does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@johncschuster] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857432600242148425

[melvin-bot]

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

[johncschuster]

Adding External to create the Upwork job

[johncschuster]

Payment Summary:

Contributor: @289Adam289 does not require payment

Contributor+: @rayane-djouah paid $250 via Upwork

Upwork job here! Please apply

[rayane-djouah]

No need for regression test steps for now; they will be added as part of the project wrap-up.

[johncschuster]

Thank you! Payment will be issued once the regression threshold is passed 👍

[johncschuster]

Just dropping a note for Melv. This will be eligible for payment in two days 👍

[johncschuster]

@rayane-djouah can you please accept the invite to the job?

[rayane-djouah]

@johncschuster Accepted, Thanks!

[johncschuster]

Paid! Thanks for your contributions! 🎉