Search -"To" filter is auto-populated in the search query for invoice room

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.62-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+290310@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Send invoices.
3. Send an invoice to anyone.
4. Go to invoice room.
5. Click on the search icon on the top right.
6. Click Search in.

Expected Result:

There will be no "To" filter in the search query.

Actual Result:

There is "To" filter in the search query.

This issue only happens in invoice room. In workspace chat, there is no "To" filter in the search query.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6664951_1731574950524.20241114_094820.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is "To" filter in the search query.

What is the root cause of that problem?

In this PR we added to: to type invoice room and did not add for other types

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 87 to 89 in 04402e9

	if (item.roomType === CONST.SEARCH.DATA_TYPES.INVOICE && item.autocompleteID) {
	additionalQuery += ` ${CONST.SEARCH.SYNTAX_FILTER_KEYS.TO}:${SearchQueryUtils.sanitizeSearchValue(item.searchQuery ?? '')}`;
	}

What changes do you think we should make in order to solve the problem?

To make it consistent we should remove the add to: condition here.

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 87 to 89 in 04402e9

	if (item.roomType === CONST.SEARCH.DATA_TYPES.INVOICE && item.autocompleteID) {
	additionalQuery += ` ${CONST.SEARCH.SYNTAX_FILTER_KEYS.TO}:${SearchQueryUtils.sanitizeSearchValue(item.searchQuery ?? '')}`;
	}

or we should add to: for other types like expense

What alternative solutions did you explore? (Optional)

[rayane-djouah]

Not a bug, This is intended
cc @luacmartins

[Kicu]

I believe related to this issue and comment? #51964 (comment)
@289Adam289 was working on this and also agrees that we expect this behavior

[luacmartins]

This is the expected behavior. Closing.