[HOLD for payment 2024-11-28] [$250] Status- Unable to set correct emoji for status in user's profile

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.57-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5183239&group_by=cases:section_id&group_order=asc&group_id=229064
Email or phone of affected tester (no customers): applausetester+ck11052@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com & log in with new account
2. Go to Settings
3. Click the status icon
4. Select any emoji]
5. Enter message >> select Today >> click save

Expected Result:

Correct emoji should be displayed at top right in settings modal next to user's account

Actual Result:

Unable to set correct emoji for status in user's profile

Workaround:

Inknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6643635_1729710869754.20241024_031118.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854955374414588963
• Upwork Job ID: 1854955374414588963
• Last Price Increase: 2024-11-08
• Automatic offers:
• daledah | Contributor | 104885180

Issue Owner

Current Issue Owner: @alitoshmatov

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

Issue is repro only on Mac/Safari

[daledah]

Edited by proposal-police: This proposal was edited at 2024-11-06 00:01:04 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Unable to set correct emoji for status in user's profile

What is the root cause of that problem?

• When submiting the status form, it calls ValidationUtils.prepareValues(inputValues):

App/src/components/Form/FormProvider.tsx

Line 193 in 8fc023f

const trimmedStringValues = shouldTrimValues ? ValidationUtils.prepareValues(inputValues) : inputValues;

which will convert any emoji value to ''. But why?

• In prepareValues function, it calls:

App/src/libs/ValidationUtils.ts

Line 468 in 8fc023f

trimmedStringValues[inputID] = StringUtils.removeInvisibleCharacters(inputValue);

which will remove invisible characters from a string.

• In removeInvisibleCharacters, we call:

App/src/libs/StringUtils.ts

Line 47 in 8fc023f

part.replace(/[\p{Cc}\p{Cs}\p{Co}\p{Cn}]/gu, ''),

to remove all the characters from the 'Other' (C) category except for format characters (Cf). In here, we have the difference between Chrome and Safari due to Safari’s limited support for Unicode property escapes (like \p{Cs}).

• \p{Cs} is a Unicode property that matches surrogate characters. In Chrome, the regex /[\p{Cs}]/gu correctly interprets surrogate pairs and removes only surrogate characters outside the BMP if they match. In Safari, without full support for \p{Cs}, Safari may treat the whole string as a match or fail to apply the regex correctly.

What changes do you think we should make in order to solve the problem?

• To avoid this issue, we can detect surrogate pairs with an alternative regex that does not rely on \p{Cs}, by using \uD800-\uDBFF instead:

App/src/libs/StringUtils.ts

Line 47 in 8fc023f

part.replace(/[\p{Cc}\p{Cs}\p{Co}\p{Cn}]/gu, ''),

            part.replace(/([\uD800-\uDBFF][\uDC00-\uDFFF])|[\p{Cc}\p{Co}\p{Cn}]/gu, ''),

• We can only apply the above in case of safari by using Browser.isSafari() check, otherwise, leave it as it is.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854955374414588963

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[FitseTLT]

Can't reproduce this.

[daledah]

I can reproduce. What about you @alitoshmatov?

[melvin-bot]

@bfitzexpensify, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[alitoshmatov]

I also can't reproduce. @IuliiaHerets Looks like OP has different recording, can you provide recording for this issue

[daledah]

@alitoshmatov You tested in Chrome or Safari? The issue is only reproducible in safari.

[alitoshmatov]

Oh I see, I was able to reproduce on Safari

[alitoshmatov]

@daledah Thank you for detailed explanation, your RCA is correct and solve the issue

We can go with @daledah 's proposal

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @thienlnam, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @daledah 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@alitoshmatov PR is ready.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: cannot set emoji status on safari #52538

If no regressions arise, payment will be issued on 2024-11-28. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment through NewDot Manual Requests
• @daledah requires payment automatic offer (Contributor)

[melvin-bot]

@alitoshmatov @bfitzexpensify @alitoshmatov The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[bfitzexpensify]

Payment complete to @daledah - @alitoshmatov, please complete the BZ checklist and I'll complete the payment summary for the C+ work

[melvin-bot]

@thienlnam, @bfitzexpensify, @alitoshmatov, @daledah Whoops! This issue is 2 days overdue. Let's get this updated quick!

[alitoshmatov]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/27414/files#r1865846527

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: No need

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

  Existing tests should cover this case

[alitoshmatov]

@bfitzexpensify Completed the checklist

[bfitzexpensify]

Thanks!

Payment summary:

@alitoshmatov to be paid $250 for C+ work via manual request
@daledah has been paid $250 via Upwork for contirbutor work ✅

[JmillsExpensify]

$250 approved for @alitoshmatov