Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] [$250] Android - Chat - App crashes when trying to split expense #52099

Closed
2 of 8 tasks
IuliiaHerets opened this issue Nov 6, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 6, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #51849
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the Expensify app with Gmail account.
  2. Open any group chat.
  3. Tap on the "+" icon and select "Split Expense"
  4. Verify you are able to complete with any amount.

Expected Result:

User should be able to complete the split expense flow properly in any group chat.

Actual Result:

App crashes when opening a group chat and starting the split expense flow.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

0611.txt

Bug6656128_1730866334057.Split_Crash.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021854131328155845207
  • Upwork Job ID: 1854131328155845207
  • Last Price Increase: 2024-11-06
Issue OwnerCurrent Issue Owner: @twisterdotcom
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 6, 2024
Copy link

melvin-bot bot commented Nov 6, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 6, 2024

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 6, 2024
Copy link

melvin-bot bot commented Nov 6, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 6, 2024
Copy link
Contributor

github-actions bot commented Nov 6, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

This issue is repro only with Gmail account

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Nov 6, 2024
@melvin-bot melvin-bot bot changed the title Android - Chat - App crashes when trying to split expense [$250] Android - Chat - App crashes when trying to split expense Nov 6, 2024
Copy link

melvin-bot bot commented Nov 6, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021854131328155845207

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 6, 2024
Copy link

melvin-bot bot commented Nov 6, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

@mountiny
Copy link
Contributor

mountiny commented Nov 6, 2024

Looking for the offending pr for $50

@Nodebrute
Copy link
Contributor

Nodebrute commented Nov 6, 2024

Yesterday, I was experiencing the same crashes on iOS. It was related to this PR: #48772, and was fixed in #52051. I'm not entirely sure, but I believe this might be related to this #52051 /#48772

@kavimuru
Copy link

kavimuru commented Nov 6, 2024

Fixed

screen-20241106-142053.mp4

Copy link

melvin-bot bot commented Nov 6, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@rlinoz rlinoz removed the DeployBlockerCash This issue or pull request should block deployment label Nov 6, 2024
Copy link

melvin-bot bot commented Nov 6, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 7, 2024
@melvin-bot melvin-bot bot changed the title [$250] Android - Chat - App crashes when trying to split expense [HOLD for payment 2024-11-14] [$250] Android - Chat - App crashes when trying to split expense Nov 7, 2024
Copy link

melvin-bot bot commented Nov 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 7, 2024
Copy link

melvin-bot bot commented Nov 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-14. 🎊

For reference, here are some details about the assignees on this issue:

  • @DylanDylann requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Nov 7, 2024

@DylanDylann @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

mountiny commented Nov 7, 2024

Straight revert PR that was CPed to staging, the authors been notified and there was no checklist to be paid on the revert PR so I think we can close this and the original author will retry the PR keeping this bug in mind

@mountiny mountiny closed this as completed Nov 7, 2024
@Nodebrute
Copy link
Contributor

Yesterday, I was experiencing the same crashes on iOS. It was related to this PR: #48772, and was fixed in #52051. I'm not entirely sure, but I believe this might be related to this #52051 /#48772

Hey @mountiny, will there be any compensation for identifying this offending PR?

@mountiny
Copy link
Contributor

mountiny commented Nov 7, 2024

Ah good point, thanks for raising. We discussed this at the same time in Slack where C+ helped to identify it too and seems like I created the revert PR #52112 before your comment (looking at the timestamps) so while I appreciate your help I think I would not issue a reward at this case since we managed to find the offending PR before your comment

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Nov 11, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-11-14] [$250] Android - Chat - App crashes when trying to split expense [HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] [$250] Android - Chat - App crashes when trying to split expense Nov 11, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-18. 🎊

For reference, here are some details about the assignees on this issue:

  • @DylanDylann requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Nov 11, 2024

@DylanDylann @twisterdotcom The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants