Feature: add loading indicator when ReconnectApp is running #48772

nkdengineer · 2024-09-09T03:48:35Z

Details

Fixed Issues

$ #46611
PROPOSAL: #46611 (comment)

Tests

Login to app
Go to offline mode
Back to online mode
Verify that: loading indicator is displayed

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to app
Go to offline mode
Back to online mode
Verify that: loading indicator is displayed

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-09-09T09:28:33Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dubielzyk-expensify · 2024-09-09T09:42:26Z

We should be using our color variables here so on light mode we should end up with this:

It looks like the background of the loading indicator is a dark mode color?

nkdengineer · 2024-09-09T09:57:24Z

@dubielzyk-expensify I updated to fix this case.

dubielzyk-expensify · 2024-09-09T10:27:03Z

Awesome. Can you update the recordings please 😇?

nkdengineer · 2024-09-09T10:29:58Z

@dubielzyk-expensify i'll update soon

nkdengineer · 2024-09-09T10:54:16Z

@dubielzyk-expensify @getusha i updated, please check again

dannymcclain · 2024-09-09T13:22:18Z

I am really excited for this to be in the product 😊

dubielzyk-expensify · 2024-09-10T01:10:20Z

This is looking awesome. Tiny tiny nitpick, but do the background of the loading bar and the loading bar itself have rounded corners? If so, can we remove them? It looks a bit better when this is square to match the page header border

src/components/ProgressBar.tsx

nkdengineer · 2024-09-10T15:08:36Z

@getusha i updated

getusha

minor comments

src/components/ProgressBar.tsx

getusha · 2024-09-27T07:49:06Z

@nkdengineer the UI is still jumpy, didn't we position it absolute?

Screen.Recording.2024-09-27.at.10.48.14.in.the.morning.mov

getusha · 2024-09-27T09:50:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-04.at.12.47.39.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2024-10-01.at.12.20.56.in.the.afternoon.mov

iOS: Native

Screen.Recording.2024-11-04.at.1.06.04.in.the.afternoon.mov

iOS: mWeb Safari

Screen.Recording.2024-09-27.at.11.04.27.in.the.morning.mov

MacOS: Chrome / Safari

Screen.Recording.2024-09-27.at.11.00.26.in.the.morning.mov

MacOS: Desktop

Screen.Recording.2024-11-04.at.1.06.44.in.the.afternoon.mov

nkdengineer · 2024-09-30T09:02:43Z

@nkdengineer the UI is still jumpy, didn't we position it absolute?

@getusha I fixed, please check again

getusha · 2024-10-01T09:27:08Z

src/components/ProgressBar.tsx

+
+    const animatedContainerStyle = useAnimatedStyle(() => {
+        return {
+            opacity: opacity.value,


Any way to hide the container? i can see it with a white background when it isn't active

From this comment, Do I need to fix this?

I think so yes, looks off to leave it like that. WDYT @dubielzyk-expensify?

@nkdengineer have we covered this?

@getusha i fixed

dubielzyk-expensify · 2024-10-01T09:58:49Z

This is looking great! All 👍 from me on the visual end. Love the entry and exit fade too

getusha · 2024-10-01T10:06:24Z

Not sure if this is related but the performance on native is really bad it's nearly unusable, i'll check if this is any different on main

Screen.Recording.2024-10-01.at.1.04.58.in.the.afternoon.mov

nkdengineer · 2024-11-05T08:27:45Z

@getusha i updated

src/components/LoadingBar.tsx

Co-authored-by: Getabalew <75031127+getusha@users.noreply.github.com>

src/components/LoadingBar.tsx

srikarparsi

Just two small changes to the comments but other than that looks good to me

nkdengineer · 2024-11-05T09:00:58Z

@srikarparsi i updated

srikarparsi

Awesome thanks!

OSBotify · 2024-11-05T09:22:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2024-11-05T14:44:49Z

Hey @srikarparsi @nkdengineer & @getusha. This PR appears to cause HybridApp to crash. We're getting close to deploying App so I might need to revert this.

staszekscp · 2024-11-05T14:48:42Z

We've just discovered that bumping react-native-reanimated to 3.16 should fix it, @blazejkustra is currently working on the bump!

Julesssss · 2024-11-05T14:52:43Z

Excellent, thanks!

Julesssss · 2024-11-05T15:44:59Z

Being fixed here, no need to revert

github-actions · 2024-11-06T00:36:25Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-11-07T12:41:28Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.58-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	skipped 🚫
🍎🔄 iOS HybridApp 🍎🔄	skipped 🚫

nkdengineer added 2 commits September 9, 2024 10:46

Feature: add loading indicator when ReconnectApp is running

890eba7

fix ts check

7a77276

nkdengineer marked this pull request as ready for review September 9, 2024 09:28

nkdengineer requested review from a team as code owners September 9, 2024 09:28

melvin-bot bot requested review from getusha and removed request for a team September 9, 2024 09:28

fix style of progress bar

0265bc6

fix style progress bar

af9b5b8

getusha reviewed Sep 10, 2024

View reviewed changes

src/components/ProgressBar.tsx Outdated Show resolved Hide resolved

add new const and fix style progress bar

c177829

getusha reviewed Sep 15, 2024

View reviewed changes

src/components/ProgressBar.tsx Outdated Show resolved Hide resolved

src/components/ProgressBar.tsx Outdated Show resolved Hide resolved

merge main

2fcd466

nkdengineer added 2 commits September 30, 2024 15:32

Merge branch 'main' into feature/46611

57c403d

fix style progress bar

32117b2

getusha reviewed Oct 1, 2024

View reviewed changes

nkdengineer added 3 commits November 5, 2024 11:03

rename

9e2fe98

fix lint

40f5fd5

fix test

eff6ce2

getusha approved these changes Nov 5, 2024

View reviewed changes

src/components/LoadingBar.tsx Outdated Show resolved Hide resolved

melvin-bot bot requested a review from srikarparsi November 5, 2024 08:34

getusha approved these changes Nov 5, 2024

View reviewed changes

Update src/components/LoadingBar.tsx

431bbc1

Co-authored-by: Getabalew <75031127+getusha@users.noreply.github.com>

srikarparsi reviewed Nov 5, 2024

View reviewed changes

src/components/LoadingBar.tsx Outdated Show resolved Hide resolved

srikarparsi reviewed Nov 5, 2024

View reviewed changes

src/components/LoadingBar.tsx Outdated Show resolved Hide resolved

srikarparsi requested changes Nov 5, 2024

View reviewed changes

minor change

31335cf

srikarparsi approved these changes Nov 5, 2024

View reviewed changes

srikarparsi merged commit 596671b into Expensify:main Nov 5, 2024
16 checks passed

Julesssss mentioned this pull request Nov 5, 2024

Revert "Feature: add loading indicator when ReconnectApp is running" #52047

Closed

war-in mentioned this pull request Nov 5, 2024

Bump reanimated and fix LoadingBar error #52051

Merged

47 tasks

Julesssss mentioned this pull request Nov 5, 2024

[HOLD for payment 2024-11-14] HybridApp crashing in dev due to react-native-reanimated #52053

Closed

situchan mentioned this pull request Nov 5, 2024

[HOLD for payment 2024-11-18] [$125] Expensify Card - Back button on issue card page returns to Bank account verified page #51883

Closed

8 tasks

github-actions bot mentioned this pull request Nov 5, 2024

Deploy Checklist: New Expensify 2024-11-05 #52084

Closed

71 tasks

mountiny mentioned this pull request Nov 6, 2024

[CP Staging] Revert "Feature: add loading indicator when ReconnectApp is running" #52112

Merged

Nodebrute mentioned this pull request Nov 6, 2024

[HOLD for payment 2024-11-18] [HOLD for payment 2024-11-14] [$250] Android - Chat - App crashes when trying to split expense #52099

Closed

8 tasks

QichenZhu mentioned this pull request Nov 16, 2024

[HOLD for payment 2024-11-29] [$250] Android - App crashes when create new chat #52496

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: add loading indicator when ReconnectApp is running #48772

Feature: add loading indicator when ReconnectApp is running #48772

nkdengineer commented Sep 9, 2024 •

edited

Loading

melvin-bot bot commented Sep 9, 2024

dubielzyk-expensify commented Sep 9, 2024

nkdengineer commented Sep 9, 2024

dubielzyk-expensify commented Sep 9, 2024

nkdengineer commented Sep 9, 2024

nkdengineer commented Sep 9, 2024

dannymcclain commented Sep 9, 2024

dubielzyk-expensify commented Sep 10, 2024

nkdengineer commented Sep 10, 2024

getusha left a comment

getusha commented Sep 27, 2024

getusha commented Sep 27, 2024 •

edited

Loading

nkdengineer commented Sep 30, 2024

getusha Oct 1, 2024

nkdengineer Oct 2, 2024

getusha Oct 2, 2024

getusha Oct 28, 2024

nkdengineer Nov 4, 2024

dubielzyk-expensify commented Oct 1, 2024

getusha commented Oct 1, 2024

nkdengineer commented Nov 5, 2024

srikarparsi left a comment

nkdengineer commented Nov 5, 2024

srikarparsi left a comment

OSBotify commented Nov 5, 2024

Julesssss commented Nov 5, 2024

staszekscp commented Nov 5, 2024

Julesssss commented Nov 5, 2024

Julesssss commented Nov 5, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

Feature: add loading indicator when ReconnectApp is running #48772

Feature: add loading indicator when ReconnectApp is running #48772

Conversation

nkdengineer commented Sep 9, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 9, 2024

dubielzyk-expensify commented Sep 9, 2024

nkdengineer commented Sep 9, 2024

dubielzyk-expensify commented Sep 9, 2024

nkdengineer commented Sep 9, 2024

nkdengineer commented Sep 9, 2024

dannymcclain commented Sep 9, 2024

dubielzyk-expensify commented Sep 10, 2024

nkdengineer commented Sep 10, 2024

getusha left a comment

Choose a reason for hiding this comment

getusha commented Sep 27, 2024

getusha commented Sep 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

nkdengineer commented Sep 30, 2024

getusha Oct 1, 2024

Choose a reason for hiding this comment

nkdengineer Oct 2, 2024

Choose a reason for hiding this comment

getusha Oct 2, 2024

Choose a reason for hiding this comment

getusha Oct 28, 2024

Choose a reason for hiding this comment

nkdengineer Nov 4, 2024

Choose a reason for hiding this comment

dubielzyk-expensify commented Oct 1, 2024

getusha commented Oct 1, 2024

nkdengineer commented Nov 5, 2024

srikarparsi left a comment

Choose a reason for hiding this comment

nkdengineer commented Nov 5, 2024

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 5, 2024

Julesssss commented Nov 5, 2024

staszekscp commented Nov 5, 2024

Julesssss commented Nov 5, 2024

Julesssss commented Nov 5, 2024

github-actions bot commented Nov 6, 2024

github-actions bot commented Nov 7, 2024

nkdengineer commented Sep 9, 2024 •

edited

Loading

getusha commented Sep 27, 2024 •

edited

Loading