[$250] Room - Page does not scroll to bottom when send message in #expensify-roadmap public room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Log in to staging.new.expensify.com
2. Open #expensify-roadmap public room ( https://staging.new.expensify.com/r/868417741568295
   )
3. Scroll to the top of the page
4. Send a message

Expected Result:

Page should scroll to the bottom when send new message

Actual Result:

Page does not scroll to bottom of the conversation

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6657900_1731001767296.Recording__4488.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021855979378378206243
• Upwork Job ID: 1855979378378206243
• Last Price Increase: 2024-11-18

Issue Owner

Current Issue Owner: @akinwale

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021855979378378206243

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

[jestinjoshi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Page does not scroll to bottom of the conversation in #expensify-roadmap public room

What is the root cause of that problem?

App/src/pages/home/report/ReportActionsList.tsx

Line 427 in b2d6a0e

return;

What changes do you think we should make in order to solve the problem?

The return statement can be removed here, as it was added simply to follow a similar logic in scrollToBottomAndMarkReportAsRead, as noted in #46724 (comment). Removing it won't affect functionality in this context.

What alternative solutions did you explore? (Optional)

NA

[Anaslancer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Room - Page does not scroll to bottom when send message in #expensify-roadmap public room

What is the root cause of that problem?

We are calling the scrollToBottomForCurrentUserAction callback function before changing the hasNewestReportActionRef.current. we should wait until changing hasNewestReportActionRef.current.

What changes do you think we should make in order to solve the problem?

We need to wrap this block into the InteractionManager.runAfterInteractions.

App/src/pages/home/report/ReportActionsList.tsx

Lines 417 to 429 in b2d6a0e

	// If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where
	// they are now in the list.
	if (!isFromCurrentUser) {
	return;
	}
	if (!hasNewestReportActionRef.current) {
	if (isInNarrowPaneModal) {
	return;
	}
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	return;
	}
	InteractionManager.runAfterInteractions(() => reportScrollManager.scrollToBottom());

So this below is the working block;

            InteractionManager.runAfterInteractions(() => {
                // If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where
                // they are now in the list.
                if (!isFromCurrentUser) {
                    return;
                }
                if (!hasNewestReportActionRef.current) {
                    if (isInNarrowPaneModal) {
                        return;
                    }
                    Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
                    return;
                }
                reportScrollManager.scrollToBottom();
            });

What alternative solutions did you explore? (Optional)

N/A

Contributor details

Your Expensify account email: anasup1995@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01aff093c9a804b145

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[akinwale]

@Anaslancer Could you post a video demo of your proposed solution?

[Anaslancer]

@akinwale Here is the before video

before.mp4

[Anaslancer]

@akinwale Here is the after video

after.mp4

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@akinwale, @sonialiap Eep! 4 days overdue now. Issues have feelings too...

[sonialiap]

@akinwale what do you think of the videos showing the proposal?

[akinwale]

I will review and test this today.

[akinwale]

We can move forward with @Anaslancer's proposal here.

🎀👀🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

@akinwale @sonialiap @aldo-expensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 @Anaslancer You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[Anaslancer]

Applied on Upwork. Thank you!!!

[Anaslancer]

May I create a PR now?

[akinwale]

May I create a PR now?

Yes, you have been assigned to the issue, so you can go ahead.

[aldo-expensify]

Waiting on: #52955 (review)

[melvin-bot]

Current assignee @sonialiap is eligible for the Bug assigner, not assigning anyone new.

[sonialiap]

I'm OOO Dec 16-20, adding a leave buddy

next steps:

• might need payment while I'm out

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[garrettmknight]

👋 it looks like this issue might be a regression from the PR for this fix. @aldo-expensify / @akinwale can you have a look?