Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Hybrid - Android - Login - "Log in" button slightly overlaps with "Didn't receive a magic code? text #52359

Closed
1 of 8 tasks
IuliiaHerets opened this issue Nov 12, 2024 · 12 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.60-0
Reproducible in staging?: N
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #51942
Issue reported by: Applause Internal Team

Action Performed:

  1. Open hybridapp
  2. Tap on "Continue with Email"
  3. Input an existing account
  4. Tap on the "Next" button

Expected Result:

Elements shouldn't overlap.

Actual Result:

"Log in" button slightly overlaps with "Didn't receive a magic code? text.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6662236_1731399393451!Screenshot_20241112_090757

Bug6662236_1731399393450.az_recorder_20241112_090742.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021858670749199429820
  • Upwork Job ID: 1858670749199429820
  • Last Price Increase: 2024-11-19
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 12, 2024
Copy link

melvin-bot bot commented Nov 12, 2024

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Nov 15, 2024

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@alexpensify
Copy link
Contributor

Adding to my testing list

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 16, 2024
@alexpensify alexpensify added the External Added to denote the issue can be worked on by a contributor label Nov 19, 2024
@melvin-bot melvin-bot bot changed the title Hybrid - Android - Login - "Log in" button slightly overlaps with "Didn't receive a magic code? text [$250] Hybrid - Android - Login - "Log in" button slightly overlaps with "Didn't receive a magic code? text Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021858670749199429820

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@melvin-bot melvin-bot bot removed the Overdue label Nov 19, 2024
@alexpensify
Copy link
Contributor

We are waiting for proposals here

@Pujan92
Copy link
Contributor

Pujan92 commented Nov 20, 2024

@alexpensify HybridApp issues need to be internal.

@Pujan92 Pujan92 removed their assignment Nov 20, 2024
@alexpensify alexpensify added Internal Requires API changes or must be handled by Expensify staff Hot Pick Ready for an engineer to pick up and run with and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 20, 2024
@alexpensify
Copy link
Contributor

Thank you for the feedback. I added the Hot Pick label here.

@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

@alexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@arosiclair arosiclair self-assigned this Nov 25, 2024
@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2024
@arosiclair
Copy link
Contributor

I'll take a look at this

@arosiclair
Copy link
Contributor

I can't reproduce on v9.0.66.6 or in dev. Tested with a Pixel 4a and 5:

Pixel 4a (dev) Pixel 5 (v9.0.66.6)
Screenshot_20241125-152939 Screenshot_20241125-153443

@arosiclair
Copy link
Contributor

Closing this out since I couldn't reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Hot Pick Ready for an engineer to pick up and run with Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

4 participants