Search - "Save search" is shown when no category is displayed

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #52102
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new account.
3. Create a new workspace.
4. Go to workspace settings
5. Go to search > filters > Select a category and save search
6. Delete the workspace
7. Go to search > filters
8. Notice that "Save search" is shown even if no category is displayed and no item is selected.

Expected Result:

"Save search" is not shown when there is no item selected.

Actual Result:

"Save search" is shown even if there is no category displayed and no item is selected.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6661988_1731374707602.Screen_Recording_2024-11-12_at_4.06.37_at_night.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Kicu]

I will try to fix this. However I think there is no obvious solution to this edge case, because the saved search exists and it has certain data saved with it.
On one hand if there are no categories in the system then the picker should not be displayed. On the other hand if a category was saved with this "saved search" then we should display it.

I don't know what is the cleanest solution. What do you think about this @luacmartins ?

[MonilBhavsar]

I think if there are no categories, we can still display a category picker, but may be disable it, so user can know that they can filter through categories.
Makes sense to display saved search.

[MonilBhavsar]

I think we can demote it from blocker since it's an edge case

[MonilBhavsar]

@Kicu I'll assign this issue to you, if you don't mind

[luacmartins]

TBH I think we should just close this. The filter is always available to the user via the typed query so they could technically still search for something like category:blah. The point of hiding the filter in the UI is to de-clutter and give users options that make sense, but I don't think we need to clean up previously saved searches. That behavior is not exclusive to showing/hiding the filter, it would also happen if they saved a search with a category that no longer exists -- for that, the user can update the search themselves if they want to.

[luacmartins]

Gonna close this for now.