[HOLD for payment 2024-11-29] [$250] Ellipsis color shown in wrong color in Expense Report details

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.60-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

1. Go to staging.new.expensify.com
2. Submit an expense
3. Open the report to view expense details
4. Click on the header to view details of expense report
5. Observe the From field

Expected Result:

The ellipsis here is in a grayish color and using the correct textSupporting color

Actual Result:

The ellipsis here is in a darker color and is not using the correct textSupporting color (grayish).

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021857481644879800683
• Upwork Job ID: 1857481644879800683
• Last Price Increase: 2024-11-15
• Automatic offers:
• FitseTLT | Contributor | 104919616

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Ellipsis color shown in wrong color in Expense Report details

What is the root cause of that problem?

We are missing a text color style here

App/src/components/ParentNavigationSubtitle.tsx

Line 55 in cd3f30f

style={[styles.optionAlternateText]}

What changes do you think we should make in order to solve the problem?

Add text supporting color

                style={[styles.optionAlternateText, styles.textLabelSupporting]}

What alternative solutions did you explore? (Optional)

[zanyrenney]

How weird!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021857481644879800683

[zanyrenney]

Seems simple enough to fix!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[zanyrenney]

@Pujan92 please can you review the proposal above?

[Pujan92]

@FitseTLT's proposal looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @techievivek, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[techievivek]

@FitseTLT How is the PR going on?

[FitseTLT]

PR will be ready tomorrow 👍

[melvin-bot]

@Pujan92, @techievivek, @FitseTLT, @zanyrenney Whoops! This issue is 2 days overdue. Let's get this updated quick!

[zanyrenney]

When the PR is ready, we'll be waiting on Punjan to review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix - Ellipsis color shown in wrong color in Expense Report details #52779

If no regressions arise, payment will be issued on 2024-11-29. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment through NewDot Manual Requests
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

@Pujan92 @zanyrenney @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[zanyrenney]

@Pujan92 please can you complete the checklist above, ahead of the payment tomorrow? Thanks in advance!

[zanyrenney]

bump @Pujan92

[zanyrenney]

I have dm'd punjan

[Pujan92]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/23621/files#r1864241926

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: NA

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

1. Open any expense report
2. Click on the header to view details of expense report
3. Verify that the ellipsis in the subtitle is of a grayish color. (Note that the workspace name should be long enough to cause the ellipsis to appear)

Do we agree 👍 or 👎

[zanyrenney]

payment summary
@Pujan92 requires payment through NewDot Manual Requests - please request $250
@FitseTLT requires payment automatic offer (Contributor) - paid $250 via upwork, contract ended.

[garrettmknight]

$250 approved fro @Pujan92