[$250] IOU - GBR is missing from the partially approved expense

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.63-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5229984&group_by=cases:section_id&group_id=309128&group_order=asc
Issue reported by: Applause - Internal Team

Action Performed:

• All new Gmail accounts are used
• Workspace has an admin, member, and approver
• "Add approvals" is enabled and the approver account is set as the approver

1. Member: Navigate to https://staging.new.expensify.com/
2. Member: Log in
3. Member: Navigate to the workspace chat
4. Member: Create two manual expenses with any amounts (amounts should be different)
5. Member: Open one of the expenses
6. Member: Put the expense on hold
7. Approver: Log in
8. Approver: Navigate to the workspace chat
9. Approver: Click on "Approve"
10. Approver: Approve just the pending amount

Expected Result:

Newly created report for the held expense is GBR’ed in the LHN (green dot)

Actual Result:

GBR is missing from the partially approved expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6666642_1731695994415.bandicam_2024-11-15_19-27-51-840.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021861120032414784544
• Upwork Job ID: 1861120032414784544
• Last Price Increase: 2024-11-25
• Automatic offers:
• DylanDylann | Reviewer | 105123872
• nkdengineer | Contributor | 105123876

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[OfstadC]

Not overdue Mel - it was the weekend. Will review this tomorrow AM

[OfstadC]

@lanitochka17

GBR should be visible

What specifically is missing here

[OfstadC]

It seems normal to me 🤔

[OfstadC]

https://expensify.slack.com/archives/C9YU7BX5M/p1732211583025239

[kavimuru]

Still reproducible. Actions performed are same, updated the expected result

bandicam.2024-11-22.12-34-26-431.mp4

[OfstadC]

OMG - It was not clear what GBR was to me - April was a saint and helped me!

[OfstadC]

I actually think this is a dupe of this

[OfstadC]

Re-reviewing the other issue it seems they are closely related but differ a bit. Adding to #expense

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021861120032414784544

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2024-11-26 05:05:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

GBR is missing from the partially approved expense

What is the root cause of that problem?

If we approve partially, a new expense report will be created with statusNum and stateNum are getting from here

App/src/libs/actions/IOU.ts

Line 6324 in 38568ed

const optimisticExpenseReport = isPolicyExpenseChat

If isInstantSubmitEnabled and payment is not disabled, the new expense report is marked as submitted.

App/src/libs/ReportUtils.ts

Lines 4646 to 4649 in 38568ed

	if (isInstantSubmitEnabled) {
	return {
	stateNum: CONST.REPORT.STATE_NUM.SUBMITTED,
	statusNum: CONST.REPORT.STATUS_NUM.SUBMITTED,

But in this case hasOutstandingChildRequest is updated to false here before we get the onyx data of the partially case

App/src/libs/actions/IOU.ts

Line 6990 in 38568ed

hasOutstandingChildRequest: hasIOUToApproveOrPay(chatReport, expenseReport?.reportID ?? '-1'),

So no GBR is displayed in LHN

What changes do you think we should make in order to solve the problem?

If we approve in full, we can update hasOutstandingChildRequest like this

App/src/libs/actions/IOU.ts

Line 6990 in 38568ed

hasOutstandingChildRequest: hasIOUToApproveOrPay(chatReport, expenseReport?.reportID ?? '-1'),

In this case, it is not full, we need to update hasOutstandingChildRequest of the chat report to true if the new expense report is marked as submitted

App/src/libs/actions/IOU.ts

Line 7077 in 38568ed

if (!full && !!chatReport && !!expenseReport) {

1. We need to move this optimistic data to this case

if (full && hasHeldExpenses) {
      optimisticData.push({
          onyxMethod: Onyx.METHOD.MERGE,
          key: `${ONYXKEYS.COLLECTION.REPORT}${expenseReport?.chatReportID}`,
          value: {
              hasOutstandingChildRequest: hasIOUToApproveOrPay(chatReport, expenseReport?.reportID ?? '-1'),
          },
      });

App/src/libs/actions/IOU.ts

Line 6986 in 38568ed

const optimisticChatReportData: OnyxUpdate = {

2. In getReportFromHoldRequestsOnyxData function, update hasOutstandingChildRequest of chat report to true if the new expense report is marked as submitted

hasOutstandingChildRequest: optimisticExpenseReport.stateNum === CONST.REPORT.STATE_NUM.SUBMITTED && optimisticExpenseReport.statusNum === CONST.REPORT.STATE_NUM.SUBMITTED,

App/src/libs/actions/IOU.ts

Line 6405 in 38568ed

value: {

3. Require backend change: Backend also needs to update hasOutstandingChildRequest to true in this case of ApproveMoneyRequest API

What alternative solutions did you explore? (Optional)

[DylanDylann]

@nkdengineer Do we need to require BE change to fix this issue?

[DylanDylann]

It seems the BE return wrong hasOutstandingChildRequest in this case

[nkdengineer]

@DylanDylann you're right, updated proposal.

[DylanDylann]

There are some new updates that block partially approve flow. Just ask to clarify #50479 (comment)

[marcochavezf]

how do you feel about updating that to do so only if isFullApproval is true so that in the case of a partial approval the parent report has the GBR added?

Oh sound good, the hasOutstandingChildRequest set to false was implemented before we had partial approvements, so yeah it makes sense to check if is full approval is true for this case

[NikkiWines]

Backend PR is up

[NikkiWines]

Backend PR is merged, will update here when it's deployed

[melvin-bot]

@OfstadC, @NikkiWines, @DylanDylann, @nkdengineer Eep! 4 days overdue now. Issues have feelings too...

[DylanDylann]

waiting for BE deployment

[melvin-bot]

@OfstadC @NikkiWines @DylanDylann @nkdengineer this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[DylanDylann]

@nkdengineer It seems we are ready to implement the PR

[nkdengineer]

thanks @DylanDylann, I'll check and open PR soon

[nkdengineer]

@DylanDylann we have a open PR here

[DylanDylann]

@NikkiWines In this issue, ApproveMoneyRequest API return chatReport.hasOutstandingChildRequest is true in A, but the openReport API return chatReport.hasOutstandingChildRequest is false --> the bug isn't fixed if we click on report again

[NikkiWines]

but the openReport API return chatReport.hasOutstandingChildRequest is false --> the bug isn't fixed if we click on report again

@DylanDylann sorry, can you clarify what steps you take to reproduce this?

(also sorry for not updating when that BE PR went live 🙈)

[DylanDylann]

Steps:

1. Member: Log in
2. Member: Navigate to the workspace chat
3. Member: Create two manual expenses with any amounts (amounts should be different)
4. Member: Open one of the expenses
5. Member: Put the expense on hold
6. Approver: Log in
7. Approver: Navigate to the workspace chat
8. Approver: Click on "Approve"
9. Approver: Approve just the pending amount
10. See that:

• ApproveMoneyRequest return hasOutstandingChildRequest is true in the chat report

• Then if we click on another report and open the chat report again, OpenReport API returns hasOutstandingChildRequest as false in the chat report

Screen.Recording.2024-12-23.at.17.16.48.mov

[DylanDylann]

@NikkiWines Kindly bump

[NikkiWines]

Sorry for the delay here @DylanDylann - was OOO for the holidays and then discussing with some folks about when and where we really need the GBR in this flow. Things get a little murky because the expense can be held by the submitter or by the approver.

In the case of the submitter holding the expense, the GBR makes a bit more sense for the approver, since they can override the action.

In the case of the approver holding the expense, the GBR makes less sense as they've explicitly taken action to put the expense in a held state. There's nothing further for them to really do at this point, though they can override their own hold.

The problem is that we don't distinguish on the backend who has held the expense, and so the flow is unclear. After discussing it with @garrettmknight, I think we can actually omit the GBR here since in both hold flows, the submitter will have the RBR notifying them of the held expense, so at least one user is aware that the expense needs some action.

In that case, I'll actually need to revert my earlier PR and there's no further action herd

[DylanDylann]

@NikkiWines Thanks for your information.

@nkdengineer let's close your PR, we do nothing here

[OfstadC]

@DylanDylann @nkdengineer

@NikkiWines and I chatted and decided we'll still issue some payment here as you both did some work. We'll be issuing $100 to both of you. Offers are below:

@DylanDylann Offer
@nkdengineer Offer

New Upwork Job Link

[DylanDylann]

@OfstadC As this comment, both c+ and contributor should get fully paid in this issue because we started on working the PR (I also reviewed the PR). This issue is closed because it is no longer to fix

Other ref: https://expensify.slack.com/archives/C02NK2DQWUX/p1723055151068559?thread_ts=1723015261.405329&cid=C02NK2DQWUX

[OfstadC]

@NikkiWines Can you review this and let me know your thoughts 😃

[NikkiWines]

Ah, ok - I was unaware of that SO. That makes sense, we can issue full comp here.

[OfstadC]

Payment Summary

• @DylanDylann paid $250 via Upwork
• @nkdengineer updated your offer here. Please note once accepted 😃 paid $250 via Upwork

[nkdengineer]

@OfstadC Accepted thanks

[OfstadC]

Thanks @nkdengineer !

Updated Payment Summary