Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-05] [$50] Update copy on the wallet settings page #52789

Closed
tgolen opened this issue Nov 19, 2024 · 29 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@tgolen
Copy link
Contributor

tgolen commented Nov 19, 2024

Problem

When users find it difficult to navigate our application's features due to interface clutter, it leads to decreased engagement and lower conversion and retention rates.

Solution

Clean up some of the copy on the wallet settings page:

  1. Change the title of the block from "Send and receive money with friends" to "Expensify Wallet"
  2. Change the subtitle from "Your wallet has been enabled to send and receive money with friends." to "Send and receive money with friends."

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021859017641475961132
  • Upwork Job ID: 1859017641475961132
  • Last Price Increase: 2024-11-19
  • Automatic offers:
    • rayane-djouah | Reviewer | 105008734
Issue OwnerCurrent Issue Owner: @trjExpensify
@tgolen tgolen added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 19, 2024
@tgolen tgolen self-assigned this Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@nkdengineer
Copy link
Contributor

nkdengineer commented Nov 19, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Update copy on the wallet settings page

What is the root cause of that problem?

This is an improvment

What changes do you think we should make in order to solve the problem?

Change this translation to Expense Wallet and

sendAndReceiveMoney: 'Send and receive money with friends',

change this to Send and receive money with friends.

walletEnabledToSendAndReceiveMoney: 'Your wallet has been enabled to send and receive money with friends.',

We also need to update the translation in es.ts file accordingly

What alternative solutions did you explore? (Optional)

@trjExpensify
Copy link
Contributor

@tgolen did you want to send this external? If so, I think we reduce the price quite considerably to say $50 for a small copy change.

@tgolen
Copy link
Contributor Author

tgolen commented Nov 19, 2024

I think a reduced price makes a lot of sense!

@trjExpensify trjExpensify changed the title Update copy on the wallet settings page [$50] Update copy on the wallet settings page Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@trjExpensify trjExpensify added the External Added to denote the issue can be worked on by a contributor label Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021859017641475961132

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 19, 2024
Copy link

melvin-bot bot commented Nov 19, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rayane-djouah (External)

@trjExpensify
Copy link
Contributor

@hungdannt
Copy link

hungdannt commented Nov 20, 2024

Contributor details
Your Expensify account email: caucahotran@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0199da86ff25cda0b3

Copy link

melvin-bot bot commented Nov 20, 2024

📣 @hungdannt! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@hunghinh2000
Copy link

Contributor details
Your Expensify account email: hunghinh2000vn@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01a2a6c6ca80bc50fa

Copy link

melvin-bot bot commented Nov 20, 2024

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@hunghinh2000
Copy link

Proposal

Please re-state the problem that we are trying to solve in this issue.

Users find it difficult to navigate the wallet settings page due to cluttered interface copy.

What is the root cause of that problem?

The current wallet section title and subtitle are overly verbose and redundant.

What changes do you think we should make in order to solve the problem?

Update translations in src/languages/en.ts:

walletPage: {
    sendAndReceiveMoney: 'Expensify Wallet', // Changed from "Send and receive money with friends"
    walletEnabledToSendAndReceiveMoney: 'Send and receive money with friends', // Changed from "Your wallet has been enabled to send and receive money with friends"
}

What alternative solutions did you explore? (Optional)

@prakashbask
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clean up some of the copy on the wallet settings page:

What is the root cause of that problem?

UX improvement suggestion to reduce interface clutter and improve customer engagement and retention

What changes do you think we should make in order to solve the problem?

  1. To change the title of the block from "Send and receive money with friends" to "Expensify Wallet", change title to use
    title={translate('walletPage.expensifyWallet')}. walletPage.expensifyWallet is already defined in the language translation files. The change will be done at

title={translate('walletPage.sendAndReceiveMoney')}

  1. To change the subtitle from "Your wallet has been enabled to send and receive money with friends." to "Send and receive money with friends.", change subtitle to use subtitle={translate('walletPage.sendAndReceiveMoney'')}. The conditional check of hasActivatedWallet to display text will be removed at the following location

subtitle={translate(`walletPage.${hasActivatedWallet ? 'walletEnabledToSendAndReceiveMoney' : 'enableWalletToSendAndReceiveMoney'}`)}

  1. Remove all language translations for enableWalletToSendAndReceiveMoney and walletEnabledToSendAndReceiveMoney at

enableWalletToSendAndReceiveMoney: 'Enable your wallet to send and receive money with friends.',

walletEnabledToSendAndReceiveMoney: 'Your wallet has been enabled to send and receive money with friends.',

enableWalletToSendAndReceiveMoney: 'Habilita tu Billetera Expensify para comenzar a enviar y recibir dinero con amigos.',

walletEnabledToSendAndReceiveMoney: 'Tu billetera ha sido habilitada para enviar y recibir dinero con amigos.',

End Result is
Screenshot 2024-11-20 at 8 01 24 PM

What alternative solutions did you explore? (Optional)

The current solution assumes that the title and subtitle for Wallet section remains the same in both activated and non-activated condition.
If we need to display different title and subtitle based on activated/non-activated check then following changes will be required
subtitle={translate(`walletPage.${hasActivatedWallet ? 'sendAndReceiveMoney' : 'enableWalletToSendAndReceiveMoney'}`)}
title={translate(`walletPage.${hasActivatedWallet ? 'expensifyWallet' : 'sendAndReceiveMoney'}`)}

@rayane-d
Copy link
Contributor

rayane-d commented Nov 20, 2024

@tgolen @trjExpensify - In the case where the wallet is not enabled, I think we need to update the title from Send and receive money with friends to Expensify Wallet and keep the current subtitle (Enable your wallet to send and receive money with friends.), right? Or should we change Enable your wallet to send and receive money with friends. to Send and receive money with friends?

Screenshot 2024-11-20 at 10 36 39 PM

@trjExpensify
Copy link
Contributor

Hm, I don't like changing the title personally. I would think we just have this in both pre/post-enablement states?

Expensify Wallet
Send and receive money with friends.

@rayane-d
Copy link
Contributor

Agreed, having this in both pre/post-enablement states makes sense for consistency. Thanks!

@rayane-d
Copy link
Contributor

@prakashbask's proposal looks good to me.

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Nov 20, 2024

Current assignee @tgolen is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 21, 2024
Copy link

melvin-bot bot commented Nov 21, 2024

📣 @rayane-djouah 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Nov 21, 2024

📣 @prakashbask You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

@prakashbask
Copy link
Contributor

I have applied to the job on Upwork and target to have the PR ready by 22-Nov

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Nov 22, 2024
@prakashbask
Copy link
Contributor

PR #52942

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Nov 28, 2024
@melvin-bot melvin-bot bot changed the title [$50] Update copy on the wallet settings page [HOLD for payment 2024-12-05] [$50] Update copy on the wallet settings page Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 28, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 28, 2024

@rayane-djouah @trjExpensify @rayane-djouah The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@rayane-d
Copy link
Contributor

BugZero Checklist:

  • Classify the bug:

    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: N/A

  • If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: N/A

  • If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again. I don’t believe a regression test is necessary, as this is just a copy update.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Dec 5, 2024
@trjExpensify
Copy link
Contributor

Agreed, small copy update.

Payment summary as follows:

@trjExpensify
Copy link
Contributor

Paid @prakashbask, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants