[$250] Track expense-In self DM, create expense is shown instead track expense

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.65-1
Reproducible in staging?: Y
Reproducible in production?: Y
Isuue was found when executing this PR: #52786
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Login with new gmail account
3. Open self DM
4. Tap plus icon next to chat input

Expected Result:

In self DM, track expense must be shown .

Actual Result:

In self DM, create expense is shown instead track expense.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6671460_1732161962885.Screenrecorder-2024-11-21-09-31-54-5.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021861530490609565618
• Upwork Job ID: 1861530490609565618
• Last Price Increase: 2024-12-10

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-11-21 13:15:52 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

In self DM, create expense is shown instead track expense.

What is the root cause of that problem?

We display Create expense if canUseCombinedTrackSubmit is true.

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 162 to 163 in 4617816

	icon: canUseCombinedTrackSubmit ? getIconForAction(CONST.IOU.TYPE.CREATE) : getIconForAction(CONST.IOU.TYPE.TRACK),
	text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

What changes do you think we should make in order to solve the problem?

I think we should display Track expense for all case in the plus icon of SelfDM

icon:  getIconForAction(CONST.IOU.TYPE.TRACK),
text: translate('iou.trackExpense'),

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 162 to 163 in 4617816

	icon: canUseCombinedTrackSubmit ? getIconForAction(CONST.IOU.TYPE.CREATE) : getIconForAction(CONST.IOU.TYPE.TRACK),
	text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

OPTIONAL: We can also change this to always display Track expense

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 58 in 4617816

[CONST.IOU.TYPE.TRACK]: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

@abekkala Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[abekkala]

confirmed in slack that it should be track

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021861530490609565618

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ahmedGaber93 (External)

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Track expense-In self DM, create expense is shown instead track expense

What is the root cause of that problem?

We set the menu item to create expense if canUseCombinedTrackSubmit permission is on for IOU.TYPE.TRACK here

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 161 to 163 in 70461d0

	[CONST.IOU.TYPE.TRACK]: {
	icon: canUseCombinedTrackSubmit ? getIconForAction(CONST.IOU.TYPE.CREATE) : getIconForAction(CONST.IOU.TYPE.TRACK),
	text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

and then we remove the duplicate create expense menu item here because for canUseCombinedTrackSubmit both track and submit are set to Create expense

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 177 to 180 in 70461d0

	return canUseCombinedTrackSubmit
	? // Removes track option for the workspace with the canUseCombinedTrackSubmit enabled
	moneyRequestOptionsList.filter((item, index, self) => index === self.findIndex((t) => t.text === item.text))
	: moneyRequestOptionsList;

and then we set the IOUStartPage title to create expense to similarly for canUseCombinedTrackSubmit case here

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 58 in 70461d0

[CONST.IOU.TYPE.TRACK]: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

What changes do you think we should make in order to solve the problem?

We need to set it to track for CONST.IOU.TYPE.TRACK whether or not canUseCombinedTrackSubmit is on

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 161 to 163 in 70461d0

	[CONST.IOU.TYPE.TRACK]: {
	icon: canUseCombinedTrackSubmit ? getIconForAction(CONST.IOU.TYPE.CREATE) : getIconForAction(CONST.IOU.TYPE.TRACK),
	text: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

[CONST.IOU.TYPE.TRACK]: {
                icon: getIconForAction(CONST.IOU.TYPE.TRACK),
                text: translate('iou.trackExpense'),
                onSelected: () => selectOption(() => IOU.startMoneyRequest(CONST.IOU.TYPE.TRACK, report?.reportID ?? '-1'), true),
            },

and update IOUStartPage title here

App/src/pages/iou/request/IOURequestStartPage.tsx

Line 58 in 70461d0

[CONST.IOU.TYPE.TRACK]: canUseCombinedTrackSubmit ? translate('iou.createExpense') : translate('iou.trackExpense'),

        [CONST.IOU.TYPE.TRACK]: translate('iou.trackExpense'),

then we also don't need the filter code here anymore

App/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx

Lines 177 to 180 in 70461d0

	return canUseCombinedTrackSubmit
	? // Removes track option for the workspace with the canUseCombinedTrackSubmit enabled
	moneyRequestOptionsList.filter((item, index, self) => index === self.findIndex((t) => t.text === item.text))
	: moneyRequestOptionsList;

        return moneyRequestOptionsList;

What alternative solutions did you explore? (Optional)

[ahmedGaber93]

reviewing today

[ahmedGaber93]

App/src/libs/Permissions.ts

Lines 32 to 36 in 10a7be8

	function canUseCombinedTrackSubmit(): boolean {
	// We don't need to show this to all betas since this will be used for developing a feature for A/B testing.
	const session = SessionUtils.getSession();
	return isAccountIDEven(session?.accountID ?? -1);
	}

According to the above comment, this is A/B testing feature, and "create expense" will display for even number account IDs. So I think this intended for A/B testing purpose and not an issue

[FitseTLT]

App/src/libs/Permissions.ts

Lines 32 to 36 in 10a7be8

	function canUseCombinedTrackSubmit(): boolean {
	// We don't need to show this to all betas since this will be used for developing a feature for A/B testing.
	const session = SessionUtils.getSession();
	return isAccountIDEven(session?.accountID ?? -1);
	}

According to the above comment, this is A/B testing feature, and "create expense" will display for even number account IDs. So I think this intended for A/B testing purpose and not an issue

This is not beta feature and it affects users in production with even numbered account ids and the problem here is showing create in place of track we only intended to replace submit with create so this is still a valid bug that affects users in production hence the slack confirmation here

cc @abekkala

[ahmedGaber93]

we only intended to replace submit with create

@FitseTLT The #49691 OP addressed the three actions that needed to replace with create, and the action track is one of them. See the Goal section.

[ahmedGaber93]

confirmed in slack that it should be track

@abekkala Just for confirmation, was it taken into consideration that this behavior is not a bug and that it is for A/B testing purpose, and you decide to disable A/B testing here?

More information here #49691 in OP Goal section.

[FitseTLT]

we only intended to replace submit with create

@FitseTLT The #49691 OP addressed the three actions that needed to replace with create, and the action track is one of them. See the Goal section.

I know @ahmedGaber93 but I think they have decided to exclude track now and only apply it to submit considering the slack confirmation. @grgia as you were the creator of the A/B testing issue do you confirm the eligibility of this issue and we should only replace submit with create and leave track as it is. I think @abekkala got a slack confirmation for it here

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@abekkala @ahmedGaber93 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[ahmedGaber93]

@abekkala bump #52897 (comment)

[abekkala]

@grgia since you're familiar with this can you confirm #52897 (comment)

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@abekkala, @ahmedGaber93 Eep! 4 days overdue now. Issues have feelings too...

[ahmedGaber93]

WDYT @grgia ^?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[ahmedGaber93]

Bumped @grgia on slack

[grgia]

Closing for #53656