[HOLD for payment 2025-01-17] Remove "enable your wallet" task from "Get paid back..." and "Chat and split expenses.." onboarding tasks

[danielrvidal]

Now that we have the two minute tour, we would like to remove the following tasks from the following flows:

• Remove "Enable your wallet" task from the Get paid back from my employer onboarding tasks
• Remove "Add personal bank account" from the Chat and split expenses with friends onboarding tasks.

Here is the Get paid back from my employer onboarding tasks:

Here are the current Chat and split expenses with friends onboarding tasks

Issue Owner

Current Issue Owner: @jjcoffee

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[NJ-2020]

Edited by proposal-police: This proposal was edited at 2024-11-22 19:43:21 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove "enable your wallet" task from "Get paid back..." and "Chat and split expenses.." onboarding tasks

What is the root cause of that problem?

Improvement

What changes do you think we should make in order to solve the problem?

Remove the task here

App/src/CONST.ts

Lines 129 to 132 in ef0d341

	type: 'addBankAccount',
	autoCompleted: false,
	title: 'Add personal bank account',
	description:

and here

App/src/CONST.ts

Lines 166 to 170 in ef0d341

	{
	type: 'addBankAccount',
	autoCompleted: false,
	title: 'Add personal bank account',
	description:

and here

App/src/CONST.ts

Lines 129 to 131 in ef0d341

	type: 'addBankAccount',
	autoCompleted: false,
	title: 'Add personal bank account',

We should fix in the BE as well

What alternative solutions did you explore? (Optional)

[NJ-2020]

Proposal Updated

• Minor update

[Kalydosos]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Remove "enable your wallet" task from "Get paid back..." and "Chat and split expenses.." onboarding tasks

What is the root cause of that problem?

Improvement needed

What changes do you think we should make in order to solve the problem?

1. "Enable your wallet" is already absent from the tasks of "Get paid back from my employer" onboarding menu. Nothing to do then
2. To remove "Add personal bank account" from the Chat and split expenses with friends onboarding tasks, we just need to remove here
   https://github.com/Expensify/App/blob/main/src/CONST.ts#L5102-L5116

no BE change needed

RESULT

What alternative solutions did you explore? (Optional)

None

[anmurali]

@jjcoffee - can you please review these proposals so we can move forward?

[jjcoffee]

I only see two tasks for Get paid back from my employer (on latest main), Submit an expense and Add personal bank account. There's no Take a 2-minute tour.

Could you confirm if we still need to make any changes to Get paid back from my employer? @anmurali or @danielrvidal

[NJ-2020]

@jjcoffee Regarding Take a 2-minute tour we have some issues here: #52908 #52985

[jjcoffee]

Thanks @NJ-2020! Looks like the fix has been CP'ed now, but there's still Add personal bank account instead of Enable your wallet.

I think you may have made a mistake in your proposal, with the third code block that needs updating (it repeats the first). Can you get that updated?

[jjcoffee]

Assuming the above doesn't change anything regarding what we want to do here, I'm happy to go with @NJ-2020's proposal, as he was first and the general thrust is correct (even if the third code block to update isn't quite right 😉).

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NJ-2020]

@jjcoffee Ohh, okay thank you, will update that on the PR

[Kalydosos]

@jjcoffee @NJ-2020 mentionned a need to fix the BE, which is not also correct imho

[NJ-2020]

Hi, regarding "Get paid back option" may I get the "Enable your wallet" task description please

App/src/CONST.ts

Lines 128 to 134 in bb4c89d

	{
	type: 'addBankAccount',
	autoCompleted: false,
	title: 'Add personal bank account',
	description:
	'You’ll need to add your personal bank account to get paid back. Don’t worry, it’s easy!\n' +
	'\n' +

cc: @danielrvidal @yuwenmemon

[danielrvidal]

Why do you need the description for that if we're removing it? I'm not sure I understand. I think we're remove the task and description.

[NJ-2020]

Ohh sorry about that, I though we need to replace the Add personal bank account with Enable your wallet based on this comment

[jjcoffee]

@NJ-2020 No, I just meant that the current behaviour was a bit different from the issue description. We haven't agreed to do anything about it. You can proceed with the PR just dealing with removing the tasks as described in the issue.

[NJ-2020]

PR ready

cc: @jjcoffee

[melvin-bot]

This issue has not been updated in over 15 days. @danielrvidal, @yuwenmemon, @jjcoffee, @NJ-2020 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[jjcoffee]

Reviewing the PR today!

[danielrvidal]

Awesome, thank you!

[NJ-2020]

Looks like @yuwenmemon is OOO, I think we can ask for another BZ team member for approving & merging this PR

cc: @jjcoffee

[jjcoffee]

I think @yuwenmemon is back on Monday, so it depends how urgent this is cc @danielrvidal

[yuwenmemon]

Merged it!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• remove 'Add personal bank account' task #53319

If no regressions arise, payment will be issued on 2025-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment through NewDot Manual Requests
• @NJ-2020 requires payment (Needs manual offer from BZ)

[jjcoffee]

No checklist required since this is a "feature". Not sure if a regression test is super necessary, but here it is just in case.

Regression Test Proposal

Test:

1. Sign in with a new account
2. Select the Chat and split expenses with friends option on the onboarding flow
3. Complete the onboarding steps
4. Verify that there is no 'Add personal bank account' task
5. Repeat the above, but select Get paid back by my employer and verify the same task is not there

Do we agree 👍 or 👎

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @johncschuster you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @jjcoffee owed $250 via NewDot
• ROLE: @NJ-2020 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@johncschuster)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[johncschuster]

@NJ-2020 I can't find your Upwork profile. Can you please post it here?

[johncschuster]

Payment Summary

Contributor: @NJ-2020 paid $250 via Upwork
Contributor+: @jjcoffee owed $250 via NewDot

Upwork Job - Please apply!

[NJ-2020]

@johncschuster Sure here's my Upwork profile: https://www.upwork.com/freelancers/~01ff73ff788ecf5f2e

[melvin-bot]

@danielrvidal, @yuwenmemon, @johncschuster, @jjcoffee, @NJ-2020 Huh... This is 4 days overdue. Who can take care of this?

[garrettmknight]

$250 approved for @jjcoffee

[johncschuster]

@NJ-2020 I've sent you an invite to the job. Can you accept that? I'll issue payment once you've done that. Thanks!

[NJ-2020]

Done, accepted

cc: @johncschuster