Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD App#51475] iOS - App crashing when using profiling tool #53061

Open
2 of 8 tasks
mountiny opened this issue Nov 25, 2024 · 6 comments
Open
2 of 8 tasks

[HOLD App#51475] iOS - App crashing when using profiling tool #53061

mountiny opened this issue Nov 25, 2024 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@mountiny
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @anmurali
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C05LX9D6E07/p1729174169091589

Action Performed:

Break down in numbered steps

  1. Turn on Use profiling toggle
  2. Go through the app. Switch between tabs, visit Search screen and scroll. You will crash sooner with the account that has more data.

Expected Result:

Describe what you think should've happened

The app behaviour should not change when the profiling is toggled on

Actual Result:

Describe what actually happened

The app crashes when the profiling is on

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 25, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@hannojg
Copy link
Contributor

hannojg commented Nov 25, 2024

Hey, Hanno from Margelo here who build the library for profiling. Feel free to assign to me ✌️

@zanyrenney
Copy link
Contributor

thank you @hannojg

@hannojg
Copy link
Contributor

hannojg commented Nov 27, 2024

Update: I am able to reproduce and working actively on it!

@hannojg
Copy link
Contributor

hannojg commented Nov 27, 2024

Under the assumption that this is a react-native/hermes problem (as the stack trace points directly to hermes, not our library) I tested the bug on the RN 0.76 PR where i am not able to reproduce the problem anymore:

CleanShot.2024-11-27.at.10.37.47.mp4

(On the main branch the app usually crashes instantly for me, but in the PR it seems fixed)

I would suggest to put this on hold for the mentioned PR.

(We could also make a new adhoc build from the mentioned PR (previous ones are too outdated) and then maybe @zanyrenney / @mountiny you could test the iOS adhoc build on your physical phone to verify that the problem is fixed in the PR?)

@mountiny mountiny changed the title iOS - App crashing when using profiling tool [HOLD App#51475] iOS - App crashing when using profiling tool Nov 28, 2024
@mountiny
Copy link
Contributor Author

Put it on hold, I cant test on physical device at the moment unfortunately

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
Development

No branches or pull requests

3 participants