Upgrade to React Native 0.76 #51475

j-piasecki · 2024-10-25T14:54:13Z

Details

This PR upgrades the version of React Native used in the App to 0.76.

Fixed Issues

$ #48911
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

IuliiaHerets · 2024-11-18T12:12:46Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Android - Taxes - Huge spacing between keyboard and Save button

Version Number: 9.0.61-0
Reproducible in staging?: N
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

Launch New Expensify app.
Go to workspace settings > Taxes.
Tap Add rate.
Tap Name.

Expected Result:

Save button will be above the keyboard without no massive space in between.

Actual Result:

Save button appears above the keyboard with massive space in between.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6668244_1731923713089.Screen_Recording_20241118_171934_Settings.mp4

View all open jobs on GitHub

IuliiaHerets · 2024-11-18T18:51:24Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Android - Expense - App crashes when exchanging expenses offline and returning online

Version Number: 9.0.61-0
Reproducible in staging?: N
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

User A and User B have never chatted before.

Go to staging.new.expensify.com
[User A (Android)] Go offline
[User A (Android)] Submit an expense to User B
[User B] While online. submit an expense of the same amount to User A
[User A (Android)] Go online while stay in main chat with User B.

Expected Result:

App will not crash when user A returns online and chat refreshes.

Actual Result:

App crashes when user A returns online and chat refreshes.

Workaround:

Unknown

Platforms:

Screenshots/Videos

1811_1.txt

Bug6668544_1731943777161.Screen_Recording_20241118_231656_New_Expensify_AdHoc.mp4

View all open jobs on GitHub

CyberAndrii · 2024-11-20T12:03:00Z

Hey @j-piasecki, I'm pretty sure we can remove changes made in #18837 as it was a workaround to an RN bug that got fixed a long time ago. This callback don't even run because uiManager.addUIBlock doesn't work on new arch anymore.

github-actions · 2024-11-28T08:05:11Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-28T08:32:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51475/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51475/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51475/NewExpensify.dmg	https://51475.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

github-actions · 2024-11-28T11:20:02Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-28T11:31:44Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Desktop build failed	The QR code can't be generated, because the web build failed

👀 View the workflow run that generated this build 👀

github-actions · 2024-11-30T09:53:02Z

🚧 @mountiny has triggered a test build. You can view the workflow run here.

github-actions · 2024-11-30T10:20:41Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/51475/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/51475/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/51475/NewExpensify.dmg	https://51475.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

WoLewicki and others added 16 commits October 21, 2024 17:32

feat: update patches for expo

44682c9

feat: bump to newest RN

ffae2d9

chore: update patch numbers

e520b04

feat: update expo

d4c742b

chore: merge current main

54586a7

fix: update patches and fix gradle build

9df77bf

Bump to stable 0.76 and expo preview 3

43696bd

Add patch for mapbox

91253f2

Fix headless tasks causing crash

49d1255

Merge branch 'main' into @wolewicki/rn-76-upgrade

55aa7d3

Fix Android build

d9ed4fa

Merge branch 'main' into @wolewicki/rn-76-upgrade

9e2ef24

Fix lint

7ca13d2

Fix mock

3d5d0af

Merge branch 'main' into @wolewicki/rn-76-upgrade

99ae53e

Build Github Actions

3086b54

mountiny added the Ready To Build label Oct 28, 2024

This comment has been minimized.

Sign in to view

WoLewicki and others added 12 commits October 28, 2024 17:57

fix: enable bridgeless again

5a8cdbc

Merge branch 'main' into @wolewicki/rn-76-upgrade

e5f32d7

Override regexpu-core version

af36d31

Fix ios build

30bf3a5

Move git tests to other directory

ece3d70

Fix middleware tests

926bde4

Merge process from Expo and NodeJS

7c3f55d

Restore previous configs

7e6d265

Fix types & eslint

7dfffdd

Transpile updated expo modules on web

4358c2e

Add patches for type imports

50be77f

Merge branch 'main' into @wolewicki/rn-76-upgrade

4df9f59

Fix mask persisting after recycling

fbd9354

j-piasecki added 6 commits November 19, 2024 09:59

Merge branch 'main' into @wolewicki/rn-76-upgrade

54c21aa

Update github actions

e05da30

Fix text input value not being set

afd9788

Merge branch 'main' into @wolewicki/rn-76-upgrade

0306598

Fix selection not applying in TextInput

6ebb122

Fix crash on emoji selection

ac87ce6

j-piasecki and others added 5 commits November 22, 2024 09:49

Fix text selection on change

9e0c2f2

Merge branch 'main' into @wolewicki/rn-76-upgrade

c847cd8

Fix workspace name screen not opening keyboard

7adc49a

feat: align with hybrid app

f237bd4

chore: run gh-actions-build

47f4a1c

hannojg mentioned this pull request Nov 27, 2024

[HOLD App#51475] iOS - App crashing when using profiling tool #53061

Open

8 tasks

j-piasecki added 2 commits November 27, 2024 11:19

Fix crash on editing message

267b866

Merge branch 'main' into @wolewicki/rn-76-upgrade

b1b1b8a

Merge branch 'main' into @wolewicki/rn-76-upgrade

f89ec5d

j-piasecki added 5 commits November 28, 2024 17:30

Fix SrollView jump on deleting an expense

e18e5ca

Update patches

be7a883

Merge branch 'main' into @wolewicki/rn-76-upgrade

79067dc

Fix metro

b8a658a

Fix crash on switch back to online

25bca0e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to React Native 0.76 #51475

Upgrade to React Native 0.76 #51475

j-piasecki commented Oct 25, 2024

This comment has been minimized.

IuliiaHerets commented Nov 18, 2024

IuliiaHerets commented Nov 18, 2024

CyberAndrii commented Nov 20, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 30, 2024

github-actions bot commented Nov 30, 2024

Upgrade to React Native 0.76 #51475

Are you sure you want to change the base?

Upgrade to React Native 0.76 #51475

Conversation

j-piasecki commented Oct 25, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

This comment has been minimized.

IuliiaHerets commented Nov 18, 2024

Android - Taxes - Huge spacing between keyboard and Save button

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

IuliiaHerets commented Nov 18, 2024

Android - Expense - App crashes when exchanging expenses offline and returning online

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

CyberAndrii commented Nov 20, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 28, 2024

github-actions bot commented Nov 30, 2024

github-actions bot commented Nov 30, 2024