-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-12-17] Display the Welcome Modal for migrated users as soon as they sign in to New Expensify #53085
Comments
@puneetlath 👋 Please assign me here |
@puneetlath Can you please provide assets for Main animation, the feature list icons |
cc @Expensify/design for above request ^ 🙇 |
I think the globe animation is this one: And then for the bullets we have:
|
Thank you @dannymcclain!!
this looks a bit different from what's in the mock, but works for now as placeholder until exact is found Screen.Recording.2024-11-27.at.10.08.18.PM.mov |
@Expensify/design when you all are back online, do you know if we have another version of the globe animation (and if so where) or if we just have the one? |
Pretty sure that's the only one we have as it's the same as the one we use for Workspaces empty space. Happy to use that one 👍 |
@puneetlath @Expensify/design I want to clarify asking cause the other training modal we have for example this one 👇 is dismissed when clicking on the background backdrop, Our current Generic modal component does not provide any abitlitly to not close when clicking on backdrop, before implementing a hotfix i want to confirm if this is strict requirement? |
The modal screenshotted above should be dismissible. When we talk about non-dismissible modals it's only the first sign up onboarding modals. So for the workspace creation modal we should allow it to be dismissed. |
I don't feel too strongly here, personally I would be fine allowing the user to escape/exit the modal by clicking on the background but I can see where we might want to strictly force the user to read the modal and confirm via the button. |
I'm fine with either—I think they both look good. Maybe we can pick one and standardize? Which do you prefer?
I agree, and would also be fine letting the user close via the background. I think the only time we should not allow that behavior is if we really need some input from the user in the modal (like the first sign up modal Jon mentioned). |
I don't feel super strongly really... The full-bleed looks super clean on desktop, though I can see where the borders are nice on mobile as the bottom-docked modal. Let's see what @dubielzyk-expensify thinks? |
Happy to go full-bleed. Nice to change things up a bit too :) |
Sweet, let's do it then! 🩸 |
🩸🩸🩸 |
@puneetlath, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@puneetlath Please assign me here |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-12-17. 🎊 For reference, here are some details about the assignees on this issue:
|
Part of the Migrate Existing Users to NewDot project
Main issue: https://github.com/Expensify/Expensify/issues/437980
Doc section: https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.1996ydl0cxy4
Project:
Feature Description
Display the Welcome modal for migrated users as soon as they sign in to New Expensify
Notes for completiness:
Follow implementation from https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.1996ydl0cxy4
The text was updated successfully, but these errors were encountered: