Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-12-17] Display the Welcome Modal for migrated users as soon as they sign in to New Expensify #53085

Open
ishpaul777 opened this issue Nov 25, 2024 · 20 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2

Comments

@ishpaul777
Copy link
Contributor

ishpaul777 commented Nov 25, 2024

Part of the Migrate Existing Users to NewDot project

Main issue: https://github.com/Expensify/Expensify/issues/437980
Doc section: https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.1996ydl0cxy4
Project:

Feature Description

Display the Welcome modal for migrated users as soon as they sign in to New Expensify

Web Mobile
Welcome modal desktop welcome modal mobile

Notes for completiness:

  • Welcome Modal that appears for migrated users on the new Expensify. This modal will be over any Search/report/account settings page depending on which they land.
  • The modal would read “Travel and expense at the speed of chat!”
  • Subheading: “New Expensify has the same great automation, but now with amazing collaboration:” With the following lines and associated icons
  • “Chat directly on any expense, report, or workspace”
  • “Scan receipts and get paid back”
  • “Do everything from your phone or browser”
  • With a confirmation button titled “Let’s go!”
  • Upon clicking “Let’s go!” the modal disappears
  • The user should not be able to click on any of the background UI whilst the modal is shown.

Follow implementation from https://docs.google.com/document/d/1m8e1ASwG70t651qSO6OfsSvW18RFrcWkO897iUllDLs/edit?tab=t.0#heading=h.1996ydl0cxy4

@ishpaul777 ishpaul777 changed the title Display the Welcome Modal for new/migrated users as soon as they sign in to New Expensify Display the Welcome Modal for migrated users as soon as they sign in to New Expensify Nov 25, 2024
@ishpaul777
Copy link
Contributor Author

@puneetlath 👋 Please assign me here

@ishpaul777
Copy link
Contributor Author

@puneetlath Can you please provide assets for Main animation, the feature list icons

Screenshot 2024-11-27 at 9 25 07 PM

@ishpaul777
Copy link
Contributor Author

cc @Expensify/design for above request ^ 🙇

@dannymcclain
Copy link
Contributor

I think the globe animation is this one: App/assets/animations/WorkspacePlanet.lottie
If it's not, I'm going to need some help tracking it down.

And then for the bullets we have:

@ishpaul777
Copy link
Contributor Author

Thank you @dannymcclain!!

I think the globe animation is this one: App/assets/animations/WorkspacePlanet.lottie

this looks a bit different from what's in the mock, but works for now as placeholder until exact is found

Screen.Recording.2024-11-27.at.10.08.18.PM.mov

@dannymcclain
Copy link
Contributor

@Expensify/design when you all are back online, do you know if we have another version of the globe animation (and if so where) or if we just have the one?

@dubielzyk-expensify
Copy link
Contributor

Pretty sure that's the only one we have as it's the same as the one we use for Workspaces empty space. Happy to use that one 👍

@ishpaul777
Copy link
Contributor Author

ishpaul777 commented Nov 28, 2024

The user should not be able to click on any of the background UI whilst the modal is shown.

@puneetlath @Expensify/design I want to clarify asking cause the other training modal we have for example this one 👇 is dismissed when clicking on the background backdrop, Our current Generic modal component does not provide any abitlitly to not close when clicking on backdrop, before implementing a hotfix i want to confirm if this is strict requirement?

Screenshot 2024-11-28 at 5 44 58 PM

@dubielzyk-expensify
Copy link
Contributor

The modal screenshotted above should be dismissible. When we talk about non-dismissible modals it's only the first sign up onboarding modals.

So for the workspace creation modal we should allow it to be dismissed.

@melvin-bot melvin-bot bot added Monthly KSv2 Reviewing Has a PR in review Weekly KSv2 and removed Monthly KSv2 labels Nov 29, 2024
@flaviadefaria flaviadefaria added Daily KSv2 and removed Weekly KSv2 labels Dec 2, 2024
@shawnborton
Copy link
Contributor

I think we just have one version of the rotating planet/workspace items.

Small thing though - should we make the image area of the modal go full bleed to the edges? I guess we have both styles across the app, so just curious when we should use one vs the other. For example, this is the full bleed style I was thinking of:
image

@shawnborton
Copy link
Contributor

Our current Generic modal component does not provide any abitlitly to not close when clicking on backdrop, before implementing a hotfix i want to confirm if this is strict requirement?

I don't feel too strongly here, personally I would be fine allowing the user to escape/exit the modal by clicking on the background but I can see where we might want to strictly force the user to read the modal and confirm via the button.

@dannymcclain
Copy link
Contributor

should we make the image area of the modal go full bleed to the edges? I guess we have both styles across the app, so just curious when we should use one vs the other

I'm fine with either—I think they both look good. Maybe we can pick one and standardize? Which do you prefer?

personally I would be fine allowing the user to escape/exit the modal by clicking on the background

I agree, and would also be fine letting the user close via the background. I think the only time we should not allow that behavior is if we really need some input from the user in the modal (like the first sign up modal Jon mentioned).

@shawnborton
Copy link
Contributor

I don't feel super strongly really... The full-bleed looks super clean on desktop, though I can see where the borders are nice on mobile as the bottom-docked modal. Let's see what @dubielzyk-expensify thinks?

@dubielzyk-expensify
Copy link
Contributor

I don't feel super strongly really... The full-bleed looks super clean on desktop, though I can see where the borders are nice on mobile as the bottom-docked modal. Let's see what @dubielzyk-expensify thinks?

Happy to go full-bleed. Nice to change things up a bit too :)

@shawnborton
Copy link
Contributor

Sweet, let's do it then! 🩸

@dannymcclain
Copy link
Contributor

🩸🩸🩸

Copy link

melvin-bot bot commented Dec 10, 2024

@puneetlath, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@rayane-djouah
Copy link
Contributor

@puneetlath Please assign me here

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Dec 10, 2024
@melvin-bot melvin-bot bot changed the title Display the Welcome Modal for migrated users as soon as they sign in to New Expensify [HOLD for payment 2024-12-17] Display the Welcome Modal for migrated users as soon as they sign in to New Expensify Dec 10, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 10, 2024
Copy link

melvin-bot bot commented Dec 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-12-17. 🎊

For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2
Projects
Status: First Cohort - CRITICAL
Development

No branches or pull requests

7 participants