-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated user welcome modal #53225
Migrated user welcome modal #53225
Conversation
…ate animation handling in MigratedUserWelcomeModal
@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Let us know when this is ready for a design review. |
@rayane-djouah Can you give this a initial review from code side of things, i'll ask and update the translation shortly |
…ps to FeatureTrainingModal
gentle bump @rayane-djouah |
@Expensify/design This open for your review as well, i have updated latest screenshots in PR author checklist. |
We've recently made some changes and are now going to make these illustrations modals into full bleed removing the padding, like so: Sorry for the last minute change, but could you implement those changes as well 😇 THANK YOU! cc @Expensify/design team |
Also, could we tweak the spacing between the text a bit more to the mock? Or better yet, replicate the spacing/component from this PR |
I have made these changes already.
I'll make the spacing changes shortly |
Looks pretty good to me. @dubielzyk-expensify @dannymcclain curious what you think - on the desktop version, should we use the 32px padding for the text/icon/button area? We do have some more width to play with there... |
Can you check if same is happening for other existing page using this modal component @rayane-djouah
|
Yes, same is happening for other existing page using this modal component: |
This is reproduced on the main branch, so it is not related to this PR. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well 👍
@ishpaul777 do we need to make this |
Translation confirmed here https://expensify.slack.com/archives/C01GTK53T8Q/p1733172034138099 |
This can be tested actuallly BUT partially |
@rayane-djouah Would you like to review #53396? it is branched out from this branch, since you got context it should be easier for you to start? Please comment there if you want to review |
Reported the bug here: https://expensify.slack.com/archives/C049HHMV9SM/p1733518294921299 |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.73-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.73-8 🚀
|
Explanation of Change
Fixed Issues
$ #53085
PROPOSAL:
Tests
src/hooks/useOnboardingFlow.ts
Or (For QA)
open app and Go to settings Troublshoot > enable Client side logging, then click on "View debug console" execute below command
Click on "Lets's go button" verify it close the modal
Reload window/ close and Reopen the App, Verify Modal not opens
Offline tests
QA Steps
Same as test steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-11-29.at.12.07.20.AM.mov
Android: mWeb Chrome
Screen.Recording.2024-11-29.at.12.35.57.AM.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.-.2024-11-28.at.22.14.32.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.-.2024-11-28.at.22.27.31.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-11-28.at.10.16.18.PM.mov
MacOS: Desktop
Screen.Recording.2024-11-29.at.12.32.57.AM.mov