Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Text cropped and unable to scroll the troubleshoot page #53092

Open
2 of 8 tasks
m-natarajan opened this issue Nov 25, 2024 · 18 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Nov 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.66-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @iwiznia
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

Prerequisite: in Android settings font size is set to the 3rd smallest one and display size to the 2nd

  1. Open troubleshoot page from settings

Expected Result:

Text not cropped and page scrollable

Actual Result:

Test cropped and page not scrollable

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

image (4)

1000008528.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021864106072895192898
  • Upwork Job ID: 1864106072895192898
  • Last Price Increase: 2024-12-11
  • Automatic offers:
    • mkzie2 | Contributor | 105293074
Issue OwnerCurrent Issue Owner: @rushatgabhane
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 25, 2024
Copy link

melvin-bot bot commented Nov 25, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mkzie2
Copy link
Contributor

mkzie2 commented Nov 25, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Test cropped and page not scrollable

What is the root cause of that problem?

We limit the height of the TestToolRow to be 64:

App/src/styles/index.ts

Lines 613 to 619 in 3d9c90a

testRowContainer: {
...flex.flexRow,
...flex.justifyContentBetween,
...flex.alignItemsCenter,
...sizing.mnw120,
height: 64,
},

What changes do you think we should make in order to solve the problem?

Update to minHeight: 64.

@melvin-bot melvin-bot bot added the Overdue label Nov 28, 2024
Copy link

melvin-bot bot commented Nov 29, 2024

@stephanieelliott Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Dec 3, 2024

@stephanieelliott 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@stephanieelliott
Copy link
Contributor

Confirmed the issue is still happening, seems like a straightforward fix so applying labels

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2024
@stephanieelliott stephanieelliott added External Added to denote the issue can be worked on by a contributor Overdue labels Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021864106072895192898

@melvin-bot melvin-bot bot changed the title Android - Text cropped and unable to scroll the troubleshoot page [$250] Android - Text cropped and unable to scroll the troubleshoot page Dec 4, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 4, 2024
Copy link

melvin-bot bot commented Dec 4, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

@stephanieelliott
Copy link
Contributor

Hey @rushatgabhane we have a proposal here for review, can you take a look when you get a sec?

@melvin-bot melvin-bot bot added the Overdue label Dec 6, 2024
Copy link

melvin-bot bot commented Dec 9, 2024

@rushatgabhane @stephanieelliott this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Dec 9, 2024

@rushatgabhane, @stephanieelliott Huh... This is 4 days overdue. Who can take care of this?

@stephanieelliott
Copy link
Contributor

Hey @rushatgabhane we have a proposal here for review, can you take a look when you get a sec?

Bump @rushatgabhane, can you review please?

@stephanieelliott
Copy link
Contributor

Hey @rushatgabhane do you still want to work on this one? Will post for a new C+ tomorrow if we still haven't heard from you.

@rushatgabhane
Copy link
Member

#53092 (comment)

@mkzie2 's proposal LGTM 🎀👀🎀

Copy link

melvin-bot bot commented Dec 11, 2024

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link

melvin-bot bot commented Dec 11, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 11, 2024
Copy link

melvin-bot bot commented Dec 11, 2024

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Dec 16, 2024
@mkzie2
Copy link
Contributor

mkzie2 commented Dec 16, 2024

@rushatgabhane The PR is ready.

@maddylewis maddylewis moved this to Product (CRITICAL) in [#whatsnext] #retain Dec 16, 2024
@stephanieelliott
Copy link
Contributor

Hey @rushatgabhane this is high priority on the #retain project -- any way you could review this PR for us today? 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
Status: Product (CRITICAL)
Development

No branches or pull requests

5 participants