[HOLD for payment 2024-12-19] [$250] Can't click Pay buttons when the edit composer is focused

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.66-7
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @DylanDylann
Slack conversation (hyperlinked to channel name): ts_external_expensify_bugs

Action Performed:

1. Go to any chat that waiting for you to pay
2. Focus on main composer
3. Click to dropdown button or pay button
4. See that the action happen
5. Click edit any message to display edit composer
6. Click to dropdown button or pay button

Expected Result:

Click buttons should work normally

Actual Result:

Can't click buttons when the edit composer is focused

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2024-11-26.at.10.25.56.mov

Edit.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021862984432318114296
• Upwork Job ID: 1862984432318114296
• Last Price Increase: 2024-11-30
• Automatic offers:
• DylanDylann | Reviewer | 105207759

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

@DylanDylann discovered this bug while reviewing #51172

[DylanDylann]

I have more context with focus input while working on #51172. Could I take over this issue as C+ if it is external

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the pay button does nothing when the edit composer is focused and a keyboard is shown.

What is the root cause of that problem?

The root cause is the same as this old issue. When we press the pay button, the edit composer is blurred which triggers the main composer visibility, moving the view up, so the press event isn't caught by the button.

App/src/pages/home/report/ReportActionItemMessageEdit.tsx

Lines 546 to 553 in c4ff235

	onBlur={(event: NativeSyntheticEvent<TextInputFocusEventData>) => {
	setIsFocused(false);
	const relatedTargetId = event.nativeEvent?.relatedTarget?.id;
	if (relatedTargetId === CONST.COMPOSER.NATIVE_ID || relatedTargetId === CONST.EMOJI_PICKER_BUTTON_NATIVE_ID || EmojiPickerAction.isEmojiPickerVisible()) {
	return;
	}
	setShouldShowComposeInputKeyboardAware(true);
	}}

What changes do you think we should make in order to solve the problem?

We have a few options.

First, we can follow the same approach as #12715, that is by adding

onMouseDown={e => e.preventDefault()}

for the button. However, we need to apply this to all buttons/pressable in the chat list, including the reply text, etc.

The other solution is to delay showing the main composer.

App/src/libs/setShouldShowComposeInputKeyboardAware/index.android.ts

Line 3 in c4ff235

export default setShouldShowComposeInputKeyboardAwareBuilder('keyboardDidHide');

setShouldShowComposeInputKeyboardAware for android & iOS, only shows the main composer after the keyboard hide, but web doesn't have the same thing. So, we can apply a 0 timeout for web only.

App/src/libs/setShouldShowComposeInputKeyboardAware/index.ts

Lines 4 to 6 in c4ff235

	const setShouldShowComposeInputKeyboardAware: SetShouldShowComposeInputKeyboardAware = (shouldShow) => {
	Composer.setShouldShowComposeInput(shouldShow);
	};

const setShouldShowComposeInputKeyboardAware: SetShouldShowComposeInputKeyboardAware = (shouldShow) => {
    setTimeout(() => {
        Composer.setShouldShowComposeInput(shouldShow);
    }, 0);
};

or we can delay it using interaction manager and requestAnimationFrame.

App/src/pages/home/report/ReportActionItemMessageEdit.tsx

Lines 529 to 533 in c4ff235

	InteractionManager.runAfterInteractions(() => {
	requestAnimationFrame(() => {
	reportScrollManager.scrollToIndex(index, true);
	});
	});

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021862984432318114296

[melvin-bot]

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

[adelekennedy]

@DylanDylann one proposal to review!

[DylanDylann]

@bernhardoj Could you explain why your first solution will solve this bug?

[bernhardoj]

With the first solution, if we apply the prevent default on many pressable elements, pressing that element won't blur the edit composer, thus the main composer won't show and push the content above. I prefer the other solution though to use 0 timeout. This would make it closer to the native which waits for the keyboard to hide.

[DylanDylann]

@bernhardoj

The root cause is the same as this old #12715. When we press the pay button, the edit composer is blurred which triggers the main composer visibility, moving the view up, so the press event isn't caught by the button.

As your explaination, when we click on the button, the keyboard is hidden and the position of the button is changed. If it is correct, why this bug doesn't happen on the main composer

[bernhardoj]

I think it's just because for edit composer case, the edit composer moves the view instantly, so the mouse up isn't received anymore by the pressable which receives the first mouse down event. The press happens if the element receives both mouse down and up. You can try attaching onMouseDown and onMouseUp to the element (pay button or any else) and see it only receives the mouse down event.

[DylanDylann]

I think it's just because for edit composer case, the edit composer moves the view instantly,

I mean that we need to clarify why there are differences between edit composer and main composer

[DylanDylann]

The second solution looks fine but I want to make clear RCA to make sure that your fix is correct and doesn't cause any regression

[bernhardoj]

I mean that we need to clarify why there are differences between edit composer and main composer

This is the difference

When we press the pay button, the edit composer is blurred which triggers the main composer visibility

[DylanDylann]

@bernhardoj's proposal looks good to me. Let's use setTimeout 0

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[bernhardoj]

PR is ready

cc: @DylanDylann

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.74-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix can't press pay button if edit composer is focused #53680

If no regressions arise, payment will be issued on 2024-12-19. 🎊

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment through NewDot Manual Requests
• @DylanDylann requires payment automatic offer (Reviewer)
• @DylanDylann requires payment automatic offer (Reviewer)

[melvin-bot]

@DylanDylann @adelekennedy @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[adelekennedy]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[adelekennedy]

@DylanDylann for the checklist above!

[adelekennedy]

Contributor: @bernhardoj paid $250 via NewDot
Contributor+: @DylanDylann owed $250 via Upwork

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$250 approved for @bernhardoj

[DylanDylann]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: It was missed from long time ago so It is hard to determine exactly what PR caused this problem

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Test:

1. Open any chat with an unsettled expense
2. Send a message and choose edit from the context menu
3. Press on the pay button of the expense/report preview
4. Verify the press is executed

Do we agree 👍 or 👎

[melvin-bot]

@Beamanator, @bernhardoj, @adelekennedy, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

created issue!