[HOLD 53493] [$250] iOS - Attachment - No sliding in animation when opening attachment

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.69-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Email or phone of affected tester (no customers): applausetester+zm63@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch ND or hybrid app.
2. Go to DM.
3. Tap on the chat header.
4. Tap on the user avatar.
5. Note that there is no sliding in animation when opening avatar.
6. Submit an expense with a receipt.
7. Send an image to the chat.
8. Open the receipt from the expense.
9. Open the image attachment.

Expected Result:

There will be sliding in animation when opening attachment (production behavior).

Actual Result:

There is no sliding in animation when opening attachment. The app blinks slightly when the attachment is opened.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6681230_1733064232646.ScreenRecording_12-01-2024_22-40-56_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021863486574634374199
• Upwork Job ID: 1863486574634374199
• Last Price Increase: 2024-12-02
• Automatic offers:
• ikevin127 | Reviewer | 105182252

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

Thai must be coming from the native stack change

@chrispader @hannojg @kirillzyusko for eyes

I dont think this is a blocker as users can open and view the attachment fine, teated on ios too

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021863486574634374199

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[Christinadobrzyn]

Catching up here - I think we're waiting on proposals, is that right @ikevin127?

[ikevin127]

Yes, unless somebody from our expert agencies wants to handle this - we're open for proposals based on the context mentioned in #53362 (comment).

[mountiny]

Margelo will handle this one

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.73-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: ProfileAvatar (modal) page has no slide in animation #53475

If no regressions arise, payment will be issued on 2024-12-17. 🎊

For reference, here are some details about the assignees on this issue:

• @chrispader does not require payment (Contractor)
• @ikevin127 requires payment automatic offer (Reviewer)

[melvin-bot]

@ikevin127 @Christinadobrzyn @ikevin127 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[Christinadobrzyn]

Looks like we're ready for payment but I don't see anything about a regression test.

@ikevin127 do we need a regression test for this?

Contributor+: @ikevin127  owed $250 via Upwork (https://www.upwork.com/nx/wm/offer/105182252)

[ikevin127]

PR was reverted as it had 2 regressions, we're probably looking at a re-work. No compensation required since the PR was reverted.

@Christinadobrzyn No payment required here as the PR was reverted. Not sure where we are with the issue, maybe @chrispader has more context on what happened after the revert regarding the issue.

[Christinadobrzyn]

Ah thank you @ikevin127 - really appreciate the clarity. @chrispader can you let us know your thoughts on next steps?

[melvin-bot]

@chrispader, @mountiny, @Christinadobrzyn, @ikevin127 Huh... This is 4 days overdue. Who can take care of this?

[mountiny]

I think this still has to be handled, gonna make it weekly over the holidays

[chrispader]

This issue would get fixed by #53493, so i'm going to further push forward the modal migration solution

[melvin-bot]

@chrispader @mountiny @Christinadobrzyn @ikevin127 this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[Christinadobrzyn]

Thanks for the update @chrispader! We'll add a HOLD to this and monitor - #53493

(or let me know if there's a better course of action). TY!

[Christinadobrzyn]

hold for #53493

[Christinadobrzyn]

hold for #53493