[Due for payment 2025-02-19] [$250] Track - Amount on the expense preview does not update when track distance expense is submitted

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: #51517
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Distance rates are enabled.
• Workspace distance unit (miles) is different from individual distance unit (kilometers).

1. Go to staging.new.expensify.com
2. Go to self DM.
3. Track a distance expense.
4. Click Share it with my accountant.
5. Select the workspace.
6. Click Rate.
7. Select any rate.
8. Click Submit.
9. Note the amount on the expense preview in the main chat.
10. Click on the expense preview.
11. Go back to main chat.

Expected Result:

In Step 9, the amount on the expense preview should be the correct amount after the expense is created.

Actual Result:

In Step 9, the amount on the expense preview shows the old amount which is when a different rate is used in the track expense.
The amount only updates after refreshing the page (Step 11).

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6691743_1733973744772.20241212_110709.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021867155469395187403
• Upwork Job ID: 1867155469395187403
• Last Price Increase: 2024-12-12
• Automatic offers:
• paultsimura | Contributor | 105304884

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Different behavior in production

Screen.Recording.2024-12-12.at.11.00.13.AM.mov

[Pujan92]

This is known issue and will be handled separately. Ref

cc: @paultsimura

[MariaHCD]

Thanks, @Pujan92 !

@paultsimura @neil-marcellini would you both be able to take over this issue since it is a follow up from #51517 (review)

[paultsimura]

would you both be able to take over this issue since it is a follow up from #51517 (review)

Yes, I'll start investigating the fix today.
Also IMO, it shouldn't be a blocker. This comment says the prod behavior is different, but it's only different because in prod the flow fails eventually – you can see the RBR appears after sharing the expense.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021867155469395187403

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

This issue has not been updated in over 15 days. @strepanier03, @MariaHCD, @paultsimura, @Pujan92 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[MariaHCD]

Looks like the original PR was reverted: #51517

@paultsimura What's the plan of action here? :)

[paultsimura]

Let's hold for #54669

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Handle distance unit update when sharing #54048

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)
• @Pujan92 requires payment through NewDot Manual Requests

[melvin-bot]

@paultsimura / @Pujan92 @strepanier03 @paultsimura / @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[paultsimura]

Heads up @Pujan92 - it's checklist time 🙋

[strepanier03]

Payment Summary

• @paultsimura requires payment automatic offer (Contributor)
• @Pujan92 requires payment through NewDot Manual Requests

[Pujan92]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/38543/files#r1964254896

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

1. Go to self DM.
2. Track a distance expense.
3. Click "Share it with my accountant".
4. Select the workspace.
5. Verify the Distance field shows "kilometers".
6. Click "Rate".
7. Select any rate with Miles as a unit.
8. Verify the Distance field shows "miles" with a value converted from km to mi.
9. Verify the amount was corrected as well.
10. Click Submit.
11. Verify the amount on the expense preview in the main chat shows the same value as in step 9

[strepanier03]

@Pujan92 - The payment summary is here and I removed the hold language from it now that the reg test is submitted. Feel free to put in your payment request. I'm going to close this GH.