[HOLD] Search - For held expense, Submit button is gray in Search, and green in workspace chat

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.75-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1311020@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

Precondition:

• Scheduled submit is disabled on Old Dot.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense to the workspace chat.
4. Note that Submit button is green.
5. Go to Search.
6. Note that Submit buton is also green.
7. Go back to workspace chat.
8. Go to transaction thread.
9. Click on the report header > Hold > Hold the expense.
10. Note that Submit button is still green in the workspace chat.
11. Go to Search.

Expected Result:

Submit button in Search should remain green because the same button is green in workspace chat when the expense is held.

Actual Result:

For held expense, Submit button is gray in Search, and green in workspace chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6691789_1733979933656.20241212_125723.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Production behavior

bandicam.2024-12-12.07-20-32-302.mp4

[MonilBhavsar]

Minor design issue. Not a blocker
@luacmartins @ishpaul777 looks like it is coming from #53641

[luacmartins]

Hmm I'm not sure if that's coming from that PR. The Search behavior seems correct to me, the button should be gray when there's a held transaction. I can take a look at this one

[luacmartins]

BTW we're gonna revert how we're handling grey/green buttons in App. So this should be on hold for now

[jliexpensify]

@luacmartins should we change the priority, or keep it as a Daily?

I'm also OOO from the 19th - 29th, but I don't think there will be anything for me to action, right?

[luacmartins]

I think we can close this in favor of #54054