Add submit action #53641

luacmartins · 2024-12-05T17:38:10Z

Explanation of Change

Adds the submit action to inline search items

Fixed Issues

$ #53640

Tests

Create a workspace
Enable workflows and Delay submissions
Submit an expense to the workspace
Navigate to the Search page
Verify that you see the submit button next to the expense
Press submit
Verify that the report is submitted

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2024-12-06.at.1.55.21.PM.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-12-06T20:56:18Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-12-06T20:56:25Z

@DylanDylann @ One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-12-06T20:59:16Z

@luacmartins does this require c+ review ?

ishpaul777 · 2024-12-06T21:05:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

luacmartins · 2024-12-06T21:07:50Z

Yes, we're still waiting on some backend PRs that add the additional policy keys though. So you might see some weird behaviour when we try to get the managerID to submit the report to.

ishpaul777 · 2024-12-06T21:54:33Z

For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.

@luacmartins Can you please add unit tests?

lakchote

Left one NAB comment, otherwise looks good!

src/libs/actions/Search.ts

luacmartins · 2024-12-10T00:20:33Z

BE PR is still in review. I'll let you know once it's deployed

luacmartins · 2024-12-11T17:01:36Z

@ishpaul777 BE PR is deployed

ishpaul777 · 2024-12-11T19:19:29Z

i am on it!

ishpaul777 · 2024-12-11T19:53:27Z

bug: Employee expense submitted by owner submits the expense but submit button still appears

Screen.Recording.2024-12-12.at.1.21.15.AM.mov

@luacmartins

ishpaul777 · 2024-12-11T20:32:37Z

Screenshots/Videos

Android: Native

Record_2024-12-12-01-55-35.mp4

Android: mWeb Chrome

Record_2024-12-12-02-05-06.mp4

iOS: Native

Screen.Recording.2024-12-12.at.1.28.27.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-12-12.at.1.30.35.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-12.at.1.15.08.AM.mov

MacOS: Desktop

Screen.Recording.2024-12-12.at.1.37.37.AM.mov

luacmartins · 2024-12-11T20:33:38Z

Looking

luacmartins · 2024-12-11T20:38:56Z

Hmm that response doesn't have any report_ key update.

luacmartins · 2024-12-11T20:46:41Z

Interesting thing is that I see it updating for the employee

luacmartins · 2024-12-11T21:47:21Z

Weird, I see that we're queuing those report updates in the API, but for some reason the response we're getting is completely different. Investigating.

luacmartins · 2024-12-11T22:15:19Z

@ishpaul777 I think the issue is in the backend. Let's continue with review here

ishpaul777

LGTM!

melvin-bot · 2024-12-11T22:17:20Z

@blimpich Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-12-11T22:18:35Z

Rest seems to be working well!

luacmartins · 2024-12-11T22:38:03Z

Yea, the issue is in the backend. I'm not sure how to solve it yet, but I don't think we need to block this PR on it.

luacmartins · 2024-12-11T23:07:35Z

I have a BE PR to address the admin force submit issue

blimpich

LGTM

OSBotify · 2024-12-12T00:03:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-12T01:59:05Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2024-12-13T15:41:10Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.75-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

create canSubmitReport

5933ec6

luacmartins self-assigned this Dec 5, 2024

luacmartins added 12 commits December 5, 2024 16:20

update logic

5ffa4e9

add comment

3e643f5

rm violations code

76684ab

add api command

179b791

add bulk action

868e49f

update icon

e261b17

rm violations code

8b67398

temporarily call submitreport

e32daf1

rm unused API command

31a198d

add comment

63bf8a1

rm unused const

e13a21b

rm more bulk action code

0b303fb

luacmartins marked this pull request as ready for review December 6, 2024 20:56

luacmartins requested a review from a team as a code owner December 6, 2024 20:56

melvin-bot bot requested review from ishpaul777 and removed request for a team December 6, 2024 20:56

luacmartins requested review from lakchote and a team December 6, 2024 20:56

melvin-bot bot requested review from DylanDylann and removed request for a team December 6, 2024 20:56

luacmartins removed the request for review from DylanDylann December 6, 2024 21:04

lakchote reviewed Dec 9, 2024

View reviewed changes

src/libs/actions/Search.ts Outdated Show resolved Hide resolved

luacmartins added 2 commits December 10, 2024 13:19

Merge branch 'main' into cmartins-addSubmitAction

7c5e24e

fix ts

88caced

ishpaul777 approved these changes Dec 11, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich December 11, 2024 22:17

blimpich approved these changes Dec 11, 2024

View reviewed changes

luacmartins merged commit 1584baf into main Dec 11, 2024
16 of 17 checks passed

luacmartins deleted the cmartins-addSubmitAction branch December 11, 2024 23:53

github-actions bot mentioned this pull request Dec 12, 2024

Deploy Checklist: New Expensify 2024-12-12 #53978

Closed

55 tasks

mountiny mentioned this pull request Dec 12, 2024

[HOLD for payment 2024-12-25] [HOLD for payment 2024-12-20] [$250] Search - Individual expenses displays "Submit"/"Approve" button when the expenses are grouped #53986

Closed

8 tasks

MonilBhavsar mentioned this pull request Dec 12, 2024

[HOLD] Search - For held expense, Submit button is gray in Search, and green in workspace chat #53990

Closed

8 tasks

mountiny mentioned this pull request Dec 12, 2024

Revert "Add submit action" #54010

Closed

melvin-bot bot mentioned this pull request Dec 13, 2024

[HOLD for payment 2024-12-20] Add inline Submit action to Search #53640

Closed

luacmartins mentioned this pull request Jan 7, 2025

[HOLD for payment 2025-01-28] [Search v1.2] Add violations to inline submit actions #54910

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add submit action #53641

Add submit action #53641

luacmartins commented Dec 5, 2024 •

edited

Loading

melvin-bot bot commented Dec 6, 2024

melvin-bot bot commented Dec 6, 2024

ishpaul777 commented Dec 6, 2024

ishpaul777 commented Dec 6, 2024 •

edited

Loading

luacmartins commented Dec 6, 2024

ishpaul777 commented Dec 6, 2024

lakchote left a comment

luacmartins commented Dec 10, 2024

luacmartins commented Dec 11, 2024

ishpaul777 commented Dec 11, 2024

ishpaul777 commented Dec 11, 2024

ishpaul777 commented Dec 11, 2024 •

edited

Loading

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024

ishpaul777 left a comment

melvin-bot bot commented Dec 11, 2024

ishpaul777 commented Dec 11, 2024 •

edited

Loading

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024 •

edited

Loading

blimpich left a comment

OSBotify commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

github-actions bot commented Dec 13, 2024

Add submit action #53641

Add submit action #53641

Conversation

luacmartins commented Dec 5, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 6, 2024

melvin-bot bot commented Dec 6, 2024

ishpaul777 commented Dec 6, 2024

ishpaul777 commented Dec 6, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

luacmartins commented Dec 6, 2024

ishpaul777 commented Dec 6, 2024

lakchote left a comment

Choose a reason for hiding this comment

luacmartins commented Dec 10, 2024

luacmartins commented Dec 11, 2024

ishpaul777 commented Dec 11, 2024

ishpaul777 commented Dec 11, 2024

ishpaul777 commented Dec 11, 2024 • edited Loading

Screenshots/Videos

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024

ishpaul777 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Dec 11, 2024

ishpaul777 commented Dec 11, 2024 • edited Loading

luacmartins commented Dec 11, 2024

luacmartins commented Dec 11, 2024 • edited Loading

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 12, 2024

github-actions bot commented Dec 12, 2024

github-actions bot commented Dec 13, 2024

luacmartins commented Dec 5, 2024 •

edited

Loading

ishpaul777 commented Dec 6, 2024 •

edited

Loading

ishpaul777 commented Dec 11, 2024 •

edited

Loading

ishpaul777 commented Dec 11, 2024 •

edited

Loading

luacmartins commented Dec 11, 2024 •

edited

Loading