Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-28] [Search v1.2] Add violations to inline submit actions #54910

Closed
luacmartins opened this issue Jan 7, 2025 · 9 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Jan 7, 2025

We added the Submit action to Search in this PR, but we did so without accounting for violations. Now that violations are available in Search, we should update the logic so it's consistent with other places in App.

Issue OwnerCurrent Issue Owner: @hungvu193
@luacmartins luacmartins added the Daily KSv2 label Jan 7, 2025
@luacmartins luacmartins self-assigned this Jan 7, 2025
@luacmartins luacmartins added Monthly KSv2 and removed Daily KSv2 Monthly KSv2 labels Jan 7, 2025
@luacmartins luacmartins added the Daily KSv2 label Jan 7, 2025
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 9, 2025
@luacmartins luacmartins added the NewFeature Something to build that is a new item. label Jan 9, 2025
Copy link

melvin-bot bot commented Jan 9, 2025

Triggered auto assignment to @maddylewis (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Jan 14, 2025
@garrettmknight garrettmknight added the Internal Requires API changes or must be handled by Expensify staff label Jan 14, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 21, 2025
@melvin-bot melvin-bot bot changed the title [Search v1.2] Add violations to inline submit actions [HOLD for payment 2025-01-28] [Search v1.2] Add violations to inline submit actions Jan 21, 2025
Copy link

melvin-bot bot commented Jan 21, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 21, 2025
Copy link

melvin-bot bot commented Jan 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-28. 🎊

For reference, here are some details about the assignees on this issue:

  • @hungvu193 requires payment through NewDot Manual Requests

Copy link

melvin-bot bot commented Jan 21, 2025

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@hungvu193] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@maddylewis] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@garrettmknight garrettmknight moved this from Bugs and Follow Up Issues to Hold for Payment in [#whatsnext] #expense Jan 21, 2025
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 27, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Payment Summary

Upwork Job

BugZero Checklist (@maddylewis)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@maddylewis
Copy link
Contributor

@hungvu193 - will this change require a regression test?

@luacmartins
Copy link
Contributor Author

I don't think we need one for this particular issue since it's a pretty small edge case

@maddylewis
Copy link
Contributor

Confirm Payment Summary

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Jan 29, 2025
@garrettmknight
Copy link
Contributor

$250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
Status: Done
Development

No branches or pull requests

4 participants