Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate workflow job failing on main: lint / ESLint check #54193

Closed
github-actions bot opened this issue Dec 16, 2024 · 4 comments
Closed

Investigate workflow job failing on main: lint / ESLint check #54193

github-actions bot opened this issue Dec 16, 2024 · 4 comments
Assignees
Labels

Comments

@github-actions
Copy link
Contributor

🚨 Failure Summary 🚨:

  • 📋 Job Name: lint / ESLint check
  • 🔧 Failure in Workflow: Process new code merged to main
  • 🔗 Triggered by PR: PR Link
  • 👤 PR Author: @mkzie2
  • 🤝 Merged by: @MariaHCD
  • 🐛 Error Message:
    warning: ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see Ubuntu-latest workflows will use Ubuntu-24.04 image actions/runner-images#10636
    failure: Unsafe argument of type any assigned to a parameter of type string | undefined
    failure: Unsafe member access .params on an error typed value
    warning: React Hook useCallback has an unnecessary dependency: 'route.params.backTo'. Either exclude it or remove the dependency array. Outer scope values like 'route.params.backTo' aren't valid dependencies because mutating them doesn't re-render the component
    failure: Unsafe member access .params on an error typed value
    failure: Process completed with exit code 1.

⚠️ Action Required ⚠️:

🛠️ A recent merge appears to have caused a failure in the job named lint / ESLint check.
This issue has been automatically created and labeled with Workflow Failure for investigation.

👀 Please look into the following:

  1. Why the PR caused the job to fail?
  2. Address any underlying issues.

🐛 We appreciate your help in squashing this bug!

@MariaHCD
Copy link
Contributor

lint / ESLint check passed for the PR 🤔

https://github.com/Expensify/App/actions/runs/12062962593/job/33637441870

@MariaHCD
Copy link
Contributor

From the ESLint check on main:

Screenshot 2024-12-16 at 5 25 04 PM

@MariaHCD
Copy link
Contributor

Revert: #54198

@mkzie2 mkzie2 mentioned this issue Dec 16, 2024
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 16, 2024
@MariaHCD
Copy link
Contributor

Resolved via #54198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant