Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix: navigate to LHN after onboarding" #54198

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

MariaHCD
Copy link
Contributor

Reverts #53239

@MariaHCD MariaHCD requested review from lakchote and mollfpr December 16, 2024 13:49
@MariaHCD MariaHCD self-assigned this Dec 16, 2024
@MariaHCD MariaHCD requested a review from a team as a code owner December 16, 2024 13:49
@melvin-bot melvin-bot bot removed the request for review from a team December 16, 2024 13:50
Copy link

melvin-bot bot commented Dec 16, 2024

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested a review from techievivek December 16, 2024 13:55
Copy link

melvin-bot bot commented Dec 16, 2024

@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link

melvin-bot bot commented Dec 16, 2024

🎯 @mollfpr, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #54199.

@mkzie2
Copy link
Contributor

mkzie2 commented Dec 16, 2024

@MariaHCD I create a quick fix here. Please help to take a look.

@MariaHCD MariaHCD merged commit 476f397 into main Dec 16, 2024
14 of 17 checks passed
@MariaHCD MariaHCD deleted the revert-53239-mkzie2-issue/52420 branch December 16, 2024 14:33
@melvin-bot melvin-bot bot added the Emergency label Dec 16, 2024
Copy link

melvin-bot bot commented Dec 16, 2024

@MariaHCD looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@MariaHCD
Copy link
Contributor Author

Straight revert, PR author and reviewer checklists are not needed.

@MariaHCD
Copy link
Contributor Author

Ah, @mkzie2, I saw your comment too late.

I just saw your PR: #54200

But let's include the changes from the PR that we just reverted.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.77-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.77-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants