Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #53630 from FitseTLT/fix-showing-workspace… #54197

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

lakchote
Copy link
Contributor

Reverts #53630

This is blocking the app deploy, and is responsible for

image

https://github.com/Expensify/App/actions/runs/12350358982/job/34463064849

Lint tests are failing, but they are already failing on main (see https://github.com/Expensify/App/actions/runs/12353330258)

…-current-user-is-not-member"

This reverts commit 653af04, reversing
changes made to 0d17435.
Copy link

melvin-bot bot commented Dec 16, 2024

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@lakchote
Copy link
Contributor Author

Regarding the lint tests failing please check this discussion.

A C+ is working to fix them.

@lakchote
Copy link
Contributor Author

This revert PR will fix the lint tests.

@lakchote lakchote merged commit f0461fb into main Dec 16, 2024
12 of 17 checks passed
@lakchote lakchote deleted the lucien/revert-53630 branch December 16, 2024 13:57
@melvin-bot melvin-bot bot added the Emergency label Dec 16, 2024
Copy link

melvin-bot bot commented Dec 16, 2024

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@lakchote
Copy link
Contributor Author

Removing the label, it's a straight revert.

Copy link
Contributor

🚀 Deployed to staging by https://github.com/lakchote in version: 9.0.77-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Copy link
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.0.77-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants