[HOLD for payment 2025-01-17] [$250] Web - QBO - Hint text for Vendor bill is not below the toggle

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.76-12
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Workspace is connected to QBO.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Accounting.
3. Click Export.
4. Click Export company card expenses as.
5. Click Export as.
6. Select Vendor bill.

Expected Result:

The hint text for Vendor bill is below the toggle (PR #43973) (this is also the same behavior in Advanced page).

Actual Result:

The hint text for Vendor bill is not below the toggle.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876342286796656020
• Upwork Job ID: 1876342286796656020
• Last Price Increase: 2025-01-06

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Edited by proposal-police: This proposal was edited at 2024-12-20 20:35:53 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The hint text for Vendor bill is not below the toggle.

What is the root cause of that problem?

We don't pass shouldPlaceSubtitleBelowSwitch to ToggleSettingOptionRow then the hint text is not displayed below the toggle. This happens after this PR where we missed this prop when implementing the offline pattern

App/src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

Line 70 in 01c0ad9

<ToggleSettingOptionRow

App/src/pages/workspace/workflows/ToggleSettingsOptionRow.tsx

Line 167 in 01c0ad9

{!shouldPlaceSubtitleBelowSwitch && subtitle && subTitleView}

What changes do you think we should make in order to solve the problem?

Pass shouldPlaceSubtitleBelowSwitch here

App/src/pages/workspace/accounting/qbo/export/QuickbooksCompanyCardExpenseAccountPage.tsx

Line 70 in 01c0ad9

<ToggleSettingOptionRow

We can check other places that use ToggleSettingOptionRow and pass the same prop if we want the hint text is also displayed below the toggle in this place.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@isabelastisser Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@isabelastisser Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@isabelastisser 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@isabelastisser this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@isabelastisser 12 days overdue. Walking. Toward. The. Light...

[shubham1206agra]

Since I have creds to the QBO connection, it has not been updated for 2 weeks for some reason. Let me take over this issue as a reviewer.

@mkzie2's proposal looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[isabelastisser]

I was OOO. Looking.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021876342286796656020

[melvin-bot]

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

[mkzie2]

@shubham1206agra The PR is ready.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: hint text for Vendor bill is not below the toggle #54854

If no regressions arise, payment will be issued on 2025-01-17. 🎊

For reference, here are some details about the assignees on this issue:

• @shubham1206agra requires payment (Needs manual offer from BZ)
• @mkzie2 requires payment (Needs manual offer from BZ)

[melvin-bot]

@shubham1206agra @isabelastisser @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[isabelastisser]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[shubham1206agra]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/46511/files#r1917034726

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Workspace is connected to QBO.

Test:

1. Go to App
2. Go to workspace settings > Accounting.
3. Click Export.
4. Click Export company card expenses as.
5. Click Export as.
6. Select Vendor bill.
7. Verify that the hint text for Vender bill displays below the toggle.

Do we agree 👍 or 👎

[shubham1206agra]

@isabelastisser Can you send the offers here please?

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)
• ROLE: @mkzie2 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@isabelastisser)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1876342286796656020/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[isabelastisser]

ROLE: @shubham1206agra paid $250 via Upwork link
ROLE: @mkzie2 pending payment in Upwork $250. Please share your Upwork profile, thanks.

[melvin-bot]

@Julesssss, @isabelastisser, @shubham1206agra, @mkzie2 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[isabelastisser]

@mkzie2, what's your Upwork profile?

[mkzie2]

@isabelastisser Hey, it's https://www.upwork.com/freelancers/~019f73367b03c6d784

[isabelastisser]

Payments are processed in Upwork. all set!