[HOLD for payment 2025-01-15] [HOLD for payment 2025-01-13] Workspace- Workspace name could not be edited/updated

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): testpayment935@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung s10/ Chrome
App Component: Workspace Settings

Action Performed:

1. Navigate to https://staging.new.expensify.com
2. Create a WS and navigate to WS profile
3. Try to edit WS name

Expected Result:

WS name can be edited/ Updated

Actual Result:

WS name could not be edited/ updated

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6704696_1735687069171.bandicam_2025-01-01_02-13-42-508.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mallenexpensify

[melvin-bot]

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mallenexpensify]

Confirming I am able to reproduce on staging and not on production.
@marcaaron is working ~25% today so he might already be off.

We're not deploying to production on NYE or New Year's Day, right ? Which makes me think that Thurs would be the earliest.

Only issue I could quickly find that looked like it could be related

• [HOLD for payment 2025-01-15] [$50] mWeb - Workspace - In offline, unable to save workspace name/ description #54609

[NJ-2020]

Offending PR: #52812

We're changing the param name here from
policyID, name, currencyValue
to
name, currencyValue, policyID

But we're not updating here which is (policyID, name, currencyValue)

App/src/pages/workspace/WorkspaceNamePage.tsx

Line 34 in e5108a1

Policy.updateGeneralSettings(policy.id, values.name.trim(), policy.outputCurrency);

So inside the onSubmit function here we will exit from updating the workspace name if the policy value is undefined

Since we do not update it here the policyID value is the currencyValue and when we check here it will return true

App/src/pages/workspace/WorkspaceNamePage.tsx

Line 34 in e5108a1

Policy.updateGeneralSettings(policy.id, values.name.trim(), policy.outputCurrency);

App/src/libs/actions/Policy/Policy.ts

Lines 1196 to 1200 in e5108a1

	function updateGeneralSettings(name: string, currencyValue?: string, policyID?: string) {
	const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${policyID}`];
	if (!policy || !policyID) {
	return;
	}

cc: @mallenexpensify

---

I can raise a PR if needed

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[Beamanator]

cc @pasyukevich @hungvu193 - messaged y'all in slack, but this may related to your PR

[hungvu193]

#54722 is ready!

[Beamanator]

PR merged, CPing now

• no payment needed as this was a regression, also the solution didn't follow the above proposal

[Beamanator]

PR CP'd - @hungvu193 are you free to test in staging?

[hungvu193]

PR CP'd - @hungvu193 are you free to test in staging?

Yep. Checking now

[hungvu193]

Confirm it's fixed on Staging 🎉

Screen.Recording.2025-01-02.at.16.06.09.mov

[Beamanator]

amazing, thanks!! closing since no payment due 👍

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Update updateGeneralSettings params #54722

If no regressions arise, payment will be issued on 2025-01-13. 🎊

[melvin-bot]

@Beamanator @mallenexpensify @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Update updateGeneralSettings params #54722

If no regressions arise, payment will be issued on 2025-01-15. 🎊

[melvin-bot]

@Beamanator @mallenexpensify @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]