Deploy Checklist: New Expensify 2024-12-31

[github-actions]

Release Version: 9.0.80-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix: messages content overlap when bottom sheet is shown #42143
• Implemented International Bank Account flow #52322
• feat: Update corpay fields logic, integrate API #52812
• fix clear cached data after account switch #52822
• fix: removing extra pair of quotes in keyword filter #53158
• fix search invoice page doesn't display merchant text "expense" #53349
• fix: paying expense and canceling payment don't scroll down to comments #53430
• Fix: App back button returns to the same page after clicking back button on Import RHP #53520
• Fix thread is displayed after going back from search #53731
• [No QA] Add unit test for report should not be displayed in LHN #53745
• Fix unable to upload a receipt size larger than 15mb #53902
• Fix new individual invoice after one is paid as a business #54138
• Add Friendly Sign-Off to Concierge Onboarding Messages for a More Inviting LHN Preview #54144
• [No QA] Update comment followup from 54110 #54229
• Feature: Add spinning loader until full list of policies is successfully download on the client #54238
• fix: auto insert OTP not working #54253
• fix: display invoices badge currency #54277
• Fix composer educational tooltip wrong position on mWeb Safari #54344
• Fix - Validate account - When validate page is opened twice, code error auto disappears #54405
• Refactor buildOptimisticTransaction function #54491
• Adding images into the Bill Pay help article #54543
• fix: missing suffix in native BaseTextInput #54549
• Don't apply the category tax rules for distance request #54579
• Filter deleted workspace categories #54613
• Correctly handle negative numbers for per diem rates #54654
• [CP Staging] update preserved keys #54705
• [CP Staging] Revert "Fix unable to upload a receipt size larger than 15mb" #54719
• [CP Staging] Update updateGeneralSettings params #54722
• [CP Staging] Revert "Implemented International Bank Account flow" #54729
• [CP Staging] Revert "fix: messages content overlap when bottom sheet is shown" #54730

Internal QA:

• Improve feed removal flow offline #54425 - @mountiny

Deploy Blockers:

• [HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02] Icons are decolorized in security  #54480
• Bank account - Workspace currency is not changed to USD after clicking Update to USD #54691
• Wallet - Account number field shows two error messages when it is empty #54692
• Group - Website crashes when leaving group chat. #54693
• Wallet - Currency does not auto update after changing country #54694
• Concierge-"Something went wrong" page appears when opening tasks in Concierge chat #54695
• Workspace- Workspace name could not be edited/updated #54696
• Validate account - Verify button loads infinitely on magic code page #54697
• Login - Infinite loading and no error message when typing wrong Magic Code. #54698
• Reports - Website crashes when opening expenses on reports section. #54699
• Wallet - Bank account subtitle shows undefined after adding bank account #54707
• Invoices - Bank account setup restarts after clicking Continue on success page #54708
• [$250] Wallet -Order of bank & account holder fields is different on individual page and confirm page #54709
• Wallet - Error message indicates "swift code" as "routing number" #54711
• iOS - Edit composer is hidden behind keyboard when editing message #54712
• [$250] iOS - Chat - Big gap in the background when context menu is opened #54713
• Contact method - "Please enter the magic code sent to..." is missing current email #54714
• 2FA - Unable to login to account with 2FA enabled #54718
• Wallet - Checkbox on confirmation page becomes unchecked after returning from field editor #54720
• Web - BA - The Connect bank account page loads after refreshing the page for a new user #54727
• Bank Account - User does not land back on the country selector after closing the plaid UI. #54737
• Wallet - Error indicating a selection is required is not shown in account selection page #54738
• Wallet - Selected account type is not shown after returning back #54739
• [$250] Wallet - Prior bank account detail inputs are not shown. #54740
• Wallet - Excluded countries and their currencies are shown #54741
• Wallet - Account number field is not focused #54742
• Wallet - Corpay error message is not shown for invalid account and Swift Code #54745
• Wallet - In offline mode, no full blocking view in country page, country & currency are editable #54746
• Wallet - The top of the confirmation page header is not “Check your info.” #54749
• Wallet - Error for invalid IBAN should be "Invalid IBAN" instead of "400 invalid IBAN" #54751
• Wallet - Bank name and account holder name fields accept emoji as name #54752
• [AU] - Public room deeplink leads to skeleton loader for anonymous user #54753
• Wallet - Country list does not auto scroll up when showing search result #54757
• App directly opens Connect via Plaid flow when adding WS bank after adding personal bank acc #54762

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[kavimuru]

Regression is 82% completed.
Android build is still not available yet, so all the android platform validations are pending.

[Beamanator]

#54739 marked NAB b/c it's most likely expected behavior

[Beamanator]

checking off #54696 as fixed by #54722, confirmed working in staging

[izarutskaya]

Regression is 83% completed.
All Android slots waiting, still no build

Unchecked PRs:
#53902 - #53902 (comment)
#54138 - failing with #54138 (comment)
#54344 - failing with #54344 (comment)

DB:
#54480
#54691
#54693
#54695
#54698
#54699
#54712
#54714
#54718
#54727
#54737
#54738
#54740
#54741
#54742
#54745
#54746

[cristipaval]

checking off #54751, NAB

[grgia]

checking off #54691, fixed

[grgia]

demoting #54749, copy change with likely outdated regression test

[Beamanator]

demoted #54741

[Beamanator]

also demoted #54740

[Beamanator]

demoted #54742 as well

[Beamanator]

Checking off #54138 b/c the reported issue (here) was marked not a bug (here)

[Beamanator]

#42143 was reverted, so checking it off

• Also checking off iOS - Edit composer is hidden behind keyboard when editing message #54712 b/c it was fixed by the revert [CP Staging] Revert "fix: messages content overlap when bottom sheet is shown" #54730

[Beamanator]

#52322 was reverted, so checking it off

• The revert PR [CP Staging] Revert "Implemented International Bank Account flow" #54729 is still being tested (see many related blockers / bugs in [Tracking Issue] Fixes to Implemented International Bank Account flow #54743) - so won't check any of those off yet

[Beamanator]

Checking off #54480 b/c it's not reproducible in staging

[Beamanator]

Checking off #54714 as reproducible on prod

[neil-marcellini]

Checking off #54753. It's not reproducible on staging.

[kavimuru]

Regression is 2% left
Unchecked PRs:
#42143 (comment)
#52812 failing with #54691
#54138 failing with #54723
#53902 (comment)
#54344 - failing with #54701 repro in PROD checking it off.
working on CPs

[izarutskaya]

Regression is completed.

#42143 (comment)
#52812 - can I check off based this comment ?#54691 (comment)
#54138 - can I check off based this comment ?#54723 (comment)
#53902 (comment)

DB:
#54693
#54695
#54698
#54699
#54727
#54737
#54738
#54752
#54757
#54762