Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-15] [HOLD for payment 2025-01-13] Web - BA - The Connect bank account page loads after refreshing the page for a new user #54727

Closed
1 of 8 tasks
IuliiaHerets opened this issue Jan 1, 2025 · 13 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 1, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: No
Issue reported by: Applause Internal Team
Device used: Mac 14.6.1
App Component: Workspace Settings

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Login as a new user
  3. Create a workspace with USD default currency
  4. Enable Workflows
  5. Click "Connect bank account"

Expected Result:

The Connect bank account page loads without refreshing the page

Actual Result:

The Connect bank account page loads after refreshing the page for a new user

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6704711_1735696181587.Recording__331.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @MitchExpensify
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Jan 1, 2025
Copy link

melvin-bot bot commented Jan 1, 2025

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 1, 2025

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 1, 2025

💬 A slack conversation has been started in #expensify-open-source

@melvin-bot melvin-bot bot added the Daily KSv2 label Jan 1, 2025
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 1, 2025
Copy link
Contributor

github-actions bot commented Jan 1, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

Production

Recording.333.mp4

@IuliiaHerets IuliiaHerets changed the title BA - The Connect bank account page loads after refreshing the page for a new user Web - BA - The Connect bank account page loads after refreshing the page for a new user Jan 1, 2025
@ijmalik
Copy link
Contributor

ijmalik commented Jan 2, 2025

Hi @MitchExpensify, @grgia

This issue seems to have originated from a previous pull request by @huult. He has now submitted a new pull request to address this.

The issue Login - Infinite loading and no error message when typing wrong Magic Code. will also be resolved by this PR.

Thank you!

@grgia
Copy link
Contributor

grgia commented Jan 2, 2025

I commented on the linked PR to ensure we link this issue as well

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
@isagoico
Copy link

isagoico commented Jan 6, 2025

Issue not reproducible anymore on 9.0.80-6

bandicam.2025-01-06.19-42-53-424.mp4

@puneetlath puneetlath added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 6, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Overdue Daily KSv2 labels Jan 6, 2025
@melvin-bot melvin-bot bot changed the title Web - BA - The Connect bank account page loads after refreshing the page for a new user [HOLD for payment 2025-01-13] Web - BA - The Connect bank account page loads after refreshing the page for a new user Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.80-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-13. 🎊

Copy link

melvin-bot bot commented Jan 6, 2025

@grgia @MitchExpensify @grgia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@MitchExpensify
Copy link
Contributor

No payment or BZ stepsare needed here as the fix was here #54705

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 8, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-01-13] Web - BA - The Connect bank account page loads after refreshing the page for a new user [HOLD for payment 2025-01-15] [HOLD for payment 2025-01-13] Web - BA - The Connect bank account page loads after refreshing the page for a new user Jan 8, 2025
Copy link

melvin-bot bot commented Jan 8, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.81-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-15. 🎊

Copy link

melvin-bot bot commented Jan 8, 2025

@grgia @MitchExpensify @grgia The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants