Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking Issue] Fixes to Implemented International Bank Account flow #54743

Open
Beamanator opened this issue Jan 2, 2025 · 10 comments
Open
Assignees
Labels
Reviewing Has a PR in review Weekly KSv2

Comments

@Beamanator
Copy link
Contributor

This big PR has lots of little issues we need to fix. Tracking them here so we can try to keep them all in 1 place & note what the next steps are for each

cc @shubham1206agra @DylanDylann @MonilBhavsar

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Jan 2, 2025

Still marked as blockers - now need to be tested to see if they're fixed in staging:

Issues marked NAB - probably can close them all, but need to be addressed before next mega PR is merged:

@Julesssss
Copy link
Contributor

Julesssss commented Jan 2, 2025

Happy 2025, here's another bug to fix, I added it to the list above: #54746

@Beamanator
Copy link
Contributor Author

Beamanator commented Jan 2, 2025

Reverted the big PR (#54729), will CP soon after making sure it didn't break everything

@parasharrajat
Copy link
Member

We can start closing the related issues in that case.

@Beamanator
Copy link
Contributor Author

Yeah once it's CP'd 🙏

@Beamanator
Copy link
Contributor Author

Ok so the revert CP was successful, in 9.0.80.6

I'm going to ask QA to help test all of the issues on this list, starting with the blockers, to at least help us unblock the deploy

@Beamanator
Copy link
Contributor Author

Once each is confirmed fix / not reproducible in staging, we can check them of the list above.

Finally, @shubham1206agra will be working on making sure none exist in his next PR (looks like the draft was started above)

@izarutskaya
Copy link

izarutskaya commented Jan 3, 2025

#54737 - found issue - #52199
#54738 - issue #52199
#54740 - issue #52199
#54746 - found issue #54767
#54749 - issue #52199
#54751 - issue #52199
#54742 - issue #52199
#54692 - pending on Web

@izarutskaya
Copy link

#54692 - all slots are passed. Checking off

@shubham1206agra
Copy link
Contributor

@MonilBhavsar Can you close all the issues? Since I will keep track of these through this tracker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants