[HOLD: #49539] Invoices - Bank account setup RHP starts from the beginning after adding a US bank account

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+230102kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Invoices.
3. Click Add bank account.
4. Select United States as the country.
5. Proceed with adding a US bank account.
6. Click Continue on success page.

Expected Result:

Bank account setup RHP will close.

Actual Result:

Bank account setup RHP starts from the beginning.

This issue only happens when adding bank account in Invoices page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6722166_1737665999367.20250124_045524.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[chiragsalian]

Looking at the video it looks like an App bug and not a backend bug. This is because i see the bank added to the account just fine in the UI. It looks like the navigation on click of the continue button is just wrong. Removing deployblocker label but keep deployblockerCash label.

[francoisl]

The most likely PR for this that I see so far is #54798, going to run some tests locally to confirm.

[MonilBhavsar]

Francois, happens only for beta users so I think we can demote it.

---

@shubham1206agra if you could please take a look cc @DylanDylann

[francoisl]

I reverted #54798 locally and that fixed the issue. I'm not saying we need to revert it for real, but it confirms that's where the issue was from. Let's try to fix the root cause without reverting ideally, since it's still on a beta.

[chiragsalian]

Let's try to fix the root cause without reverting ideally, since it's still on a beta.

+1

[melvin-bot]

@stephanieelliott, @MonilBhavsar, @shubham1206agra Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[DylanDylann]

@shubham1206agra Could you confirm this issue will be solved by #49539?

[shubham1206agra]

Please hold this issue on #49539

[DylanDylann]

@MonilBhavsar @shubham1206agra #49539 was merged

Could you reproduce this issue anymore?

For me, I can't reproduce it because of this situation

Screen.Recording.2025-02-17.at.15.13.48.mov

[DylanDylann]

@MonilBhavsar I can't reproduce this issue anymore

cc @shubham1206agra

Screen.Recording.2025-02-18.at.16.22.45.mov

[stephanieelliott]

I also can't reproduce! I am gonna go ahead and close this.

[DylanDylann]

@stephanieelliott Could you process payment here as mentioned here?

cc @MonilBhavsar

[shubham1206agra]

Hold up @DylanDylann. Let me discuss payment first.

[DylanDylann]

Could you send me the discussion link?

[joekaufmanexpensify]

Note: please only handle @DylanDylann's payment in this issue. @shubham1206agra was hired for the full international deposit accounts project and I am handling his payment holistically once the project is complete.

[DylanDylann]

@joekaufmanexpensify If we still need to implement other features on the international deposit accounts project. Could I continue to help speed it up? because I already worked on this implementation and some follow-up issues

[joekaufmanexpensify]

I think we are good for now, we are close to closing out the project. Just a few minor bugs in process. TY for the offer though!

[DylanDylann]

@joekaufmanexpensify How much should I get for #54798 and follow-up PRs (regression)?

[joekaufmanexpensify]

Could you list out all the follow up PRs you reviewed for regressions?

[DylanDylann]

This is the original PR:

• Implemented International Bank Account flow #52322
• Implemented International Bank Account flow #54798 (The first PR was reverted then we need to create a new PR to include some new fixes)

This is the follow-up PRs:

• Fixed bank account pop up in Invoice page #56236

cc @MonilBhavsar @shubham1206agra

[joekaufmanexpensify]

Does $500 sound good? As there were two main PRs that you reviewed here, one for the feature PR and then a second for the invoice page issue.

[DylanDylann]

@joekaufmanexpensify It is fine to me

[joekaufmanexpensify]

Sweet. I will handle that now. Going to reopen #51082 as that is the main issue and handle there.