Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App directly opens Connect via Plaid flow when adding WS bank after adding personal bank acc #54762

Open
4 of 8 tasks
IuliiaHerets opened this issue Jan 2, 2025 · 7 comments
Assignees
Labels
Daily KSv2 Engineering Needs Reproduction Reproducible steps needed

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.80-6
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, can't add BA on prod
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh2001014@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with a new account.
  3. Create a workspace.
  4. Go to Workspace settings > More features.
  5. Enable Workflows.
  6. Go to Workflows.
  7. Click Connect bank account.
  8. Cilck Update to USD.
  9. Close the RHP after updating to USD. (important)
  10. Go to Account settings > Wallet.
  11. Click Add bank account (Wells Fargo).
  12. Go through add bank account flow.
  13. After adding a personal bank account, go back to Workspace settings > Workflows.
  14. Click Connect bank account.

Expected Result:

RHP will open with Connect via Plaid and Connect manually options.

Actual Result:

RHP directly opens Connect via Plaid setup.

It only shows Connect via Plaid and Connect manually options after quitting the flow and reopening it.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6705201_1735832620767.20250102_233331.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jan 2, 2025
Copy link

melvin-bot bot commented Jan 2, 2025

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 2, 2025

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 2, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@cead22
Copy link
Contributor

cead22 commented Jan 2, 2025

It only shows Connect via Plaid and Connect manually options after quitting the flow and reopening it.

I thought this was by design. Regardless, I don't think this needs to be a blocker, at least not for web

@cead22 cead22 removed the DeployBlocker Indicates it should block deploying the API label Jan 2, 2025
@marcochavezf
Copy link
Contributor

I wasn't able to reproduce it in staging

@marcochavezf marcochavezf added Daily KSv2 Needs Reproduction Reproducible steps needed and removed Hourly KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Jan 2, 2025
@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Needs Reproduction Reproducible steps needed
Projects
None yet
Development

No branches or pull requests

5 participants